New issue
Advanced search Search tips

Issue 746555 link

Starred by 1 user
Status: Fixed
Owner:
finnur@chromium.org
Closed: Aug 2017
Cc:
peter@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Clank Media Picker: shadow under blue selection checkmark should have no x-offset

Project Member Reported by owe...@chromium.org, Jul 19 2017 
Feedback from UI review: shadow beneath the blue selection checkmark looks a bit diagonal (my eyes expect straight down)

Comment 1 by finnur@chromium.org, Aug 11 2017 

Confirmed, it is a bit diagonal but here's what it looks like with my proposed patch.
Screenshot from 2017-08-11 17:35:00.png
13.2 KB View Download
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 14 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0bdbd8d4180126e0fbdcb6febaf2919ce5c022e4

commit 0bdbd8d4180126e0fbdcb6febaf2919ce5c022e4
Author: Finnur Thorarinsson <finnur@chromium.org>
Date: Mon Aug 14 11:37:17 2017

Photo Picker dialog: Fix shadow on selection.

Bug:  746555 
Change-Id: Ie163d1b4d3646a78ca588e13813520a27bcc58a4
Reviewed-on: https://chromium-review.googlesource.com/612384
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Finnur Thorarinsson <finnur@chromium.org>
Cr-Commit-Position: refs/heads/master@{#494033}
[modify] https://crrev.com/0bdbd8d4180126e0fbdcb6febaf2919ce5c022e4/chrome/android/java/res/drawable/checkmark_blue.xml

Comment 3 by finnur@chromium.org, Aug 14 2017

Status: Fixed (was: Available)
►

Sign in to add a comment