New issue
Advanced search Search tips

Issue 746551 link

Starred by 1 user
Status: Fixed
Owner:
finnur@chromium.org
Closed: Aug 2017
Cc:
peter@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Clank Media Picker: browse/camera ripple clipped wrongly and shouldn't be shown when disabled

Project Member Reported by owe...@chromium.org, Jul 19 2017 
Feedback from UI Review:

the browse/camera ripple is clipped by the text unexpectedly - and ripple probably shouldn't show at all when these are disabled
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 18 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c972ec487fbd4c5266f047d6775df3dccfc60149

commit c972ec487fbd4c5266f047d6775df3dccfc60149
Author: Finnur Thorarinsson <finnur@chromium.org>
Date: Fri Aug 18 10:14:50 2017

Photo Picker Dialog: Fix ripples on special tiles.

Ripples should not show on the Camera/Browse buttons when they are disabled.
But when they are enabled, the ripple should extend all the way down.

Bug:  746551 ,  656015 
Change-Id: Ia3ba430e763352b287054c696f49de8566b67ec0
Reviewed-on: https://chromium-review.googlesource.com/619150
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Finnur Thorarinsson <finnur@chromium.org>
Cr-Commit-Position: refs/heads/master@{#495517}
[modify] https://crrev.com/c972ec487fbd4c5266f047d6775df3dccfc60149/chrome/android/java/res/layout/photo_picker_bitmap_view.xml
[modify] https://crrev.com/c972ec487fbd4c5266f047d6775df3dccfc60149/chrome/android/java/src/org/chromium/chrome/browser/photo_picker/PickerBitmapView.java

Comment 2 by finnur@chromium.org, Aug 18 2017

Status: Fixed (was: Available)
►

Sign in to add a comment