New issue
Advanced search Search tips

Issue 746544 link

Starred by 1 user
Status: Fixed
Owner:
anthonyvd@chromium.org
Closed: Jul 2017
Cc:
tmartino@chromium.org
ma...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Bug



Sign in to add a comment

[WebPayments] DCHECK for Profile Completeness Cache triggers

Project Member Reported by tmartino@chromium.org, Jul 19 2017 
Steps to repro in Debug builds only:

1. Add an incomplete Autofill profile
2. Open a Payment Request dialog
3. Click to open the shipping address sheet
4. Click on this profile, opening the editor
5. Without changing the profile or saving, click on the back button several times to go back to the main payment sheet
6. Open the shipping address sheet again
7. DCHECK causes crash

Somewhere in here, the profile is changing, because the results of evaluating it for completeness are different before and after opening the editor.

Comment 1 by tmartino@chromium.org, Jul 19 2017 

The issue appears to be this line in the Shipping Address Editor:

https://cs.chromium.org/chromium/src/chrome/browser/ui/views/payments/shipping_address_editor_view_controller.cc?l=289&rcl=33a125276dcaa92d894b6109541e3b91cab1bb66

profile_to_edit_->SetInfo(country_type,
                                  countries_[chosen_country_index_].second,
                                  state()->GetApplicationLocale());

We're writing a default country to the profile if it doesn't have one; however, this is not a temporary profile but the actual cached profile--which means the changed country will persist for the lifetime of the dialog.

Comment 2 by tmartino@chromium.org, Jul 20 2017

Cc: -anthonyvd@chromium.org tmartino@chromium.org
Owner: anthonyvd@chromium.org
Assigning to Anthony, who is looking at this snippet for other reasons.
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 20 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f4f053cc840dc7f4ff56950bb88be6a7422d6331

commit f4f053cc840dc7f4ff56950bb88be6a7422d6331
Author: Anthony Vallee-Dubois <anthonyvd@chromium.org>
Date: Thu Jul 20 21:27:30 2017

[Web Payments] Use temporary autofill profile in shipping editor

Bug:  746544 
Change-Id: I0b6813c118d90b47dd5b82c5721bac3d5e05aca1
Reviewed-on: https://chromium-review.googlesource.com/580070
Commit-Queue: Anthony Vallee-Dubois <anthonyvd@chromium.org>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488412}
[modify] https://crrev.com/f4f053cc840dc7f4ff56950bb88be6a7422d6331/chrome/browser/ui/views/payments/shipping_address_editor_view_controller.cc
[modify] https://crrev.com/f4f053cc840dc7f4ff56950bb88be6a7422d6331/chrome/browser/ui/views/payments/shipping_address_editor_view_controller.h
[modify] https://crrev.com/f4f053cc840dc7f4ff56950bb88be6a7422d6331/chrome/browser/ui/views/payments/shipping_address_editor_view_controller_browsertest.cc

Comment 4 by ma...@chromium.org, Jul 24 2017 

Is this fixed then?

Comment 5 by anthonyvd@chromium.org, Jul 24 2017

Status: Fixed (was: Started)
►

Sign in to add a comment