Explainer: https://github.com/WICG/aom/blob/gh-pages/explainer.md Spec: https://wicg.github.io/aom/spec/
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fc79b0926b78c20eb703729caa3ce01f45a2feda commit fc79b0926b78c20eb703729caa3ce01f45a2feda Author: Dominic Mazzoni <dmazzoni@chromium.org> Date: Thu Aug 03 02:16:14 2017 Accessibility Object Model: Dispatch accessibleclick event. Phase 2 of the Accessibility Object Model makes each AccessibleNode an EventTarget and allows developers to register event handlers for accessibility-specific events. Accessibility events go through a capturing and bubbling phase just like DOM events, but in the accessibility tree. In this change we just implement the "accessibleclick" event and test that it works and how it interacts with DOM event listeners. Bug: 746524 Change-Id: Ia46bbe3e7dcdfedf173a7296613fb998487427a9 Reviewed-on: https://chromium-review.googlesource.com/577960 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by: Alice Boxhall <aboxhall@chromium.org> Reviewed-by: Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#491616} [add] https://crrev.com/fc79b0926b78c20eb703729caa3ce01f45a2feda/third_party/WebKit/LayoutTests/accessibility/aom-actions.html [modify] https://crrev.com/fc79b0926b78c20eb703729caa3ce01f45a2feda/third_party/WebKit/LayoutTests/accessibility/aom-boolean-properties.html [modify] https://crrev.com/fc79b0926b78c20eb703729caa3ce01f45a2feda/third_party/WebKit/LayoutTests/accessibility/aom-float-properties.html [modify] https://crrev.com/fc79b0926b78c20eb703729caa3ce01f45a2feda/third_party/WebKit/LayoutTests/accessibility/aom-int-properties.html [modify] https://crrev.com/fc79b0926b78c20eb703729caa3ce01f45a2feda/third_party/WebKit/LayoutTests/accessibility/aom-relation-properties.html [modify] https://crrev.com/fc79b0926b78c20eb703729caa3ce01f45a2feda/third_party/WebKit/LayoutTests/accessibility/aom-string-properties.html [modify] https://crrev.com/fc79b0926b78c20eb703729caa3ce01f45a2feda/third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload-disabled/webexposed/global-interface-listing-expected.txt [modify] https://crrev.com/fc79b0926b78c20eb703729caa3ce01f45a2feda/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt [modify] https://crrev.com/fc79b0926b78c20eb703729caa3ce01f45a2feda/third_party/WebKit/Source/core/dom/AccessibleNode.cpp [modify] https://crrev.com/fc79b0926b78c20eb703729caa3ce01f45a2feda/third_party/WebKit/Source/core/dom/AccessibleNode.h [modify] https://crrev.com/fc79b0926b78c20eb703729caa3ce01f45a2feda/third_party/WebKit/Source/core/dom/AccessibleNode.idl [modify] https://crrev.com/fc79b0926b78c20eb703729caa3ce01f45a2feda/third_party/WebKit/Source/core/events/EventTargetFactory.json5 [modify] https://crrev.com/fc79b0926b78c20eb703729caa3ce01f45a2feda/third_party/WebKit/Source/core/events/EventTypeNames.json5 [modify] https://crrev.com/fc79b0926b78c20eb703729caa3ce01f45a2feda/third_party/WebKit/Source/modules/accessibility/AXObject.cpp [modify] https://crrev.com/fc79b0926b78c20eb703729caa3ce01f45a2feda/third_party/WebKit/Source/modules/accessibility/AXObject.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/72947e01e2f423f13183457047bb7c8d763e1893 commit 72947e01e2f423f13183457047bb7c8d763e1893 Author: Dominic Mazzoni <dmazzoni@chromium.org> Date: Wed Aug 23 20:54:46 2017 Add new permission dialog for accessibility events. This is required as part of the Accessibility Object Model phase 2 spec. Bug: 746524 Change-Id: I5b63921663dee00e609ddfaf3aab5577229294c1 Reviewed-on: https://chromium-review.googlesource.com/604830 Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Timothy Loh <timloh@chromium.org> Reviewed-by: Evan Stade <estade@chromium.org> Reviewed-by: Richard Coles <torne@chromium.org> Reviewed-by: Mike West <mkwst@chromium.org> Reviewed-by: Bernhard Bauer <bauerb@chromium.org> Reviewed-by: John Abd-El-Malek <jam@chromium.org> Reviewed-by: Alice Boxhall <aboxhall@chromium.org> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#496801} [modify] https://crrev.com/72947e01e2f423f13183457047bb7c8d763e1893/android_webview/browser/aw_permission_manager.cc [add] https://crrev.com/72947e01e2f423f13183457047bb7c8d763e1893/chrome/android/java/res/drawable-hdpi/infobar_accessibility_events.png [add] https://crrev.com/72947e01e2f423f13183457047bb7c8d763e1893/chrome/android/java/res/drawable-mdpi/infobar_accessibility_events.png [add] https://crrev.com/72947e01e2f423f13183457047bb7c8d763e1893/chrome/android/java/res/drawable-xhdpi/infobar_accessibility_events.png [add] https://crrev.com/72947e01e2f423f13183457047bb7c8d763e1893/chrome/android/java/res/drawable-xxhdpi/infobar_accessibility_events.png [add] https://crrev.com/72947e01e2f423f13183457047bb7c8d763e1893/chrome/android/java/res/drawable-xxxhdpi/infobar_accessibility_events.png [modify] https://crrev.com/72947e01e2f423f13183457047bb7c8d763e1893/chrome/app/generated_resources.grd [modify] https://crrev.com/72947e01e2f423f13183457047bb7c8d763e1893/chrome/browser/BUILD.gn [add] https://crrev.com/72947e01e2f423f13183457047bb7c8d763e1893/chrome/browser/accessibility/accessibility_permission_context.cc [add] https://crrev.com/72947e01e2f423f13183457047bb7c8d763e1893/chrome/browser/accessibility/accessibility_permission_context.h [modify] https://crrev.com/72947e01e2f423f13183457047bb7c8d763e1893/chrome/browser/android/resource_id.h [modify] https://crrev.com/72947e01e2f423f13183457047bb7c8d763e1893/chrome/browser/permissions/permission_manager.cc [modify] https://crrev.com/72947e01e2f423f13183457047bb7c8d763e1893/chrome/browser/permissions/permission_request.h [modify] https://crrev.com/72947e01e2f423f13183457047bb7c8d763e1893/chrome/browser/permissions/permission_request_impl.cc [modify] https://crrev.com/72947e01e2f423f13183457047bb7c8d763e1893/chrome/browser/permissions/permission_util.cc [modify] https://crrev.com/72947e01e2f423f13183457047bb7c8d763e1893/components/content_settings/core/browser/content_settings_registry.cc [modify] https://crrev.com/72947e01e2f423f13183457047bb7c8d763e1893/components/content_settings/core/common/content_settings.cc [modify] https://crrev.com/72947e01e2f423f13183457047bb7c8d763e1893/components/content_settings/core/common/content_settings_types.h [modify] https://crrev.com/72947e01e2f423f13183457047bb7c8d763e1893/components/vector_icons/BUILD.gn [add] https://crrev.com/72947e01e2f423f13183457047bb7c8d763e1893/components/vector_icons/accessibility.icon [modify] https://crrev.com/72947e01e2f423f13183457047bb7c8d763e1893/content/browser/permissions/permission_service_impl.cc [modify] https://crrev.com/72947e01e2f423f13183457047bb7c8d763e1893/content/public/browser/permission_type.h [modify] https://crrev.com/72947e01e2f423f13183457047bb7c8d763e1893/content/shell/browser/layout_test/layout_test_message_filter.cc [modify] https://crrev.com/72947e01e2f423f13183457047bb7c8d763e1893/third_party/WebKit/LayoutTests/accessibility/aom-actions.html [modify] https://crrev.com/72947e01e2f423f13183457047bb7c8d763e1893/third_party/WebKit/LayoutTests/http/tests/resources/permissions-helper.js [modify] https://crrev.com/72947e01e2f423f13183457047bb7c8d763e1893/third_party/WebKit/Source/core/dom/AXObjectCache.cpp [modify] https://crrev.com/72947e01e2f423f13183457047bb7c8d763e1893/third_party/WebKit/Source/core/dom/AXObjectCache.h [modify] https://crrev.com/72947e01e2f423f13183457047bb7c8d763e1893/third_party/WebKit/Source/core/dom/AXObjectCacheBase.cpp [modify] https://crrev.com/72947e01e2f423f13183457047bb7c8d763e1893/third_party/WebKit/Source/core/dom/AXObjectCacheBase.h [modify] https://crrev.com/72947e01e2f423f13183457047bb7c8d763e1893/third_party/WebKit/Source/modules/accessibility/AXObject.cpp [modify] https://crrev.com/72947e01e2f423f13183457047bb7c8d763e1893/third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.cpp [modify] https://crrev.com/72947e01e2f423f13183457047bb7c8d763e1893/third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.h [modify] https://crrev.com/72947e01e2f423f13183457047bb7c8d763e1893/third_party/WebKit/Source/modules/accessibility/DEPS [modify] https://crrev.com/72947e01e2f423f13183457047bb7c8d763e1893/third_party/WebKit/Source/modules/permissions/PermissionDescriptor.idl [modify] https://crrev.com/72947e01e2f423f13183457047bb7c8d763e1893/third_party/WebKit/Source/modules/permissions/Permissions.cpp [modify] https://crrev.com/72947e01e2f423f13183457047bb7c8d763e1893/third_party/WebKit/public/platform/WebFeaturePolicyFeature.h [modify] https://crrev.com/72947e01e2f423f13183457047bb7c8d763e1893/third_party/WebKit/public/platform/modules/permissions/permission.mojom [modify] https://crrev.com/72947e01e2f423f13183457047bb7c8d763e1893/tools/metrics/histograms/enums.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2ba0eea732beefe750d1de5700d86b3a92295061 commit 2ba0eea732beefe750d1de5700d86b3a92295061 Author: Dominic Mazzoni <dmazzoni@chromium.org> Date: Tue Aug 29 03:16:25 2017 Revert "Add new permission dialog for accessibility events." This reverts commit 72947e01e2f423f13183457047bb7c8d763e1893. Reason for revert: Crash in content::PermissionServiceContext::GetBrowserContext (crbug.com/759379) Original change's description: > Add new permission dialog for accessibility events. > > This is required as part of the Accessibility Object Model > phase 2 spec. > > Bug: 746524 > Change-Id: I5b63921663dee00e609ddfaf3aab5577229294c1 > Reviewed-on: https://chromium-review.googlesource.com/604830 > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Timothy Loh <timloh@chromium.org> > Reviewed-by: Evan Stade <estade@chromium.org> > Reviewed-by: Richard Coles <torne@chromium.org> > Reviewed-by: Mike West <mkwst@chromium.org> > Reviewed-by: Bernhard Bauer <bauerb@chromium.org> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Reviewed-by: Alice Boxhall <aboxhall@chromium.org> > Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> > Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#496801} TBR=raymes@chromium.org,dmazzoni@chromium.org,dcheng@chromium.org,bauerb@chromium.org,jam@chromium.org,aboxhall@chromium.org,timloh@chromium.org,torne@chromium.org,estade@chromium.org,haraken@chromium.org,mlamouri@chromium.org,msramek@chromium.org,mkwst@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 746524 Change-Id: Ib5edc87c75f5d26cc8f8f5e5eef663ca859b7df3 Reviewed-on: https://chromium-review.googlesource.com/639970 Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#498006} [modify] https://crrev.com/2ba0eea732beefe750d1de5700d86b3a92295061/android_webview/browser/aw_permission_manager.cc [delete] https://crrev.com/e7365d23780af3a2fcf8845ff4d51a14620a7f74/chrome/android/java/res/drawable-hdpi/infobar_accessibility_events.png [delete] https://crrev.com/e7365d23780af3a2fcf8845ff4d51a14620a7f74/chrome/android/java/res/drawable-mdpi/infobar_accessibility_events.png [delete] https://crrev.com/e7365d23780af3a2fcf8845ff4d51a14620a7f74/chrome/android/java/res/drawable-xhdpi/infobar_accessibility_events.png [delete] https://crrev.com/e7365d23780af3a2fcf8845ff4d51a14620a7f74/chrome/android/java/res/drawable-xxhdpi/infobar_accessibility_events.png [delete] https://crrev.com/e7365d23780af3a2fcf8845ff4d51a14620a7f74/chrome/android/java/res/drawable-xxxhdpi/infobar_accessibility_events.png [modify] https://crrev.com/2ba0eea732beefe750d1de5700d86b3a92295061/chrome/app/generated_resources.grd [modify] https://crrev.com/2ba0eea732beefe750d1de5700d86b3a92295061/chrome/browser/BUILD.gn [delete] https://crrev.com/e7365d23780af3a2fcf8845ff4d51a14620a7f74/chrome/browser/accessibility/accessibility_permission_context.cc [delete] https://crrev.com/e7365d23780af3a2fcf8845ff4d51a14620a7f74/chrome/browser/accessibility/accessibility_permission_context.h [modify] https://crrev.com/2ba0eea732beefe750d1de5700d86b3a92295061/chrome/browser/android/resource_id.h [modify] https://crrev.com/2ba0eea732beefe750d1de5700d86b3a92295061/chrome/browser/permissions/permission_manager.cc [modify] https://crrev.com/2ba0eea732beefe750d1de5700d86b3a92295061/chrome/browser/permissions/permission_request.h [modify] https://crrev.com/2ba0eea732beefe750d1de5700d86b3a92295061/chrome/browser/permissions/permission_request_impl.cc [modify] https://crrev.com/2ba0eea732beefe750d1de5700d86b3a92295061/chrome/browser/permissions/permission_util.cc [modify] https://crrev.com/2ba0eea732beefe750d1de5700d86b3a92295061/components/content_settings/core/browser/content_settings_registry.cc [modify] https://crrev.com/2ba0eea732beefe750d1de5700d86b3a92295061/components/content_settings/core/common/content_settings.cc [modify] https://crrev.com/2ba0eea732beefe750d1de5700d86b3a92295061/components/content_settings/core/common/content_settings_types.h [modify] https://crrev.com/2ba0eea732beefe750d1de5700d86b3a92295061/components/vector_icons/BUILD.gn [delete] https://crrev.com/e7365d23780af3a2fcf8845ff4d51a14620a7f74/components/vector_icons/accessibility.icon [modify] https://crrev.com/2ba0eea732beefe750d1de5700d86b3a92295061/content/browser/permissions/permission_service_impl.cc [modify] https://crrev.com/2ba0eea732beefe750d1de5700d86b3a92295061/content/public/browser/permission_type.h [modify] https://crrev.com/2ba0eea732beefe750d1de5700d86b3a92295061/content/shell/browser/layout_test/layout_test_message_filter.cc [modify] https://crrev.com/2ba0eea732beefe750d1de5700d86b3a92295061/third_party/WebKit/LayoutTests/accessibility/aom-actions.html [modify] https://crrev.com/2ba0eea732beefe750d1de5700d86b3a92295061/third_party/WebKit/LayoutTests/http/tests/resources/permissions-helper.js [modify] https://crrev.com/2ba0eea732beefe750d1de5700d86b3a92295061/third_party/WebKit/Source/core/dom/AXObjectCache.cpp [modify] https://crrev.com/2ba0eea732beefe750d1de5700d86b3a92295061/third_party/WebKit/Source/core/dom/AXObjectCache.h [modify] https://crrev.com/2ba0eea732beefe750d1de5700d86b3a92295061/third_party/WebKit/Source/core/dom/AXObjectCacheBase.cpp [modify] https://crrev.com/2ba0eea732beefe750d1de5700d86b3a92295061/third_party/WebKit/Source/core/dom/AXObjectCacheBase.h [modify] https://crrev.com/2ba0eea732beefe750d1de5700d86b3a92295061/third_party/WebKit/Source/modules/accessibility/AXObject.cpp [modify] https://crrev.com/2ba0eea732beefe750d1de5700d86b3a92295061/third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.cpp [modify] https://crrev.com/2ba0eea732beefe750d1de5700d86b3a92295061/third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.h [modify] https://crrev.com/2ba0eea732beefe750d1de5700d86b3a92295061/third_party/WebKit/Source/modules/accessibility/DEPS [modify] https://crrev.com/2ba0eea732beefe750d1de5700d86b3a92295061/third_party/WebKit/Source/modules/permissions/PermissionDescriptor.idl [modify] https://crrev.com/2ba0eea732beefe750d1de5700d86b3a92295061/third_party/WebKit/Source/modules/permissions/Permissions.cpp [modify] https://crrev.com/2ba0eea732beefe750d1de5700d86b3a92295061/third_party/WebKit/public/platform/WebFeaturePolicyFeature.h [modify] https://crrev.com/2ba0eea732beefe750d1de5700d86b3a92295061/third_party/WebKit/public/platform/modules/permissions/permission.mojom [modify] https://crrev.com/2ba0eea732beefe750d1de5700d86b3a92295061/tools/metrics/histograms/enums.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1e4c443153cc734035161e9999a8f8953497ad5e commit 1e4c443153cc734035161e9999a8f8953497ad5e Author: Hajime Hoshi <hajimehoshi@chromium.org> Date: Tue Aug 29 08:13:30 2017 Revert "Add new permission dialog for accessibility events." This reverts commit 72947e01e2f423f13183457047bb7c8d763e1893. Reason for revert: Crash in content::PermissionServiceContext::GetBrowserContext (crbug.com/759379) Original change's description: > Add new permission dialog for accessibility events. > > This is required as part of the Accessibility Object Model > phase 2 spec. > > Bug: 746524 > Change-Id: I5b63921663dee00e609ddfaf3aab5577229294c1 > Reviewed-on: https://chromium-review.googlesource.com/604830 > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Timothy Loh <timloh@chromium.org> > Reviewed-by: Evan Stade <estade@chromium.org> > Reviewed-by: Richard Coles <torne@chromium.org> > Reviewed-by: Mike West <mkwst@chromium.org> > Reviewed-by: Bernhard Bauer <bauerb@chromium.org> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Reviewed-by: Alice Boxhall <aboxhall@chromium.org> > Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> > Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#496801} TBR=aboxhall@chromium.org, bauerb@chromium.org, dcheng@chromium.org, dmazzoni@chromium.org, estade@chromium.org, haraken@chromium.org, jam@chromium.org, mkwst@chromium.org, mlamouri@chromium.org, msramek@chromium.org, raymes@chromium.org, timloh@chromium.org, torne@chromium.org (cherry picked from commit 2ba0eea732beefe750d1de5700d86b3a92295061) Bug: 746524 Change-Id: Ib5edc87c75f5d26cc8f8f5e5eef663ca859b7df3 Reviewed-on: https://chromium-review.googlesource.com/639970 Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#498006} Reviewed-on: https://chromium-review.googlesource.com/640395 Reviewed-by: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/branch-heads/3199@{#4} Cr-Branched-From: d5e0252247308646430a8ad488ffeb9005f1a653-refs/heads/master@{#497962} [modify] https://crrev.com/1e4c443153cc734035161e9999a8f8953497ad5e/android_webview/browser/aw_permission_manager.cc [delete] https://crrev.com/b274b9c13732623c481c542556bb5a4e1acbb96a/chrome/android/java/res/drawable-hdpi/infobar_accessibility_events.png [delete] https://crrev.com/b274b9c13732623c481c542556bb5a4e1acbb96a/chrome/android/java/res/drawable-mdpi/infobar_accessibility_events.png [delete] https://crrev.com/b274b9c13732623c481c542556bb5a4e1acbb96a/chrome/android/java/res/drawable-xhdpi/infobar_accessibility_events.png [delete] https://crrev.com/b274b9c13732623c481c542556bb5a4e1acbb96a/chrome/android/java/res/drawable-xxhdpi/infobar_accessibility_events.png [delete] https://crrev.com/b274b9c13732623c481c542556bb5a4e1acbb96a/chrome/android/java/res/drawable-xxxhdpi/infobar_accessibility_events.png [modify] https://crrev.com/1e4c443153cc734035161e9999a8f8953497ad5e/chrome/app/generated_resources.grd [modify] https://crrev.com/1e4c443153cc734035161e9999a8f8953497ad5e/chrome/browser/BUILD.gn [delete] https://crrev.com/b274b9c13732623c481c542556bb5a4e1acbb96a/chrome/browser/accessibility/accessibility_permission_context.cc [delete] https://crrev.com/b274b9c13732623c481c542556bb5a4e1acbb96a/chrome/browser/accessibility/accessibility_permission_context.h [modify] https://crrev.com/1e4c443153cc734035161e9999a8f8953497ad5e/chrome/browser/android/resource_id.h [modify] https://crrev.com/1e4c443153cc734035161e9999a8f8953497ad5e/chrome/browser/permissions/permission_manager.cc [modify] https://crrev.com/1e4c443153cc734035161e9999a8f8953497ad5e/chrome/browser/permissions/permission_request.h [modify] https://crrev.com/1e4c443153cc734035161e9999a8f8953497ad5e/chrome/browser/permissions/permission_request_impl.cc [modify] https://crrev.com/1e4c443153cc734035161e9999a8f8953497ad5e/chrome/browser/permissions/permission_util.cc [modify] https://crrev.com/1e4c443153cc734035161e9999a8f8953497ad5e/components/content_settings/core/browser/content_settings_registry.cc [modify] https://crrev.com/1e4c443153cc734035161e9999a8f8953497ad5e/components/content_settings/core/common/content_settings.cc [modify] https://crrev.com/1e4c443153cc734035161e9999a8f8953497ad5e/components/content_settings/core/common/content_settings_types.h [modify] https://crrev.com/1e4c443153cc734035161e9999a8f8953497ad5e/components/vector_icons/BUILD.gn [delete] https://crrev.com/b274b9c13732623c481c542556bb5a4e1acbb96a/components/vector_icons/accessibility.icon [modify] https://crrev.com/1e4c443153cc734035161e9999a8f8953497ad5e/content/browser/permissions/permission_service_impl.cc [modify] https://crrev.com/1e4c443153cc734035161e9999a8f8953497ad5e/content/public/browser/permission_type.h [modify] https://crrev.com/1e4c443153cc734035161e9999a8f8953497ad5e/content/shell/browser/layout_test/layout_test_message_filter.cc [modify] https://crrev.com/1e4c443153cc734035161e9999a8f8953497ad5e/third_party/WebKit/LayoutTests/accessibility/aom-actions.html [modify] https://crrev.com/1e4c443153cc734035161e9999a8f8953497ad5e/third_party/WebKit/LayoutTests/http/tests/resources/permissions-helper.js [modify] https://crrev.com/1e4c443153cc734035161e9999a8f8953497ad5e/third_party/WebKit/Source/core/dom/AXObjectCache.cpp [modify] https://crrev.com/1e4c443153cc734035161e9999a8f8953497ad5e/third_party/WebKit/Source/core/dom/AXObjectCache.h [modify] https://crrev.com/1e4c443153cc734035161e9999a8f8953497ad5e/third_party/WebKit/Source/core/dom/AXObjectCacheBase.cpp [modify] https://crrev.com/1e4c443153cc734035161e9999a8f8953497ad5e/third_party/WebKit/Source/core/dom/AXObjectCacheBase.h [modify] https://crrev.com/1e4c443153cc734035161e9999a8f8953497ad5e/third_party/WebKit/Source/modules/accessibility/AXObject.cpp [modify] https://crrev.com/1e4c443153cc734035161e9999a8f8953497ad5e/third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.cpp [modify] https://crrev.com/1e4c443153cc734035161e9999a8f8953497ad5e/third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.h [modify] https://crrev.com/1e4c443153cc734035161e9999a8f8953497ad5e/third_party/WebKit/Source/modules/accessibility/DEPS [modify] https://crrev.com/1e4c443153cc734035161e9999a8f8953497ad5e/third_party/WebKit/Source/modules/permissions/PermissionDescriptor.idl [modify] https://crrev.com/1e4c443153cc734035161e9999a8f8953497ad5e/third_party/WebKit/Source/modules/permissions/Permissions.cpp [modify] https://crrev.com/1e4c443153cc734035161e9999a8f8953497ad5e/third_party/WebKit/public/platform/WebFeaturePolicyFeature.h [modify] https://crrev.com/1e4c443153cc734035161e9999a8f8953497ad5e/third_party/WebKit/public/platform/modules/permissions/permission.mojom [modify] https://crrev.com/1e4c443153cc734035161e9999a8f8953497ad5e/tools/metrics/histograms/enums.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7b82a6d8665fe1b9cb1b1d096413ae532fa62da5 commit 7b82a6d8665fe1b9cb1b1d096413ae532fa62da5 Author: Dominic Mazzoni <dmazzoni@chromium.org> Date: Wed Aug 30 04:52:26 2017 Re-land: Add new permission dialog for accessibility events. This is required as part of the Accessibility Object Model phase 2 spec. Originally landed: r496801 Reverted: r498006 due to: * crbug.com/759379 - fixed by r498167 * crbug.com/758510 - fixed by patch set 2 (null check in AXObjectCacheImpl.cpp) Bug: 746524 ,759379, 758510 Change-Id: I6acf62366da7e6700dfa43e3c9cf10b4c6a966de Tbr: haraken,mlamouri Reviewed-on: https://chromium-review.googlesource.com/641983 Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#498367} [modify] https://crrev.com/7b82a6d8665fe1b9cb1b1d096413ae532fa62da5/android_webview/browser/aw_permission_manager.cc [add] https://crrev.com/7b82a6d8665fe1b9cb1b1d096413ae532fa62da5/chrome/android/java/res/drawable-hdpi/infobar_accessibility_events.png [add] https://crrev.com/7b82a6d8665fe1b9cb1b1d096413ae532fa62da5/chrome/android/java/res/drawable-mdpi/infobar_accessibility_events.png [add] https://crrev.com/7b82a6d8665fe1b9cb1b1d096413ae532fa62da5/chrome/android/java/res/drawable-xhdpi/infobar_accessibility_events.png [add] https://crrev.com/7b82a6d8665fe1b9cb1b1d096413ae532fa62da5/chrome/android/java/res/drawable-xxhdpi/infobar_accessibility_events.png [add] https://crrev.com/7b82a6d8665fe1b9cb1b1d096413ae532fa62da5/chrome/android/java/res/drawable-xxxhdpi/infobar_accessibility_events.png [modify] https://crrev.com/7b82a6d8665fe1b9cb1b1d096413ae532fa62da5/chrome/app/generated_resources.grd [modify] https://crrev.com/7b82a6d8665fe1b9cb1b1d096413ae532fa62da5/chrome/browser/BUILD.gn [add] https://crrev.com/7b82a6d8665fe1b9cb1b1d096413ae532fa62da5/chrome/browser/accessibility/accessibility_permission_context.cc [add] https://crrev.com/7b82a6d8665fe1b9cb1b1d096413ae532fa62da5/chrome/browser/accessibility/accessibility_permission_context.h [modify] https://crrev.com/7b82a6d8665fe1b9cb1b1d096413ae532fa62da5/chrome/browser/android/resource_id.h [modify] https://crrev.com/7b82a6d8665fe1b9cb1b1d096413ae532fa62da5/chrome/browser/permissions/permission_manager.cc [modify] https://crrev.com/7b82a6d8665fe1b9cb1b1d096413ae532fa62da5/chrome/browser/permissions/permission_request.h [modify] https://crrev.com/7b82a6d8665fe1b9cb1b1d096413ae532fa62da5/chrome/browser/permissions/permission_request_impl.cc [modify] https://crrev.com/7b82a6d8665fe1b9cb1b1d096413ae532fa62da5/chrome/browser/permissions/permission_util.cc [modify] https://crrev.com/7b82a6d8665fe1b9cb1b1d096413ae532fa62da5/components/content_settings/core/browser/content_settings_registry.cc [modify] https://crrev.com/7b82a6d8665fe1b9cb1b1d096413ae532fa62da5/components/content_settings/core/common/content_settings.cc [modify] https://crrev.com/7b82a6d8665fe1b9cb1b1d096413ae532fa62da5/components/content_settings/core/common/content_settings_types.h [modify] https://crrev.com/7b82a6d8665fe1b9cb1b1d096413ae532fa62da5/components/vector_icons/BUILD.gn [add] https://crrev.com/7b82a6d8665fe1b9cb1b1d096413ae532fa62da5/components/vector_icons/accessibility.icon [modify] https://crrev.com/7b82a6d8665fe1b9cb1b1d096413ae532fa62da5/content/browser/permissions/permission_service_impl.cc [modify] https://crrev.com/7b82a6d8665fe1b9cb1b1d096413ae532fa62da5/content/public/browser/permission_type.h [modify] https://crrev.com/7b82a6d8665fe1b9cb1b1d096413ae532fa62da5/content/shell/browser/layout_test/layout_test_message_filter.cc [modify] https://crrev.com/7b82a6d8665fe1b9cb1b1d096413ae532fa62da5/third_party/WebKit/LayoutTests/accessibility/aom-actions.html [modify] https://crrev.com/7b82a6d8665fe1b9cb1b1d096413ae532fa62da5/third_party/WebKit/LayoutTests/http/tests/resources/permissions-helper.js [modify] https://crrev.com/7b82a6d8665fe1b9cb1b1d096413ae532fa62da5/third_party/WebKit/Source/core/dom/AXObjectCache.cpp [modify] https://crrev.com/7b82a6d8665fe1b9cb1b1d096413ae532fa62da5/third_party/WebKit/Source/core/dom/AXObjectCache.h [modify] https://crrev.com/7b82a6d8665fe1b9cb1b1d096413ae532fa62da5/third_party/WebKit/Source/core/dom/AXObjectCacheBase.cpp [modify] https://crrev.com/7b82a6d8665fe1b9cb1b1d096413ae532fa62da5/third_party/WebKit/Source/core/dom/AXObjectCacheBase.h [modify] https://crrev.com/7b82a6d8665fe1b9cb1b1d096413ae532fa62da5/third_party/WebKit/Source/modules/accessibility/AXObject.cpp [modify] https://crrev.com/7b82a6d8665fe1b9cb1b1d096413ae532fa62da5/third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.cpp [modify] https://crrev.com/7b82a6d8665fe1b9cb1b1d096413ae532fa62da5/third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.h [modify] https://crrev.com/7b82a6d8665fe1b9cb1b1d096413ae532fa62da5/third_party/WebKit/Source/modules/accessibility/DEPS [modify] https://crrev.com/7b82a6d8665fe1b9cb1b1d096413ae532fa62da5/third_party/WebKit/Source/modules/permissions/PermissionDescriptor.idl [modify] https://crrev.com/7b82a6d8665fe1b9cb1b1d096413ae532fa62da5/third_party/WebKit/Source/modules/permissions/Permissions.cpp [modify] https://crrev.com/7b82a6d8665fe1b9cb1b1d096413ae532fa62da5/third_party/WebKit/public/platform/WebFeaturePolicyFeature.h [modify] https://crrev.com/7b82a6d8665fe1b9cb1b1d096413ae532fa62da5/third_party/WebKit/public/platform/modules/permissions/permission.mojom [modify] https://crrev.com/7b82a6d8665fe1b9cb1b1d096413ae532fa62da5/tools/metrics/histograms/enums.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b891faf65e13c6449d519f05a1e2d602ca4c3a46 commit b891faf65e13c6449d519f05a1e2d602ca4c3a46 Author: Dominic Mazzoni <dmazzoni@chromium.org> Date: Thu Aug 31 21:37:25 2017 Add more AOM Phase 2 event listeners. This change adds support for these new events: accessiblecontextmenu accessibledecrement accessiblefocus accessibleincrement accessiblescrollintoview The pattern for all of these is the same - when the action is triggered on an AXObject, we first try to fire an AOM event, and if that's not handled, we want to fall back on the default behavior. To make that more readable, this change renames all of the action interfaces in AXObject to each consist of a pair of methods - one public method to be triggered from the outside, and an internal method to handle the native fallback behavior. Bug: 746524 Change-Id: Idee1450de57bef57ebac53860a486c30b909a225 Reviewed-on: https://chromium-review.googlesource.com/634927 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by: Alice Boxhall <aboxhall@chromium.org> Reviewed-by: Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#499011} [modify] https://crrev.com/b891faf65e13c6449d519f05a1e2d602ca4c3a46/content/renderer/accessibility/render_accessibility_impl.cc [modify] https://crrev.com/b891faf65e13c6449d519f05a1e2d602ca4c3a46/content/shell/test_runner/web_ax_object_proxy.cc [modify] https://crrev.com/b891faf65e13c6449d519f05a1e2d602ca4c3a46/third_party/WebKit/LayoutTests/accessibility/aom-actions.html [modify] https://crrev.com/b891faf65e13c6449d519f05a1e2d602ca4c3a46/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt [modify] https://crrev.com/b891faf65e13c6449d519f05a1e2d602ca4c3a46/third_party/WebKit/Source/core/dom/AccessibleNode.h [modify] https://crrev.com/b891faf65e13c6449d519f05a1e2d602ca4c3a46/third_party/WebKit/Source/core/dom/AccessibleNode.idl [modify] https://crrev.com/b891faf65e13c6449d519f05a1e2d602ca4c3a46/third_party/WebKit/Source/core/events/EventTypeNames.json5 [modify] https://crrev.com/b891faf65e13c6449d519f05a1e2d602ca4c3a46/third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp [modify] https://crrev.com/b891faf65e13c6449d519f05a1e2d602ca4c3a46/third_party/WebKit/Source/modules/accessibility/AXLayoutObject.h [modify] https://crrev.com/b891faf65e13c6449d519f05a1e2d602ca4c3a46/third_party/WebKit/Source/modules/accessibility/AXListBoxOption.cpp [modify] https://crrev.com/b891faf65e13c6449d519f05a1e2d602ca4c3a46/third_party/WebKit/Source/modules/accessibility/AXListBoxOption.h [modify] https://crrev.com/b891faf65e13c6449d519f05a1e2d602ca4c3a46/third_party/WebKit/Source/modules/accessibility/AXMenuList.cpp [modify] https://crrev.com/b891faf65e13c6449d519f05a1e2d602ca4c3a46/third_party/WebKit/Source/modules/accessibility/AXMenuList.h [modify] https://crrev.com/b891faf65e13c6449d519f05a1e2d602ca4c3a46/third_party/WebKit/Source/modules/accessibility/AXMenuListOption.cpp [modify] https://crrev.com/b891faf65e13c6449d519f05a1e2d602ca4c3a46/third_party/WebKit/Source/modules/accessibility/AXMenuListOption.h [modify] https://crrev.com/b891faf65e13c6449d519f05a1e2d602ca4c3a46/third_party/WebKit/Source/modules/accessibility/AXMenuListPopup.cpp [modify] https://crrev.com/b891faf65e13c6449d519f05a1e2d602ca4c3a46/third_party/WebKit/Source/modules/accessibility/AXMenuListPopup.h [modify] https://crrev.com/b891faf65e13c6449d519f05a1e2d602ca4c3a46/third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp [modify] https://crrev.com/b891faf65e13c6449d519f05a1e2d602ca4c3a46/third_party/WebKit/Source/modules/accessibility/AXNodeObject.h [modify] https://crrev.com/b891faf65e13c6449d519f05a1e2d602ca4c3a46/third_party/WebKit/Source/modules/accessibility/AXObject.cpp [modify] https://crrev.com/b891faf65e13c6449d519f05a1e2d602ca4c3a46/third_party/WebKit/Source/modules/accessibility/AXObject.h [modify] https://crrev.com/b891faf65e13c6449d519f05a1e2d602ca4c3a46/third_party/WebKit/Source/modules/accessibility/AXSlider.cpp [modify] https://crrev.com/b891faf65e13c6449d519f05a1e2d602ca4c3a46/third_party/WebKit/Source/modules/accessibility/AXSlider.h [modify] https://crrev.com/b891faf65e13c6449d519f05a1e2d602ca4c3a46/third_party/WebKit/Source/modules/accessibility/AXSpinButton.cpp [modify] https://crrev.com/b891faf65e13c6449d519f05a1e2d602ca4c3a46/third_party/WebKit/Source/modules/accessibility/AXSpinButton.h [modify] https://crrev.com/b891faf65e13c6449d519f05a1e2d602ca4c3a46/third_party/WebKit/Source/modules/exported/WebAXObject.cpp [modify] https://crrev.com/b891faf65e13c6449d519f05a1e2d602ca4c3a46/third_party/WebKit/public/web/WebAXObject.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e8ad250fef3341f87b1321e1a463c8c905bcc48f commit e8ad250fef3341f87b1321e1a463c8c905bcc48f Author: Greg Thompson <grt@chromium.org> Date: Fri Sep 01 11:22:18 2017 Revert "Add more AOM Phase 2 event listeners." This reverts commit b891faf65e13c6449d519f05a1e2d602ca4c3a46. Reason for revert: accessibility/aom-actions.html failing on WebKit Win builders; for example: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win10/builds/25073. Original change's description: > Add more AOM Phase 2 event listeners. > > This change adds support for these new events: > accessiblecontextmenu > accessibledecrement > accessiblefocus > accessibleincrement > accessiblescrollintoview > > The pattern for all of these is the same - when the > action is triggered on an AXObject, we first try to fire > an AOM event, and if that's not handled, we want to fall > back on the default behavior. > > To make that more readable, this change renames all of > the action interfaces in AXObject to each consist of a > pair of methods - one public method to be triggered from > the outside, and an internal method to handle the > native fallback behavior. > > Bug: 746524 > Change-Id: Idee1450de57bef57ebac53860a486c30b909a225 > Reviewed-on: https://chromium-review.googlesource.com/634927 > Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> > Reviewed-by: Alice Boxhall <aboxhall@chromium.org> > Reviewed-by: Mike West <mkwst@chromium.org> > Cr-Commit-Position: refs/heads/master@{#499011} TBR=dmazzoni@chromium.org,aboxhall@chromium.org,mkwst@chromium.org Change-Id: Iaff901cb203a7a413371d9144de2695cd2214a7b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 746524 Reviewed-on: https://chromium-review.googlesource.com/647546 Reviewed-by: Greg Thompson <grt@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#499164} [modify] https://crrev.com/e8ad250fef3341f87b1321e1a463c8c905bcc48f/content/renderer/accessibility/render_accessibility_impl.cc [modify] https://crrev.com/e8ad250fef3341f87b1321e1a463c8c905bcc48f/content/shell/test_runner/web_ax_object_proxy.cc [modify] https://crrev.com/e8ad250fef3341f87b1321e1a463c8c905bcc48f/third_party/WebKit/LayoutTests/accessibility/aom-actions.html [modify] https://crrev.com/e8ad250fef3341f87b1321e1a463c8c905bcc48f/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt [modify] https://crrev.com/e8ad250fef3341f87b1321e1a463c8c905bcc48f/third_party/WebKit/Source/core/dom/AccessibleNode.h [modify] https://crrev.com/e8ad250fef3341f87b1321e1a463c8c905bcc48f/third_party/WebKit/Source/core/dom/AccessibleNode.idl [modify] https://crrev.com/e8ad250fef3341f87b1321e1a463c8c905bcc48f/third_party/WebKit/Source/core/events/EventTypeNames.json5 [modify] https://crrev.com/e8ad250fef3341f87b1321e1a463c8c905bcc48f/third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp [modify] https://crrev.com/e8ad250fef3341f87b1321e1a463c8c905bcc48f/third_party/WebKit/Source/modules/accessibility/AXLayoutObject.h [modify] https://crrev.com/e8ad250fef3341f87b1321e1a463c8c905bcc48f/third_party/WebKit/Source/modules/accessibility/AXListBoxOption.cpp [modify] https://crrev.com/e8ad250fef3341f87b1321e1a463c8c905bcc48f/third_party/WebKit/Source/modules/accessibility/AXListBoxOption.h [modify] https://crrev.com/e8ad250fef3341f87b1321e1a463c8c905bcc48f/third_party/WebKit/Source/modules/accessibility/AXMenuList.cpp [modify] https://crrev.com/e8ad250fef3341f87b1321e1a463c8c905bcc48f/third_party/WebKit/Source/modules/accessibility/AXMenuList.h [modify] https://crrev.com/e8ad250fef3341f87b1321e1a463c8c905bcc48f/third_party/WebKit/Source/modules/accessibility/AXMenuListOption.cpp [modify] https://crrev.com/e8ad250fef3341f87b1321e1a463c8c905bcc48f/third_party/WebKit/Source/modules/accessibility/AXMenuListOption.h [modify] https://crrev.com/e8ad250fef3341f87b1321e1a463c8c905bcc48f/third_party/WebKit/Source/modules/accessibility/AXMenuListPopup.cpp [modify] https://crrev.com/e8ad250fef3341f87b1321e1a463c8c905bcc48f/third_party/WebKit/Source/modules/accessibility/AXMenuListPopup.h [modify] https://crrev.com/e8ad250fef3341f87b1321e1a463c8c905bcc48f/third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp [modify] https://crrev.com/e8ad250fef3341f87b1321e1a463c8c905bcc48f/third_party/WebKit/Source/modules/accessibility/AXNodeObject.h [modify] https://crrev.com/e8ad250fef3341f87b1321e1a463c8c905bcc48f/third_party/WebKit/Source/modules/accessibility/AXObject.cpp [modify] https://crrev.com/e8ad250fef3341f87b1321e1a463c8c905bcc48f/third_party/WebKit/Source/modules/accessibility/AXObject.h [modify] https://crrev.com/e8ad250fef3341f87b1321e1a463c8c905bcc48f/third_party/WebKit/Source/modules/accessibility/AXSlider.cpp [modify] https://crrev.com/e8ad250fef3341f87b1321e1a463c8c905bcc48f/third_party/WebKit/Source/modules/accessibility/AXSlider.h [modify] https://crrev.com/e8ad250fef3341f87b1321e1a463c8c905bcc48f/third_party/WebKit/Source/modules/accessibility/AXSpinButton.cpp [modify] https://crrev.com/e8ad250fef3341f87b1321e1a463c8c905bcc48f/third_party/WebKit/Source/modules/accessibility/AXSpinButton.h [modify] https://crrev.com/e8ad250fef3341f87b1321e1a463c8c905bcc48f/third_party/WebKit/Source/modules/exported/WebAXObject.cpp [modify] https://crrev.com/e8ad250fef3341f87b1321e1a463c8c905bcc48f/third_party/WebKit/public/web/WebAXObject.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2b781f033b8d428dbe5d3d36455977fcdc9928da commit 2b781f033b8d428dbe5d3d36455977fcdc9928da Author: Dominic Mazzoni <dmazzoni@chromium.org> Date: Mon Sep 04 07:54:52 2017 Re-land: Add more AOM Phase 2 event listeners. Originally landed: r499011 Reverted: 499164 The issue was just a layout test timing out on Windows. The fix is to split it into more files with fewer individual tests per file. This change adds support for these new events: accessiblecontextmenu accessibledecrement accessiblefocus accessibleincrement accessiblescrollintoview The pattern for all of these is the same - when the action is triggered on an AXObject, we first try to fire an AOM event, and if that's not handled, we want to fall back on the default behavior. To make that more readable, this change renames all of the action interfaces in AXObject to each consist of a pair of methods - one public method to be triggered from the outside, and an internal method to handle the native fallback behavior. Bug: 746524 Change-Id: Icbe20c83898dd588c23b81ddcf17276a203369ea TBR: aboxhall@chromium.org Reviewed-on: https://chromium-review.googlesource.com/648360 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#499452} [modify] https://crrev.com/2b781f033b8d428dbe5d3d36455977fcdc9928da/content/renderer/accessibility/render_accessibility_impl.cc [modify] https://crrev.com/2b781f033b8d428dbe5d3d36455977fcdc9928da/content/shell/test_runner/web_ax_object_proxy.cc [rename] https://crrev.com/2b781f033b8d428dbe5d3d36455977fcdc9928da/third_party/WebKit/LayoutTests/accessibility/aom-click-action.html [add] https://crrev.com/2b781f033b8d428dbe5d3d36455977fcdc9928da/third_party/WebKit/LayoutTests/accessibility/aom-contextmenu-action.html [add] https://crrev.com/2b781f033b8d428dbe5d3d36455977fcdc9928da/third_party/WebKit/LayoutTests/accessibility/aom-decrement-action.html [add] https://crrev.com/2b781f033b8d428dbe5d3d36455977fcdc9928da/third_party/WebKit/LayoutTests/accessibility/aom-focus-action.html [add] https://crrev.com/2b781f033b8d428dbe5d3d36455977fcdc9928da/third_party/WebKit/LayoutTests/accessibility/aom-increment-action.html [add] https://crrev.com/2b781f033b8d428dbe5d3d36455977fcdc9928da/third_party/WebKit/LayoutTests/accessibility/aom-scroll-action.html [add] https://crrev.com/2b781f033b8d428dbe5d3d36455977fcdc9928da/third_party/WebKit/LayoutTests/accessibility/resources/aom-helper.js [modify] https://crrev.com/2b781f033b8d428dbe5d3d36455977fcdc9928da/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt [modify] https://crrev.com/2b781f033b8d428dbe5d3d36455977fcdc9928da/third_party/WebKit/Source/core/dom/AccessibleNode.h [modify] https://crrev.com/2b781f033b8d428dbe5d3d36455977fcdc9928da/third_party/WebKit/Source/core/dom/AccessibleNode.idl [modify] https://crrev.com/2b781f033b8d428dbe5d3d36455977fcdc9928da/third_party/WebKit/Source/core/events/EventTypeNames.json5 [modify] https://crrev.com/2b781f033b8d428dbe5d3d36455977fcdc9928da/third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp [modify] https://crrev.com/2b781f033b8d428dbe5d3d36455977fcdc9928da/third_party/WebKit/Source/modules/accessibility/AXLayoutObject.h [modify] https://crrev.com/2b781f033b8d428dbe5d3d36455977fcdc9928da/third_party/WebKit/Source/modules/accessibility/AXListBoxOption.cpp [modify] https://crrev.com/2b781f033b8d428dbe5d3d36455977fcdc9928da/third_party/WebKit/Source/modules/accessibility/AXListBoxOption.h [modify] https://crrev.com/2b781f033b8d428dbe5d3d36455977fcdc9928da/third_party/WebKit/Source/modules/accessibility/AXMenuList.cpp [modify] https://crrev.com/2b781f033b8d428dbe5d3d36455977fcdc9928da/third_party/WebKit/Source/modules/accessibility/AXMenuList.h [modify] https://crrev.com/2b781f033b8d428dbe5d3d36455977fcdc9928da/third_party/WebKit/Source/modules/accessibility/AXMenuListOption.cpp [modify] https://crrev.com/2b781f033b8d428dbe5d3d36455977fcdc9928da/third_party/WebKit/Source/modules/accessibility/AXMenuListOption.h [modify] https://crrev.com/2b781f033b8d428dbe5d3d36455977fcdc9928da/third_party/WebKit/Source/modules/accessibility/AXMenuListPopup.cpp [modify] https://crrev.com/2b781f033b8d428dbe5d3d36455977fcdc9928da/third_party/WebKit/Source/modules/accessibility/AXMenuListPopup.h [modify] https://crrev.com/2b781f033b8d428dbe5d3d36455977fcdc9928da/third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp [modify] https://crrev.com/2b781f033b8d428dbe5d3d36455977fcdc9928da/third_party/WebKit/Source/modules/accessibility/AXNodeObject.h [modify] https://crrev.com/2b781f033b8d428dbe5d3d36455977fcdc9928da/third_party/WebKit/Source/modules/accessibility/AXObject.cpp [modify] https://crrev.com/2b781f033b8d428dbe5d3d36455977fcdc9928da/third_party/WebKit/Source/modules/accessibility/AXObject.h [modify] https://crrev.com/2b781f033b8d428dbe5d3d36455977fcdc9928da/third_party/WebKit/Source/modules/accessibility/AXSlider.cpp [modify] https://crrev.com/2b781f033b8d428dbe5d3d36455977fcdc9928da/third_party/WebKit/Source/modules/accessibility/AXSlider.h [modify] https://crrev.com/2b781f033b8d428dbe5d3d36455977fcdc9928da/third_party/WebKit/Source/modules/accessibility/AXSpinButton.cpp [modify] https://crrev.com/2b781f033b8d428dbe5d3d36455977fcdc9928da/third_party/WebKit/Source/modules/accessibility/AXSpinButton.h [modify] https://crrev.com/2b781f033b8d428dbe5d3d36455977fcdc9928da/third_party/WebKit/Source/modules/exported/WebAXObject.cpp [modify] https://crrev.com/2b781f033b8d428dbe5d3d36455977fcdc9928da/third_party/WebKit/public/web/WebAXObject.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a80dc5672ba693c449b86b156597c2c873e7ecde commit a80dc5672ba693c449b86b156597c2c873e7ecde Author: Dominic Mazzoni <dmazzoni@chromium.org> Date: Thu Sep 21 03:54:50 2017 AOM should not prompt for permission if no event listener. With the current logic, a web page asks for permission if there are any AccessibleNodes on the event path for a node that receives any Accessibility event, including something like focus. That's too aggressive - we should only request permission if one of those nodes has an event listener attached to it, too. Tested manually with: https://minorninth.github.io/aom/demos/index.html - before this patch, it prompts for permission early on. With this patch, it prompts for permission only when you click the button on the "Phase 2 demo: Feature detection" slide. Bug: 746524 Change-Id: I910b85b29b7f58cf30fce796097e797c106b4cf3 Reviewed-on: https://chromium-review.googlesource.com/674104 Reviewed-by: Alice Boxhall <aboxhall@chromium.org> Commit-Queue: Alice Boxhall <aboxhall@chromium.org> Cr-Commit-Position: refs/heads/master@{#503347} [modify] https://crrev.com/a80dc5672ba693c449b86b156597c2c873e7ecde/third_party/WebKit/Source/modules/accessibility/AXObject.cpp
Abandoning for now because spec is changing
Comment 1 by dmazz...@chromium.org
, Jul 19 2017