New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 746521 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Stack script doesn't work properly with --arch=arm64

Project Member Reported by ctzsm@chromium.org, Jul 19 2017

Issue description

While debugging a crash on android_webview_unittests, stack didn't symbolize crash log correctly.

Example CQ trybot: https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/222960

The reason is stack_core.py is using symbol.ARCH before it is properly set, so regex matchers are still matching lines with width 8. But it should be set to 16 if we pass --arch=arm64.

 

Comment 1 by ctzsm@chromium.org, Jul 19 2017

Description: Show this description
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0820394aa1294d6461c76fbd64cf7f0b07f72172

commit 0820394aa1294d6461c76fbd64cf7f0b07f72172
Author: Shimi Zhang <ctzsm@chromium.org>
Date: Wed Jul 19 21:59:31 2017

[Android] Delay _WIDTH related line matchers init

Use symbol.ARCH after we properly set it in stack_core.py.

Bug:  746521 
Change-Id: Ie3c44ea6b315b5a7ec3977655f135bfb2c0b0d6d
Reviewed-on: https://chromium-review.googlesource.com/578238
Reviewed-by: Selim Gurun <sgurun@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Shimi Zhang <ctzsm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488006}
[modify] https://crrev.com/0820394aa1294d6461c76fbd64cf7f0b07f72172/third_party/android_platform/development/scripts/stack_core.py

Comment 3 by ctzsm@chromium.org, Jul 19 2017

Status: Fixed (was: Assigned)

Sign in to add a comment