New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 746514 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Feb 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

CL status viewer

Project Member Reported by nxia@chromium.org, Jul 19 2017

Issue description

Comment 1 by nxia@chromium.org, Jul 19 2017

Components: Infra>Client>ChromeOS
I first tried to setup an app_engine standard env app and import the chromite lib. It turned out the importing third-party libraries and setting up virtualenv could be messy in standard evn. Then I tried the flexible env, which is good for flexible vendor setup but not good for easy scaling, importing chromite works smoothly so far. Flexible env will make maintaining for chromite easier than the standard evn and offers more flexible env setup (like virtualenv), so proceeding with flexible env is the plan.
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/dd9052b1b379210a726cd978b0bbe059bbe52132

commit dd9052b1b379210a726cd978b0bbe059bbe52132
Author: Ningning Xia <nxia@chromium.org>
Date: Thu Aug 24 02:04:20 2017

cidb: add CIDB connection for Google App Engine

Support CIDB connection creation for Google App Engine

BUG= chromium:746514 
TEST=unit_tests

Change-Id: Ia23babe7e398b0a5750bd91e8a4492c01edf590f
Reviewed-on: https://chromium-review.googlesource.com/609591
Commit-Ready: Ningning Xia <nxia@chromium.org>
Tested-by: Ningning Xia <nxia@chromium.org>
Reviewed-by: Paul Hobbs <phobbs@google.com>

[modify] https://crrev.com/dd9052b1b379210a726cd978b0bbe059bbe52132/lib/cidb_unittest.py
[modify] https://crrev.com/dd9052b1b379210a726cd978b0bbe059bbe52132/lib/cidb.py

Project Member

Comment 3 by bugdroid1@chromium.org, Sep 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/bcb099a972e68dacee1499da338a8fa9bbc7beaf

commit bcb099a972e68dacee1499da338a8fa9bbc7beaf
Author: Ningning Xia <nxia@chromium.org>
Date: Tue Sep 12 11:19:32 2017

Refactor Buildbucket for GAE Apps.

BUG= chromium:746514 
TEST=unit_tests

Change-Id: I061a943a21b99fdd174ed4d3f3136fc07d34b4a3
Reviewed-on: https://chromium-review.googlesource.com/630356
Commit-Ready: Ningning Xia <nxia@chromium.org>
Tested-by: Ningning Xia <nxia@chromium.org>
Reviewed-by: Ningning Xia <nxia@chromium.org>

[modify] https://crrev.com/bcb099a972e68dacee1499da338a8fa9bbc7beaf/cbuildbot/remote_try.py
[modify] https://crrev.com/bcb099a972e68dacee1499da338a8fa9bbc7beaf/lib/buildbucket_lib.py
[modify] https://crrev.com/bcb099a972e68dacee1499da338a8fa9bbc7beaf/cbuildbot/remote_try_unittest.py
[modify] https://crrev.com/bcb099a972e68dacee1499da338a8fa9bbc7beaf/cbuildbot/stages/generic_stages.py
[modify] https://crrev.com/bcb099a972e68dacee1499da338a8fa9bbc7beaf/lib/auth.py
[modify] https://crrev.com/bcb099a972e68dacee1499da338a8fa9bbc7beaf/lib/builder_status_lib_unittest.py
[modify] https://crrev.com/bcb099a972e68dacee1499da338a8fa9bbc7beaf/lib/prpc.py
[modify] https://crrev.com/bcb099a972e68dacee1499da338a8fa9bbc7beaf/lib/som.py
[modify] https://crrev.com/bcb099a972e68dacee1499da338a8fa9bbc7beaf/lib/auth_unittest.py
[modify] https://crrev.com/bcb099a972e68dacee1499da338a8fa9bbc7beaf/lib/buildbucket_lib_unittest.py

Project Member

Comment 4 by bugdroid1@chromium.org, Sep 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/infra/cl_status_viewer/+/8db2b39d37f1c646d04ec8b93459c7d556fbf09c

commit 8db2b39d37f1c646d04ec8b93459c7d556fbf09c
Author: Ningning Xia <nxia@google.com>
Date: Thu Sep 14 20:27:14 2017

Add PRESUBMIT config.

BUG= chromium:746514 
TEST=None

Change-Id: Iccf0e1f3e60a2adf8997fff0fcb760f442f7b095

[add] https://crrev.com/8db2b39d37f1c646d04ec8b93459c7d556fbf09c/PRESUBMIT.cfg

Project Member

Comment 5 by bugdroid1@chromium.org, Sep 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/05550482e55716a1c86ae57ef07d71a594e7a7e6

commit 05550482e55716a1c86ae57ef07d71a594e7a7e6
Author: Ningning Xia <nxia@chromium.org>
Date: Fri Sep 29 20:05:13 2017

cidb: Add extra request_reasons to buildRequestTable.

Previously, the requested CQ slaves and their buildbucket_ids were only
stored in in-memeory metadata and uploaded to GS. The project
CrOs-CL-Status-Viewer needs to access the CQ master in history and its
scheduled CQ slaves. Plan to store the information in the
buildRequestTable so CL-Status-Viewer can know the scheduled slaves and
their buildbucket_ids even the scheduled slaves never started or failed
before the BuildStart stage (which inserts the build tuple into the
buildTable).

BUG= chromium:746514 
TEST=cidb_integration_test

Change-Id: I62e2003b1caf616b9e9997faeecdedd77f27e171
Reviewed-on: https://chromium-review.googlesource.com/688496
Reviewed-by: Paul Hobbs <phobbs@google.com>
Tested-by: Ningning Xia <nxia@chromium.org>

[modify] https://crrev.com/05550482e55716a1c86ae57ef07d71a594e7a7e6/cidb/schema.dump
[add] https://crrev.com/05550482e55716a1c86ae57ef07d71a594e7a7e6/cidb/migrations/00060_alter_buildRequest_table_add_request_reasons.sql

Project Member

Comment 6 by bugdroid1@chromium.org, Oct 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/b5e3cf78fad38196a8b777639dc9cbe0953c34d9

commit b5e3cf78fad38196a8b777639dc9cbe0953c34d9
Author: Ningning Xia <nxia@chromium.org>
Date: Mon Oct 23 22:35:05 2017

cidb: Fix buildRequestTable build_request_reason typo.

BUG= chromium:746514 
TEST=cidb_integration_test

Change-Id: I8d2e3517c01489b2994f17c6a7a3d51029901b45
Reviewed-on: https://chromium-review.googlesource.com/720238
Reviewed-by: Aviv Keshet <akeshet@chromium.org>
Tested-by: Ningning Xia <nxia@chromium.org>

[modify] https://crrev.com/b5e3cf78fad38196a8b777639dc9cbe0953c34d9/cidb/schema.dump
[add] https://crrev.com/b5e3cf78fad38196a8b777639dc9cbe0953c34d9/cidb/migrations/00061_alter_buildRequest_table_fix_request_reasons.sql

Project Member

Comment 7 by bugdroid1@chromium.org, Oct 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/f1355bdde7e782dd2511eff4c40a6628e5530297

commit f1355bdde7e782dd2511eff4c40a6628e5530297
Author: Ningning Xia <nxia@chromium.org>
Date: Tue Oct 24 05:39:00 2017

clactions: include buildbucket_id in GetCLPreCQProgress return value.

1) clactions: Cros_CL_Status_Viewer will use GetCLPreCQProgress to get
the Pre-CQ progress of a CL. Pre-CQ-Launcher records scheduled Pre-CQ
buildbucket_ids in the "trybot_launching" cl action. Return the
scheduled Pre-CQ buildbucket_ids in GetCLPreCQProgress so that
CL_Status_Viewer can get the buildbucket_ids of scheduled but not
started Pre-CQs.

2) buildbucket_lib: add GetBuildStartedTS and GetBuildCompletedTS,
which will be called by CL-Status-Viewer.

BUG= chromium:746514 
TEST=unit_tests

Change-Id: Id4db9a9a4b4515ec42adf9544ecf4fb25194a39e
Reviewed-on: https://chromium-review.googlesource.com/688494
Commit-Ready: Ningning Xia <nxia@chromium.org>
Tested-by: Ningning Xia <nxia@chromium.org>
Reviewed-by: Ningning Xia <nxia@chromium.org>

[modify] https://crrev.com/f1355bdde7e782dd2511eff4c40a6628e5530297/lib/buildbucket_lib.py
[modify] https://crrev.com/f1355bdde7e782dd2511eff4c40a6628e5530297/cbuildbot/stages/sync_stages_unittest.py
[modify] https://crrev.com/f1355bdde7e782dd2511eff4c40a6628e5530297/cbuildbot/stages/sync_stages.py
[modify] https://crrev.com/f1355bdde7e782dd2511eff4c40a6628e5530297/lib/clactions.py

Project Member

Comment 8 by bugdroid1@chromium.org, Oct 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/00a4b1f32778d59f6ba5706ce276bffd33f27946

commit 00a4b1f32778d59f6ba5706ce276bffd33f27946
Author: Ningning Xia <nxia@chromium.org>
Date: Tue Oct 24 05:38:59 2017

Insert scheduled CQ slaves into buildRequestTable.

1) cidb:change InsertBuildRequest to InsertBuildRequests to reduce the
load on CIDB when inserting build_request groups.

2) scheduler_stages: Insert scheduled (important + experimental) CQ
slaves into buildRequestTable in scheduler_stages, so that the other
services (not only the CQ master which schedules the slaves) can
also access the information

3) sync_stages: change Pre-CQ-Launcher to use InsertBuildRequests.

4) Add unit tests.

BUG= chromium:746514 
TEST=run_tests; cidb_integration_test

Change-Id: Ibf5813ba43ff5d7d9c0b7a16b17f1840b8b14295
Reviewed-on: https://chromium-review.googlesource.com/689744
Commit-Ready: Ningning Xia <nxia@chromium.org>
Tested-by: Ningning Xia <nxia@chromium.org>
Reviewed-by: Ningning Xia <nxia@chromium.org>

[modify] https://crrev.com/00a4b1f32778d59f6ba5706ce276bffd33f27946/lib/build_requests.py
[modify] https://crrev.com/00a4b1f32778d59f6ba5706ce276bffd33f27946/lib/cidb.py
[modify] https://crrev.com/00a4b1f32778d59f6ba5706ce276bffd33f27946/cbuildbot/stages/scheduler_stages.py
[modify] https://crrev.com/00a4b1f32778d59f6ba5706ce276bffd33f27946/cbuildbot/stages/scheduler_stages_unittest.py
[modify] https://crrev.com/00a4b1f32778d59f6ba5706ce276bffd33f27946/cbuildbot/stages/sync_stages_unittest.py
[modify] https://crrev.com/00a4b1f32778d59f6ba5706ce276bffd33f27946/lib/fake_cidb.py
[modify] https://crrev.com/00a4b1f32778d59f6ba5706ce276bffd33f27946/cbuildbot/stages/sync_stages.py
[modify] https://crrev.com/00a4b1f32778d59f6ba5706ce276bffd33f27946/lib/cidb_integration_test.py

Project Member

Comment 9 by bugdroid1@chromium.org, Oct 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/b8ae5eb80b5f160b3707166699825eb9f2154a8e

commit b8ae5eb80b5f160b3707166699825eb9f2154a8e
Author: Ningning Xia <nxia@chromium.org>
Date: Tue Oct 24 05:39:00 2017

Insert build_requests for retried builds.

For every retried build, insert a corresponding build_request into the
buildRequestTable.

BUG= chromium:746514 
TEST=unit_tests

Change-Id: I3d44dc4fc4d91ab850a5b9c932d5863ba94bc00b
Reviewed-on: https://chromium-review.googlesource.com/713636
Commit-Ready: Ningning Xia <nxia@chromium.org>
Tested-by: Ningning Xia <nxia@chromium.org>
Reviewed-by: Don Garrett <dgarrett@chromium.org>

[modify] https://crrev.com/b8ae5eb80b5f160b3707166699825eb9f2154a8e/cbuildbot/build_status_unittest.py
[modify] https://crrev.com/b8ae5eb80b5f160b3707166699825eb9f2154a8e/cbuildbot/build_status.py

Project Member

Comment 10 by bugdroid1@chromium.org, Nov 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/b133e1ea772030863f3e51f8836eb49931267e15

commit b133e1ea772030863f3e51f8836eb49931267e15
Author: Ningning Xia <nxia@chromium.org>
Date: Wed Nov 08 23:10:23 2017

chromite changes for Cros_CL_Status_Viewer

1) cidb.GetBuildStatus should return the build_type of a build.
CQs/Pre-CQs can be deleted from chromeos_configs, so
Cros_CL_Status_Viewer won't be able to know the build_type of the builds
it collects for a CL if the build configs have been removed;
2) buildbucket request should also include the build_type in the tag.
also add GetBuildTags API in buildbucket_lib.
3) add GetBuildRequestsForRequesterBuild so that Cros_CL_Status_Viewer
can know the scheduled slaves (including the slaves failed to start
Cbuildbot) given a master build id.

BUG= chromium:746514 
TEST=unit_tests

Change-Id: I56b4ab61be0dc1d1406935104f14615809f9cc31
Reviewed-on: https://chromium-review.googlesource.com/754292
Commit-Ready: Paul Hobbs <phobbs@google.com>
Tested-by: Ningning Xia <nxia@chromium.org>
Reviewed-by: Ningning Xia <nxia@chromium.org>

[modify] https://crrev.com/b133e1ea772030863f3e51f8836eb49931267e15/lib/remote_try_unittest.py
[modify] https://crrev.com/b133e1ea772030863f3e51f8836eb49931267e15/lib/cidb.py
[modify] https://crrev.com/b133e1ea772030863f3e51f8836eb49931267e15/lib/buildbucket_lib.py
[modify] https://crrev.com/b133e1ea772030863f3e51f8836eb49931267e15/lib/fake_cidb.py
[modify] https://crrev.com/b133e1ea772030863f3e51f8836eb49931267e15/lib/remote_try.py
[modify] https://crrev.com/b133e1ea772030863f3e51f8836eb49931267e15/lib/buildbucket_lib_unittest.py
[modify] https://crrev.com/b133e1ea772030863f3e51f8836eb49931267e15/lib/cidb_integration_test.py

Project Member

Comment 11 by bugdroid1@chromium.org, Nov 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/infra/cl_status_viewer/+/9b84fb4facbeac59617987088f7c138656d298b3

commit 9b84fb4facbeac59617987088f7c138656d298b3
Author: Ningning Xia <nxia@google.com>
Date: Wed Nov 15 22:28:16 2017

Add protobuf for request and response handler.

BUG= chromium:746514 
TEST=None

Change-Id: Ia110d419d16fcea770af05bf391582412720843b

[add] https://crrev.com/9b84fb4facbeac59617987088f7c138656d298b3/common/protos/viewer_message.proto

Project Member

Comment 12 by bugdroid1@chromium.org, Nov 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/infra/cl_status_viewer/+/66fb49bf5f0e6d141913bfc5167f4c4651bc8a0d

commit 66fb49bf5f0e6d141913bfc5167f4c4651bc8a0d
Author: Ningning Xia <nxia@google.com>
Date: Thu Nov 16 18:42:57 2017

cl_status_server: Get status and build information for a CL.

CLStatusServer gets and computes status and relevant Pre-CQ & CQ
builds given a CL (gerrit_host + change_number + patch_number).

CLStatusServer gets CL status by analyzing CLActions from CIDB.
CLStatusServer gets build information from CIDB if the build has
already started and reported status to CIDB, and gets build information
from Buildbucket if the build has been scheduled but hasn't reported
information back to CIDB.

BUG= chromium:746514 
TEST=unit_tests

Change-Id: If954c4c8401281b3ff7177c8f8c4703c112e69f8

[add] https://crrev.com/66fb49bf5f0e6d141913bfc5167f4c4651bc8a0d/cl_status_server_unittest.py
[add] https://crrev.com/66fb49bf5f0e6d141913bfc5167f4c4651bc8a0d/common/__init__.py
[add] https://crrev.com/66fb49bf5f0e6d141913bfc5167f4c4651bc8a0d/common/protos/__init__.py
[add] https://crrev.com/66fb49bf5f0e6d141913bfc5167f4c4651bc8a0d/requirements.txt
[add] https://crrev.com/66fb49bf5f0e6d141913bfc5167f4c4651bc8a0d/__init__.py
[add] https://crrev.com/66fb49bf5f0e6d141913bfc5167f4c4651bc8a0d/cl_status_server.py
[add] https://crrev.com/66fb49bf5f0e6d141913bfc5167f4c4651bc8a0d/chromite

Project Member

Comment 13 by bugdroid1@chromium.org, Nov 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/ed1bceca1dea6a9231e3097358a6c62bd87f5e01

commit ed1bceca1dea6a9231e3097358a6c62bd87f5e01
Author: Ningning Xia <nxia@chromium.org>
Date: Tue Nov 21 23:58:39 2017

Handle sys.path for GAE projects with imported chromite.

Flexible GAE projects will be run inside their own virtual environment,
when they import chromite, the chromite third party libraries should not
override the libraries installed by the GAE project virtualenv. So when
the chromite is runside a virtual environment, insert the third_party
libraries after the libraries installed by the virtualenv.

BUG= chromium:746514 
TEST=None

Change-Id: Ifd979524005597f64a43af48c5286d8a2deb95bd
Reviewed-on: https://chromium-review.googlesource.com/777406
Commit-Ready: Ningning Xia <nxia@chromium.org>
Tested-by: Ningning Xia <nxia@chromium.org>
Reviewed-by: Ningning Xia <nxia@chromium.org>

[modify] https://crrev.com/ed1bceca1dea6a9231e3097358a6c62bd87f5e01/__init__.py

Project Member

Comment 14 by bugdroid1@chromium.org, Nov 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/infra/cl_status_viewer/+/24a408a54aab466bfd215eebccca317fb1ae6d5a

commit 24a408a54aab466bfd215eebccca317fb1ae6d5a
Author: Ningning Xia <nxia@google.com>
Date: Tue Nov 21 23:37:38 2017

Add endpoints and app yaml files and main.py

openapi-appengine.yaml defines the endpoints configs and APIs.
app.yaml defines the app configs and environment virables.
main.py serves the endpoints APIs.

BUG= chromium:746514 
TEST=deployed & tested

Change-Id: I27affabd7700bbb20a42254b86013932251e74a9

[modify] https://crrev.com/24a408a54aab466bfd215eebccca317fb1ae6d5a/cl_status_server.py
[modify] https://crrev.com/24a408a54aab466bfd215eebccca317fb1ae6d5a/requirements.txt
[add] https://crrev.com/24a408a54aab466bfd215eebccca317fb1ae6d5a/v1.py
[add] https://crrev.com/24a408a54aab466bfd215eebccca317fb1ae6d5a/main.py
[add] https://crrev.com/24a408a54aab466bfd215eebccca317fb1ae6d5a/openapi-appengine.yaml

Project Member

Comment 15 by bugdroid1@chromium.org, Nov 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/infra/cl_status_viewer/+/58d78a900e6e1b69a76d996ce1fd4e8312edee70

commit 58d78a900e6e1b69a76d996ce1fd4e8312edee70
Author: Ningning Xia <nxia@google.com>
Date: Wed Nov 22 01:15:46 2017

Provide deploy_app.py script to deploy the app.

The script will 1) deploy the endpoints service; 2) fill the app.yaml
with the latest endpoints service config id; 3) deploy the app to GAE.

BUG= chromium:746514 
TEST=manually deployed & tested

Change-Id: I1ef570b2111eb244011b7d14914caccda9fd485a

[add] https://crrev.com/58d78a900e6e1b69a76d996ce1fd4e8312edee70/app_template.yaml
[add] https://crrev.com/58d78a900e6e1b69a76d996ce1fd4e8312edee70/deploy_app.py

Project Member

Comment 16 by bugdroid1@chromium.org, Dec 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/infra/cl_status_viewer/+/d700236e6559700ef73986ac86e058d7ad126fd9

commit d700236e6559700ef73986ac86e058d7ad126fd9
Author: Ningning Xia <nxia@google.com>
Date: Thu Nov 30 23:33:41 2017

Move the server project into cl_status_viewer_server

cl_status_viwer will have two GAE projects: cl_status_viewer_server as
the backend server and cl_status_viwer_ui as the frontend server. Move
all the server project into cl_status_viewer_server/.

BUG= chromium:746514 
TEST=unit_tests

Change-Id: I4fad5dbf274e7cbc65e0b9cb2da983dc1b526846

[rename] https://crrev.com/d700236e6559700ef73986ac86e058d7ad126fd9/cl_status_viewer_server/common/protos/__init__.py
[rename] https://crrev.com/d700236e6559700ef73986ac86e058d7ad126fd9/cl_status_viewer_server/common/__init__.py
[rename] https://crrev.com/d700236e6559700ef73986ac86e058d7ad126fd9/cl_status_viewer_server/requirements.txt
[rename] https://crrev.com/d700236e6559700ef73986ac86e058d7ad126fd9/cl_status_viewer_server/v1.py
[rename] https://crrev.com/d700236e6559700ef73986ac86e058d7ad126fd9/cl_status_viewer_server/cl_status_server_unittest.py
[rename] https://crrev.com/d700236e6559700ef73986ac86e058d7ad126fd9/cl_status_viewer_server/main.py
[rename] https://crrev.com/d700236e6559700ef73986ac86e058d7ad126fd9/cl_status_viewer_server/common/protos/viewer_message.proto
[add] https://crrev.com/d700236e6559700ef73986ac86e058d7ad126fd9/cl_status_viewer_server/chromite
[rename] https://crrev.com/d700236e6559700ef73986ac86e058d7ad126fd9/cl_status_viewer_server/cl_status_server.py
[rename] https://crrev.com/d700236e6559700ef73986ac86e058d7ad126fd9/cl_status_viewer_server/deploy_app.py
[copy] https://crrev.com/d700236e6559700ef73986ac86e058d7ad126fd9/cl_status_viewer_server/__init__.py
[delete] https://crrev.com/58d78a900e6e1b69a76d996ce1fd4e8312edee70/__init__.py
[rename] https://crrev.com/d700236e6559700ef73986ac86e058d7ad126fd9/cl_status_viewer_server/openapi-appengine.yaml
[delete] https://crrev.com/58d78a900e6e1b69a76d996ce1fd4e8312edee70/chromite
[rename] https://crrev.com/d700236e6559700ef73986ac86e058d7ad126fd9/cl_status_viewer_server/app_template.yaml

Project Member

Comment 18 by bugdroid1@chromium.org, Dec 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/infra/cl_status_viewer/+/8a02236df585b15f1e77873e2fff3a4a928f5955

commit 8a02236df585b15f1e77873e2fff3a4a928f5955
Author: Ningning Xia <nxia@google.com>
Date: Thu Dec 07 23:25:43 2017

Add README.md to cl_status_viewer_server

BUG= chromium:746514 
TEST=None

Change-Id: I4e9b225f46f1f67b7c72de0bcd4480e332309455

[add] https://crrev.com/8a02236df585b15f1e77873e2fff3a4a928f5955/cl_status_viewer_server/README.md

Project Member

Comment 19 by bugdroid1@chromium.org, Jan 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/infra/cl_status_viewer/+/7764efd6b1ff7e271d55b6cd1efb2bd5b7b3ef77

commit 7764efd6b1ff7e271d55b6cd1efb2bd5b7b3ef77
Author: Ningning Xia <nxia@google.com>
Date: Wed Jan 17 17:43:42 2018

Change cl status view UI

1) use javascripts function to display status color.
2) remove unimportant build information, only maintain build name, build
link and build status.

BUG= chromium:746514 
TEST=local build

Change-Id: Ic1524900133ed4a23142ed70ed9ab27d00aeef75

[modify] https://crrev.com/7764efd6b1ff7e271d55b6cd1efb2bd5b7b3ef77/cl_status_viewer_ui/cl_status_page.html

Project Member

Comment 20 by bugdroid1@chromium.org, Jan 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/infra/cl_status_viewer/+/af7b3481535f05a6586c1f865624117fc25a7622

commit af7b3481535f05a6586c1f865624117fc25a7622
Author: Ningning Xia <nxia@google.com>
Date: Wed Jan 17 17:57:17 2018

Add the README file.

BUG= chromium:746514 
TEST=None

Change-Id: Iabc4a213f66e4444ffbd8b818924b18bc16ea4f5

[add] https://crrev.com/af7b3481535f05a6586c1f865624117fc25a7622/cl_status_viewer_ui/README.md

Project Member

Comment 21 by bugdroid1@chromium.org, Jan 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/da85558d44a768ac275bf26b8d0fe833d2357b93

commit da85558d44a768ac275bf26b8d0fe833d2357b93
Author: Ningning Xia <nxia@chromium.org>
Date: Fri Jan 19 01:40:21 2018

Add the CL_Status_Viewer URL in the CL comment.

When PreCQ or CQ picks up a CL to test, it sends a notification to the
CL gerrit comment, add the CL_Status_Viwer URL for this CL in the
notification message.

BUG= chromium:746514 
TEST=unit tests

Change-Id: I42713f63f704d82e774ade28be1c7ccc5aeba7f8
Reviewed-on: https://chromium-review.googlesource.com/871253
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Ningning Xia <nxia@chromium.org>
Reviewed-by: Paul Hobbs <phobbs@google.com>

[modify] https://crrev.com/da85558d44a768ac275bf26b8d0fe833d2357b93/cbuildbot/validation_pool.py
[modify] https://crrev.com/da85558d44a768ac275bf26b8d0fe833d2357b93/cbuildbot/validation_pool_unittest.py

Comment 22 by nxia@chromium.org, Feb 15 2018

Status: Fixed (was: Untriaged)

Sign in to add a comment