New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 746513 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

network_WiFi_TDLSPing: ERROR: DUT does not report a missing TDLS link: False

Project Member Reported by briannorris@chromium.org, Jul 19 2017

Issue description

I was looking through some of the top test failures in wifi_matfunc, and I noticed that network_WiFi_TDLSPing still has quite a few failures:

https://wmatrix.googleplex.com/wifi_matfunc?hide_missing=True&tests=network_WiFi_TDLSPing&days_back=20&releases=61

---

Notably, many devices (or the APs they are paired with in wificells) don't actually support TDLS, but those will get TestNA (yellow).

Also, there is a long-standing bug ( bug 699735 ) to track some failures distinct from the $subject one.

---

To the $subject failure: this test currently assumes that with a clear cache, it can
(a) perform an ARP lookup request that fails
(b) wait 1 second for a request/reply to complete and fill the ARP cache
(c) perform another ARP lookup successfully

Step (c) fails relatively often (~10% on a particular Link device). Looking into the net.log, it seems that shill is complaining in step (c):

"ARP lookup is still in progress"

So...it seems reasonable to put this in a retry loop, to give it a little better chance at succeeding. Initial testing shows a ~0% failure rate for this test on the same link after retrying another time or two.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/26cbf83455535012dac583a8698ab03003688f0b

commit 26cbf83455535012dac583a8698ab03003688f0b
Author: Brian Norris <briannorris@chromium.org>
Date: Thu Jul 20 22:00:37 2017

network_WiFi_TDLSPing: retry "initial" ARP lookups

Apparently, a 1 second delay is not really enough time to guarantee a
lookup succeeds. We're not really aiming to test ARP lookup latency
here, so it makes sense to just retry a few times, especially
considering that on many runs, shill is telling us that "ARP lookup is
still in progress".

Also, add a bit of logging in wifi_client for these TDLS operations. We
do something similar for association and ping-test logic, and it makes
for a little easier reading/analysis when these operations are logged in
the autoserv logs, and not just implicitly through (for example) the
device syslog/netlog.

BUG= chromium:746513 
TEST=network_WiFi_TDLSPing

Change-Id: Idc9b9505b6d2744aac4ac0b8bd37a4acf6f5fe73
Signed-off-by: Brian Norris <briannorris@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/578311
Commit-Ready: Kirtika Ruchandani <kirtika@chromium.org>
Reviewed-by: Kirtika Ruchandani <kirtika@chromium.org>

[modify] https://crrev.com/26cbf83455535012dac583a8698ab03003688f0b/server/cros/network/wifi_client.py
[modify] https://crrev.com/26cbf83455535012dac583a8698ab03003688f0b/server/site_tests/network_WiFi_TDLSPing/network_WiFi_TDLSPing.py

Status: Fixed (was: Started)
This one's fixed, AFAICT.

Comment 3 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment