New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 746512 link

Starred by 1 user
Status: Fixed
Owner:
█ jrbarnette@chromium.org
Last visit > 30 days ago
Closed: Jul 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

CrosRebootRepair not always effective against dev mode

Reported by jrbarnette@chromium.org, Jul 19 2017 
When a DUT is in dev mode, we apply CrosRebootRepair,
which invokes `set_gbb_flags.sh 0` to clear dev mode, then
reboots the DUT.  However, in some cases, this seems not
to be effective.

The command `crossystem disable_dev_request=1` will work
when set_gbb_flags doesn't; we should use both commands
in the repair action.
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 20 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/0f368556c8920f655be78e7b23f3eb3d96cf1a10

commit 0f368556c8920f655be78e7b23f3eb3d96cf1a10
Author: Richard Barnette <jrbarnette@chromium.org>
Date: Thu Jul 20 07:37:01 2017

[autotest] Also use crossystem to clear dev mode in repair.

If a DUT fails verification because it's in dev mode, we should use
both "set_gbb_flags" and also "crossystem" to clear dev mode, to make
sure all the state gets reset as expected.

BUG= chromium:746512 
TEST=Manually run from python CLI

Change-Id: Ifb878a5c3ebdf0f7e0cc2d9749cb0ab3e88101e5
Reviewed-on: https://chromium-review.googlesource.com/578058
Commit-Ready: Richard Barnette <jrbarnette@chromium.org>
Tested-by: Richard Barnette <jrbarnette@chromium.org>
Reviewed-by: Xixuan Wu <xixuan@chromium.org>

[modify] https://crrev.com/0f368556c8920f655be78e7b23f3eb3d96cf1a10/server/hosts/cros_repair.py

Comment 2 by jrbarnette@chromium.org, Jul 21 2017 

Waiting for a push to prod before declaring this fixed.

Comment 3 by jrbarnette@chromium.org, Jul 24 2017

Status: Fixed (was: Started)
Now pushed
►

Sign in to add a comment