VrShellTransitionTest tests intermittently failing due to onStop assert |
|||||
Issue descriptionSome of the tests in VrShellTransitionTest are intermittently failing due to hitting a recently added assert in VrShellDelegate's onStop. Should be easily reproducible locally by running the VR test APK several times with "--test-filter VrShellTransitionTest#*" added. Example failures: https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.fyi%2FAndroid_VR_Tests%2F9761%2F%2B%2Frecipes%2Fsteps%2Fchrome_public_test_vr_apk__2_%2F0%2Fsteps%2Fchrome_public_test_vr_apk.chrome_public_test_vr_apk__2_%2F0%2Fstdout https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.fyi%2FAndroid_VR_Tests%2F9715%2F%2B%2Frecipes%2Fsteps%2Fchrome_public_test_vr_apk__2_%2F0%2Fsteps%2Fchrome_public_test_vr_apk.chrome_public_test_vr_apk__2_%2F0%2Fstdout
,
Jul 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/eb33eca25d6b9f0098d6b0c9c20eefb00db37b58 commit eb33eca25d6b9f0098d6b0c9c20eefb00db37b58 Author: Michael Thiessen <mthiesse@chromium.org> Date: Fri Jul 21 21:38:07 2017 VR: Make sure VR is fully entered before proceeding in tests. Bug: 746504 Change-Id: Ia7296889916aac759edfef72c34beb01770d79ca Reviewed-on: https://chromium-review.googlesource.com/581851 Reviewed-by: Yash Malik <ymalik@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#488757} [modify] https://crrev.com/eb33eca25d6b9f0098d6b0c9c20eefb00db37b58/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java [modify] https://crrev.com/eb33eca25d6b9f0098d6b0c9c20eefb00db37b58/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/util/VrTransitionUtils.java
,
Jul 24 2017
Fix seems to have worked, as I'm not seeing this anymore. The bot's much more green as a result.
,
Mar 1 2018
,
Mar 1 2018
,
Aug 29
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by bsheedy@chromium.org
, Jul 19 2017Status: Assigned (was: Untriaged)