New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 746503 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Aug 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Switch compiler-rt and libcxx to use vfpv3

Project Member Reported by manojgupta@chromium.org, Jul 19 2017

Issue description

Some Chromecast HW may not support NEON.
Switch these libraries to use vfpv3 for compatibility.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/11eb0b7ee7b6ddf70000537f1e3e5ec69906bdf6

commit 11eb0b7ee7b6ddf70000537f1e3e5ec69906bdf6
Author: Manoj Gupta <manojgupta@google.com>
Date: Wed Jul 19 23:27:00 2017

compiler-rt: Use vfpv3 as the default fpu in ARM32.

Some targets e.g. chromecast may not support NEON.
Switching fpu to vfpv3 will provide compatibility without
any major performance impact.

BUG= chromium:746503 
TEST=Performance on elm and diasy stays unchanged for the toolchain
benchmarks.

Change-Id: I057bd13eead380933a9acadf3e4851530a2f2769
Reviewed-on: https://chromium-review.googlesource.com/577048
Commit-Ready: Manoj Gupta <manojgupta@chromium.org>
Tested-by: Manoj Gupta <manojgupta@chromium.org>
Reviewed-by: Bailey Forrest <bcf@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[rename] https://crrev.com/11eb0b7ee7b6ddf70000537f1e3e5ec69906bdf6/sys-libs/compiler-rt/compiler-rt-5.0_pre300080-r8.ebuild

Status: Verified (was: Untriaged)

Comment 3 by bcf@chromium.org, Jul 24 2017

I still see NEON being set on the library on 2017.07.23.154155:

readelf -A ./usr/armv7a-cros-linux-gnueabi/usr/lib/libc++.so.1 | grep -i neon
  Tag_Advanced_SIMD_arch: NEONv1

Is this expected?

Comment 4 by bcf@chromium.org, Jul 24 2017

Cc: yunlian@chromium.org
Status: Assigned (was: Verified)
Owner: yunlian@chromium.org
libcxxabi still uses neon in the ebuild.
For #3, I think it is expected. However, we are not using neon by specifying
-mfpu=vfpv3
http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.dui0774f/chr1392305424052.html

For #6, I have a patch for that.
Project Member

Comment 8 by bugdroid1@chromium.org, Jul 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/6301c03ae75ec2168639ade021d5c6c50f6d69d6

commit 6301c03ae75ec2168639ade021d5c6c50f6d69d6
Author: Yunlian Jiang <yunlian@google.com>
Date: Wed Jul 26 23:46:53 2017

libcxxabi: disable neon on arm.

ChromeCast want libcxx built without NEON. This CL
does the fix for them.

BUG= chromium:746503 
TEST=cross-armv7a-cros-linux-gnueabi/libcxxabi
     no neon instruction in the binary.

Change-Id: I32d6122860e0df7ee943601a0c44e55c86f19e60
Reviewed-on: https://chromium-review.googlesource.com/585647
Commit-Ready: Yunlian Jiang <yunlian@chromium.org>
Tested-by: Yunlian Jiang <yunlian@chromium.org>
Reviewed-by: Manoj Gupta <manojgupta@chromium.org>

[rename] https://crrev.com/6301c03ae75ec2168639ade021d5c6c50f6d69d6/sys-libs/libcxxabi/libcxxabi-4.0.0-r5.ebuild

Comment 9 by bcf@chromium.org, Jul 29 2017

Is anything else required from this?
Status: Fixed (was: Assigned)
Status: Verified (was: Fixed)
Closing. Please reopen it if its not fixed. Thanks!

Sign in to add a comment