New issue
Advanced search Search tips

Issue 746499 link

Starred by 1 user
Status: Fixed
Owner:
vapier@chromium.org
Closed: Jul 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

gerrit *1234 no longer references internal-gerrit

Project Member Reported by akes...@chromium.org, Jul 19 2017 
$ ./gerrit inspect '*413728'
https://chromium-review.googlesource.com/#/c/413728/ CR: 2 CQ: 0 V: 0 kernel BACKPORT: usb: gadget: f_fs: Fix use-after-free

(expected: reference to a change on chrome-internal-review)

Assigned this and  Issue 746498  because it appears you've been touching this tool recently.

Comment 1 by vapier@chromium.org, Jul 19 2017 

any code that uses FilteredQuery/_Query doesn't support looking up via diff GoB instances.  that means inspect/todo/search/deps.  we'll have to do some reworking here of inputs.
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 20 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/5f938cac4846daa5bbebd8313fd54b9711e6c5fe

commit 5f938cac4846daa5bbebd8313fd54b9711e6c5fe
Author: Mike Frysinger <vapier@chromium.org>
Date: Thu Jul 20 07:36:59 2017

gerrit: inspect: fix *12345 syntax

BUG= chromium:746499 
TEST=`gerrit inspect '*413728' 413728` returns details about the internal & external CLs

Change-Id: I7dbafae1fc3e79d71d43a2cfa75802786a9e0574
Reviewed-on: https://chromium-review.googlesource.com/578408
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Aviv Keshet <akeshet@chromium.org>

[modify] https://crrev.com/5f938cac4846daa5bbebd8313fd54b9711e6c5fe/scripts/gerrit.py

Comment 3 by vapier@chromium.org, Jul 20 2017

Status: Fixed (was: Untriaged)
►

Sign in to add a comment