Add a disk cache in addition to the existing memory cache for thumbnails in download home.
Add a disk cache in addition to the existing memory cache for thumbnails in download home to reduce regenerating them. Design doc: https://docs.google.com/a/google.com/document/d/1Xc167BBJqCMtLAqsV-QVDBdcxLEGTaAuZ1T1J8sftg4/edit?usp=sharing
Add a disk cache in addition to the existing memory cache for thumbnails in download home to avoid regenerating them. Design doc: https://docs.google.com/a/google.com/document/d/1Xc167BBJqCMtLAqsV-QVDBdcxLEGTaAuZ1T1J8sftg4/edit?usp=sharing
Add a disk cache in addition to the existing memory cache for thumbnails in download home and download suggestion (Zine) to avoid regenerating them. Design doc: https://docs.google.com/a/google.com/document/d/1Xc167BBJqCMtLAqsV-QVDBdcxLEGTaAuZ1T1J8sftg4/edit?usp=sharing
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/63c0b59001b40d4221aa87c332828793e5090690 commit 63c0b59001b40d4221aa87c332828793e5090690 Author: Tommy Nyquist <nyquist@chromium.org> Date: Tue Aug 22 20:45:18 2017 chrome/android: Add disk cache for download thumbnails. We want to cache the thumbnails in download home and download suggestions (Zine) to the disk in addition to the existing memory cache. This patch separates the memory cache from the thumbnail generation logic in ThumbnailProviderImpl and creates a new class ThumbnailProviderDiskStorage for disk caching. BUG=746488 TBR=twellington@chromium.org Change-Id: Ia7470695e594ce1bf642650110bafd64059e1fb4 Reviewed-on: https://chromium-review.googlesource.com/577720 Commit-Queue: Tommy Nyquist <nyquist@chromium.org> Reviewed-by: Bernhard Bauer <bauerb@chromium.org> Reviewed-by: Tommy Nyquist <nyquist@chromium.org> Reviewed-by: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#496434} [modify] https://crrev.com/63c0b59001b40d4221aa87c332828793e5090690/chrome/android/BUILD.gn [modify] https://crrev.com/63c0b59001b40d4221aa87c332828793e5090690/chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadHistoryItemWrapper.java [modify] https://crrev.com/63c0b59001b40d4221aa87c332828793e5090690/chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadItemView.java [add] https://crrev.com/63c0b59001b40d4221aa87c332828793e5090690/chrome/android/java/src/org/chromium/chrome/browser/download/ui/ThumbnailDiskStorage.java [add] https://crrev.com/63c0b59001b40d4221aa87c332828793e5090690/chrome/android/java/src/org/chromium/chrome/browser/download/ui/ThumbnailGenerator.java [add] https://crrev.com/63c0b59001b40d4221aa87c332828793e5090690/chrome/android/java/src/org/chromium/chrome/browser/download/ui/ThumbnailGeneratorCallback.java [modify] https://crrev.com/63c0b59001b40d4221aa87c332828793e5090690/chrome/android/java/src/org/chromium/chrome/browser/download/ui/ThumbnailProvider.java [modify] https://crrev.com/63c0b59001b40d4221aa87c332828793e5090690/chrome/android/java/src/org/chromium/chrome/browser/download/ui/ThumbnailProviderImpl.java [add] https://crrev.com/63c0b59001b40d4221aa87c332828793e5090690/chrome/android/java/src/org/chromium/chrome/browser/download/ui/ThumbnailStorageDelegate.java [add] https://crrev.com/63c0b59001b40d4221aa87c332828793e5090690/chrome/android/java/src/org/chromium/chrome/browser/download/ui/thumbnail_cache_entry.proto [modify] https://crrev.com/63c0b59001b40d4221aa87c332828793e5090690/chrome/android/java/src/org/chromium/chrome/browser/suggestions/ImageFetcher.java [modify] https://crrev.com/63c0b59001b40d4221aa87c332828793e5090690/chrome/android/java_sources.gni [modify] https://crrev.com/63c0b59001b40d4221aa87c332828793e5090690/chrome/android/javatests/src/org/chromium/chrome/browser/download/ui/StubbedProvider.java [add] https://crrev.com/63c0b59001b40d4221aa87c332828793e5090690/chrome/android/javatests/src/org/chromium/chrome/browser/download/ui/ThumbnailDiskStorageTest.java [modify] https://crrev.com/63c0b59001b40d4221aa87c332828793e5090690/chrome/android/javatests/src/org/chromium/chrome/browser/download/ui/ThumbnailProviderImplTest.java [modify] https://crrev.com/63c0b59001b40d4221aa87c332828793e5090690/chrome/android/javatests/src/org/chromium/chrome/browser/ntp/snippets/ArticleSnippetsTest.java [modify] https://crrev.com/63c0b59001b40d4221aa87c332828793e5090690/chrome/browser/BUILD.gn [rename] https://crrev.com/63c0b59001b40d4221aa87c332828793e5090690/chrome/browser/android/download/ui/thumbnail_generator.cc [add] https://crrev.com/63c0b59001b40d4221aa87c332828793e5090690/chrome/browser/android/download/ui/thumbnail_generator.h [delete] https://crrev.com/83c2544d276cad4341da42aed3e240489183f611/chrome/browser/android/download/ui/thumbnail_provider.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/85555f2d302ca1e18487626e6b012b2409dc1ba7 commit 85555f2d302ca1e18487626e6b012b2409dc1ba7 Author: Ian Clelland <iclelland@chromium.org> Date: Wed Aug 23 23:33:35 2017 Revert "chrome/android: Add disk cache for download thumbnails." This reverts commit 63c0b59001b40d4221aa87c332828793e5090690. Reason for revert: Tests are still flaky; two failures in AndroidTests in the last 12 hours: https://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/45097 https://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/45092 Original change's description: > chrome/android: Add disk cache for download thumbnails. > > We want to cache the thumbnails in download home and download suggestions > (Zine) to the disk in addition to the existing memory cache. This patch > separates the memory cache from the thumbnail generation logic in > ThumbnailProviderImpl and creates a new class ThumbnailProviderDiskStorage > for disk caching. > > BUG=746488 > TBR=twellington@chromium.org > > Change-Id: Ia7470695e594ce1bf642650110bafd64059e1fb4 > Reviewed-on: https://chromium-review.googlesource.com/577720 > Commit-Queue: Tommy Nyquist <nyquist@chromium.org> > Reviewed-by: Bernhard Bauer <bauerb@chromium.org> > Reviewed-by: Tommy Nyquist <nyquist@chromium.org> > Reviewed-by: Min Qin <qinmin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#496434} TBR=bauerb@chromium.org,nyquist@chromium.org,qinmin@chromium.org,twellington@chromium.org,angelashao@google.com Change-Id: I8ad413e04ddb7101a6736ff09f9518f90c88d66c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 746488 Reviewed-on: https://chromium-review.googlesource.com/628660 Reviewed-by: Min Qin <qinmin@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#496864} [modify] https://crrev.com/85555f2d302ca1e18487626e6b012b2409dc1ba7/chrome/android/BUILD.gn [modify] https://crrev.com/85555f2d302ca1e18487626e6b012b2409dc1ba7/chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadHistoryItemWrapper.java [modify] https://crrev.com/85555f2d302ca1e18487626e6b012b2409dc1ba7/chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadItemView.java [delete] https://crrev.com/3a9a1b227ffe419b4887677633ec41009782257d/chrome/android/java/src/org/chromium/chrome/browser/download/ui/ThumbnailDiskStorage.java [delete] https://crrev.com/3a9a1b227ffe419b4887677633ec41009782257d/chrome/android/java/src/org/chromium/chrome/browser/download/ui/ThumbnailGenerator.java [delete] https://crrev.com/3a9a1b227ffe419b4887677633ec41009782257d/chrome/android/java/src/org/chromium/chrome/browser/download/ui/ThumbnailGeneratorCallback.java [modify] https://crrev.com/85555f2d302ca1e18487626e6b012b2409dc1ba7/chrome/android/java/src/org/chromium/chrome/browser/download/ui/ThumbnailProvider.java [modify] https://crrev.com/85555f2d302ca1e18487626e6b012b2409dc1ba7/chrome/android/java/src/org/chromium/chrome/browser/download/ui/ThumbnailProviderImpl.java [delete] https://crrev.com/3a9a1b227ffe419b4887677633ec41009782257d/chrome/android/java/src/org/chromium/chrome/browser/download/ui/ThumbnailStorageDelegate.java [delete] https://crrev.com/3a9a1b227ffe419b4887677633ec41009782257d/chrome/android/java/src/org/chromium/chrome/browser/download/ui/thumbnail_cache_entry.proto [modify] https://crrev.com/85555f2d302ca1e18487626e6b012b2409dc1ba7/chrome/android/java/src/org/chromium/chrome/browser/suggestions/ImageFetcher.java [modify] https://crrev.com/85555f2d302ca1e18487626e6b012b2409dc1ba7/chrome/android/java_sources.gni [modify] https://crrev.com/85555f2d302ca1e18487626e6b012b2409dc1ba7/chrome/android/javatests/src/org/chromium/chrome/browser/download/ui/StubbedProvider.java [delete] https://crrev.com/3a9a1b227ffe419b4887677633ec41009782257d/chrome/android/javatests/src/org/chromium/chrome/browser/download/ui/ThumbnailDiskStorageTest.java [modify] https://crrev.com/85555f2d302ca1e18487626e6b012b2409dc1ba7/chrome/android/javatests/src/org/chromium/chrome/browser/download/ui/ThumbnailProviderImplTest.java [modify] https://crrev.com/85555f2d302ca1e18487626e6b012b2409dc1ba7/chrome/android/javatests/src/org/chromium/chrome/browser/ntp/snippets/ArticleSnippetsTest.java [modify] https://crrev.com/85555f2d302ca1e18487626e6b012b2409dc1ba7/chrome/browser/BUILD.gn [delete] https://crrev.com/3a9a1b227ffe419b4887677633ec41009782257d/chrome/browser/android/download/ui/thumbnail_generator.h [rename] https://crrev.com/85555f2d302ca1e18487626e6b012b2409dc1ba7/chrome/browser/android/download/ui/thumbnail_provider.cc [add] https://crrev.com/85555f2d302ca1e18487626e6b012b2409dc1ba7/chrome/browser/android/download/ui/thumbnail_provider.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/49d6f07b8fdaa46a9a935b13e0855561f2727a23 commit 49d6f07b8fdaa46a9a935b13e0855561f2727a23 Author: Min Qin <qinmin@chromium.org> Date: Wed Oct 25 18:47:56 2017 Reland "chrome/android: Add disk cache for download thumbnails."" This reverts commit 85555f2d302ca1e18487626e6b012b2409dc1ba7. Reason for revert: Resolved all rebase conflicts and fixed the bot failure Original change's description: > Revert "chrome/android: Add disk cache for download thumbnails." > > This reverts commit 63c0b59001b40d4221aa87c332828793e5090690. > > Reason for revert: Tests are still flaky; two failures in AndroidTests in the last 12 hours: > https://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/45097 > https://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/45092 > > Original change's description: > > chrome/android: Add disk cache for download thumbnails. > > > > We want to cache the thumbnails in download home and download suggestions > > (Zine) to the disk in addition to the existing memory cache. This patch > > separates the memory cache from the thumbnail generation logic in > > ThumbnailProviderImpl and creates a new class ThumbnailProviderDiskStorage > > for disk caching. > > > > BUG=746488 > > TBR=twellington@chromium.org > > > > Change-Id: Ia7470695e594ce1bf642650110bafd64059e1fb4 > > Reviewed-on: https://chromium-review.googlesource.com/577720 > > Commit-Queue: Tommy Nyquist <nyquist@chromium.org> > > Reviewed-by: Bernhard Bauer <bauerb@chromium.org> > > Reviewed-by: Tommy Nyquist <nyquist@chromium.org> > > Reviewed-by: Min Qin <qinmin@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#496434} > > TBR=bauerb@chromium.org,nyquist@chromium.org,qinmin@chromium.org,twellington@chromium.org,angelashao@google.com > > Change-Id: I8ad413e04ddb7101a6736ff09f9518f90c88d66c > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 746488 > Reviewed-on: https://chromium-review.googlesource.com/628660 > Reviewed-by: Min Qin <qinmin@chromium.org> > Commit-Queue: Min Qin <qinmin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#496864} TBR=bauerb@chromium.org,nyquist@chromium.org,qinmin@chromium.org,twellington@chromium.org,angelashao@google.com,iclelland@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 746488 Change-Id: Ifb536418ee14655b0cfe20deb6283735a28c348b Reviewed-on: https://chromium-review.googlesource.com/730874 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by: Tommy Nyquist <nyquist@chromium.org> Reviewed-by: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#511537} [modify] https://crrev.com/49d6f07b8fdaa46a9a935b13e0855561f2727a23/chrome/android/BUILD.gn [modify] https://crrev.com/49d6f07b8fdaa46a9a935b13e0855561f2727a23/chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadHistoryItemWrapper.java [modify] https://crrev.com/49d6f07b8fdaa46a9a935b13e0855561f2727a23/chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadItemView.java [modify] https://crrev.com/49d6f07b8fdaa46a9a935b13e0855561f2727a23/chrome/android/java/src/org/chromium/chrome/browser/suggestions/ImageFetcher.java [add] https://crrev.com/49d6f07b8fdaa46a9a935b13e0855561f2727a23/chrome/android/java/src/org/chromium/chrome/browser/widget/ThumbnailDiskStorage.java [add] https://crrev.com/49d6f07b8fdaa46a9a935b13e0855561f2727a23/chrome/android/java/src/org/chromium/chrome/browser/widget/ThumbnailGenerator.java [add] https://crrev.com/49d6f07b8fdaa46a9a935b13e0855561f2727a23/chrome/android/java/src/org/chromium/chrome/browser/widget/ThumbnailGeneratorCallback.java [modify] https://crrev.com/49d6f07b8fdaa46a9a935b13e0855561f2727a23/chrome/android/java/src/org/chromium/chrome/browser/widget/ThumbnailProvider.java [modify] https://crrev.com/49d6f07b8fdaa46a9a935b13e0855561f2727a23/chrome/android/java/src/org/chromium/chrome/browser/widget/ThumbnailProviderImpl.java [add] https://crrev.com/49d6f07b8fdaa46a9a935b13e0855561f2727a23/chrome/android/java/src/org/chromium/chrome/browser/widget/ThumbnailStorageDelegate.java [add] https://crrev.com/49d6f07b8fdaa46a9a935b13e0855561f2727a23/chrome/android/java/src/org/chromium/chrome/browser/widget/thumbnail_cache_entry.proto [modify] https://crrev.com/49d6f07b8fdaa46a9a935b13e0855561f2727a23/chrome/android/java_sources.gni [modify] https://crrev.com/49d6f07b8fdaa46a9a935b13e0855561f2727a23/chrome/android/javatests/src/org/chromium/chrome/browser/download/ui/StubbedProvider.java [modify] https://crrev.com/49d6f07b8fdaa46a9a935b13e0855561f2727a23/chrome/android/javatests/src/org/chromium/chrome/browser/ntp/snippets/ArticleSnippetsTest.java [add] https://crrev.com/49d6f07b8fdaa46a9a935b13e0855561f2727a23/chrome/android/javatests/src/org/chromium/chrome/browser/widget/ThumbnailDiskStorageTest.java [modify] https://crrev.com/49d6f07b8fdaa46a9a935b13e0855561f2727a23/chrome/android/javatests/src/org/chromium/chrome/browser/widget/ThumbnailProviderImplTest.java [modify] https://crrev.com/49d6f07b8fdaa46a9a935b13e0855561f2727a23/chrome/browser/BUILD.gn [delete] https://crrev.com/dc4a6f396176370c9eedc4883980e3ab4adc0b98/chrome/browser/android/download/ui/thumbnail_provider.h [rename] https://crrev.com/49d6f07b8fdaa46a9a935b13e0855561f2727a23/chrome/browser/android/widget/thumbnail_generator.cc [add] https://crrev.com/49d6f07b8fdaa46a9a935b13e0855561f2727a23/chrome/browser/android/widget/thumbnail_generator.h
Comment 1 by sheriffbot@chromium.org
, Jul 20 2017