New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 746477 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 2
Type: Bug



Sign in to add a comment

Choosing "Don't Reload" on reload of page w/ onbeforeunload set changes the page title to the URL

Reported by chad.r...@gmail.com, Jul 19 2017

Issue description

UserAgent: Mozilla/5.0 (Windows NT 6.3; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/59.0.3071.115 Safari/537.36

Steps to reproduce the problem:
1. Navigate to page w/ onbeforeunload set
2. Attempt refresh
3. Choose "Don't Reload"
4. Confirm the title of the page has changed to show the URL

What is the expected behavior?
The title should not change (it doesn't in FF and elsewhere)

What went wrong?
That's it

Did this work before? N/A 

Does this work in other browsers? N/A

Chrome version: 59.0.3071.115  Channel: stable
OS Version: 6.3
Flash Version:
 
before-unload.html
222 bytes View Download
Cc: brajkumar@chromium.org
Labels: Needs-Feedback
Unable to reproduce this issue on Windows-10 using chrome latest stable #59.0.3071.115 by following steps mentioned in the original comment. Observed no tittle change after clicking Don't Reload button.

Reporter@ Attaching screen cast for reference, Could you please take a look and let me me know if anything is missing from my end.

Thanks!
746477.mp4
702 KB View Download

Comment 2 by chad.r...@gmail.com, Jul 20 2017

brajkumar, why is the tab showing the title of "before-unload.html" instead of "Before Unload" there? I can show on Windows, via a pasted video if necessary, that it shows "Before Unload" when you first load the tab. Please confirm so I do not have to make the video.

Comment 3 by chad.r...@gmail.com, Jul 20 2017

Please show a video including you first-opening the tab; not with it already open. Also, where I experience this is not only in Chrome but in Chromium (via CEF) which is where I noticed it first.
Project Member

Comment 4 by sheriffbot@chromium.org, Jul 20 2017

Labels: -Needs-Feedback
Thank you for providing more feedback. Adding requester "brajkumar@chromium.org" to the cc list and removing "Needs-Feedback" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Components: Blink
Tested the issue on #59.0.3071.115 on Win 10 and was unable to reproduce the issue as per the steps mentioned in comment #0.

Can someone from Blink dev team please look into this issue.

Thanks!!
Please find the screen cast for the same.
Jul 21 2017 2-53 AM.webm
2.6 MB View Download

Comment 7 by chad.r...@gmail.com, Jul 21 2017

sandeepkumars, your video shows it perfectly. See how the title was "Before Unload" until you hit the reload button and when the dialog popped up, it immediately changed to "before-unload (1).html"?

Hopefully, as your video shows, it is quite clear this is a confirmed bug.
Components: -Blink Blink>Loader
Cc: pnangunoori@chromium.org
Labels: hasbisect M-60 OS-Linux
Owner: a...@chromium.org
Status: Assigned (was: Unconfirmed)
Tested on Chrome Stable#59.0.3071.115, Canary#61.0.3165.0 on Windows 10 & Ubuntu 14.04 and able to reproduce the issue.
 
Please find the bisect info below:

Chrome Good Build - 60.0.3093.2 (469894)
Chrome Bad Build - 60.0.3091.0 (469814) 

Per-revision bisect and hasbisect did not provide any possible suspects, so providing the CL manually.
 
Below is the CL: https://chromium.googlesource.com/chromium/src/+log/60.0.3091.0..60.0.3093.0?pretty=fuller&n=10000
 
@avi - Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to owner concerned.

Observations: From the build 60.0.3093.2, name of the tab is not changed. However, the dialog box which is prompted in the earlier versions is not noticed from the mentioned version.

Note: Issue is not reproduced on Mac 10.12.5

Thanks.

Comment 10 by a...@chromium.org, Jul 25 2017

Labels: -hasbisect Needs-Bisect
Can we try for a per-revision bisect?

Comment 11 by a...@chromium.org, Jul 25 2017

NOTE FOR REPRO:

BEFORE you click the reload button, make sure to click within the page. A change landed that requires that.

Comment 12 by a...@chromium.org, Jul 25 2017

FYI this is not good. If you click in the page as required, this still reproduces in Canary.

This must have broken a while ago.

Comment 13 by a...@chromium.org, Jul 25 2017

Attached a version of the repro page with old JavaScript syntax for bisecting with old Chromes.
before-unload.html
234 bytes View Download

Comment 14 by a...@chromium.org, Jul 25 2017

Labels: -Needs-Bisect
You are probably looking for a change made after 119887 (known good), but no later than 119891 (first known bad).
CHANGELOG URL:
  https://chromium.googlesource.com/chromium/src/+log/d46b302fb232e6b89c1a2b444bc06305f0f8ef86..c3b3d9590cbef573fafbffe7e33a43af28036812

Comment 15 by a...@chromium.org, Jul 25 2017

Likely https://chromium.googlesource.com/chromium/src/+/c3b3d9590cbef573fafbffe7e33a43af28036812 . This fixed  bug 96041 , something to make sure doesn't revert with a fix here.

Looks like this has been broken since Chrome 18.

Comment 16 by a...@chromium.org, Jul 25 2017

A thought: This is an unusual place to reset a title. How is this being picked up and displayed in Views but not on the Mac?

Comment 17 by a...@chromium.org, Jul 26 2017

Right now this is due to a suboptimal fix for  bug 96041 . It's not even a full fix; selecting the omnibox and hitting return doesn't reset the title, just an actual "reload".
Project Member

Comment 18 by bugdroid1@chromium.org, Aug 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/49fe84082780b0fdf3e257d894f6c315af16b906

commit 49fe84082780b0fdf3e257d894f6c315af16b906
Author: Avi Drissman <avi@chromium.org>
Date: Tue Aug 08 18:43:08 2017

Revert r119891, which incorrectly reset NavEntry titles.

r119891 reset the title of the NavEntry upon reload. This is
incorrect because:
- there is no guarantee that the reload will commit, which
  could leave a page title-less.
- it did not handle all cases of reloading.

An existing test's use of TitleWatcher inadvertently relied
on this resetting, and thus is updated.

BUG= 96041 , 746477 

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation
Change-Id: I96bf6ae2603ad60f3c6ade6d827cd950964aa759
Reviewed-on: https://chromium-review.googlesource.com/596152
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492711}
[modify] https://crrev.com/49fe84082780b0fdf3e257d894f6c315af16b906/chrome/browser/referrer_policy_browsertest.cc
[modify] https://crrev.com/49fe84082780b0fdf3e257d894f6c315af16b906/content/browser/frame_host/navigation_controller_impl.cc
[modify] https://crrev.com/49fe84082780b0fdf3e257d894f6c315af16b906/content/browser/frame_host/navigation_controller_impl_unittest.cc

Comment 19 by a...@chromium.org, Aug 8 2017

Status: Fixed (was: Assigned)
This fixes this bug and regresses 96041.

Sign in to add a comment