New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 746445 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Successful web payment crashes the store website

Reported by v...@ripple.com, Jul 19 2017

Issue description

Steps to reproduce the problem:
Uploading a video

What is the expected behavior?

What went wrong?
Aw, snap error after a successful web payment. Note that developer tools are open.. not sure if this would affect it tho.

Crashed report ID: 8ed1796288000000

How much crashed? Just one tab

Is it a problem with a plugin? No 

Did this work before? N/A 

Chrome version: 61.0.3159.0  Channel: stable
OS Version: 7.1.2
Flash Version: 

It worked a few times.
 
device-2017-07-18-103938.mp4
2.8 MB View Download
Cc: gogerald@chromium.org rob.buis@chromium.org
Thank you for the report! The crash ID unfortunately does not have a very good stack. Please share with us the JS code or URL that we can use to reproduce the issue and solve it on our end.

Comment 2 by v...@ripple.com, Jul 25 2017

Here's the service worker 
https://github.com/interledgerjs/ilp-kit/blob/master/static/sw.js

and here are the instructions for testing
1. login to https://red.ilpdemo.org alice:alice for the service to register a payment handler
2. visit https://red.ilpdemo.org/store.html
 Issue 746446  has been merged into this issue.
Owner: gogerald@chromium.org
I can take a look of this bug,
It always crash when I verify it with latest local build Chrome. The crash is because the empty response details (https://w3c.github.io/payment-handler/#dom-paymenthandlerresponse-details) which triggers a failure logic we haven't implemented yet. Can you confirm you have returned appropriate details? And I did not see the screen at 0:16 in your video.

Comment 6 by v...@ripple.com, Jul 27 2017

Yep, that was it. I added the "details" and it works now. Thank you!
Status: Fixed (was: Unconfirmed)
I landed a CL to implement the failure logic, https://chromium-review.googlesource.com/c/587147/. Should be good after it is rolled out.

Sign in to add a comment