New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 746440 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature



Sign in to add a comment

Improve error message when an input directory is missing during test isolation

Project Member Reported by mar...@chromium.org, Jul 19 2017

Issue description

Repro:
- A person moves a test data directory and doesn't update BUILD.gn
- Due to incremental build, this doesn't fail right away, passes the CQ; or this is for an configuration outside of the CQ (e.g. perf)
- Breakage on clobber build after the fact after compile in the isolate step, which users aren't fully familiar with.

Issue:
- The fact that 'isolate tests' fails makes it look like an infrastructure issue.
- The error message is unclear about what is happening during isolate archive, e.g.
"14:39:45.846558 Unable to walk "/b/build/slave/Android_Compile/build/src/cc/test/data": walk("/b/build/slave/Android_Compile/build/src/cc/test/data"): lstat /b/build/slave/Android_Compile/build/src/cc/test/data: no such file or directory"
as seen in  issue 746016 

Observations about the error message:
- lstat() part isn't relevant to the user
- path is listed twice, which makes the error message hard to read
- 'Unable to walk' is kind of obscure
- path is absolute instead of relative, which hinders the understanding

AIs:
- Improve the error message to give a nudge about the fact that an input directory was listed but it's not present. The fact that it was found via lstat isn't relevant to the user and the path should be relative as the user may not know what the base directory is.
- This should be printed as an error, not as a log which drowns it into the noise.
 
Cc: kbr@chromium.org thakis@chromium.org
The fact that these build breakage changes can slip through CQ is scary. I wonder whether we can detect when the build has changed & clean out the build directory to rebuild from scratch instead.

Comment 2 by mar...@chromium.org, Jul 19 2017

This is in fact a minor detail, it's as confusing for try jobs too; try job users have to figure out by themselves; the error message isn't clear.
Project Member

Comment 3 by sheriffbot@chromium.org, Jul 19

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: -tansell@chromium.org -mcgreevy@chromium.org
Labels: -Hotlist-Recharge-Cold
Status: Available (was: Untriaged)
This is still true.

Sign in to add a comment