Issue metadata
Sign in to add a comment
|
Static initializer added to MonochromePublic.apk at 487602:487602 |
||||||||||||||||||||
Issue descriptionCaused by "Enable bounded mode logging on chrome://net-export." Commit: c2fadc96f9678d8b8aa87efd8f6cf1d30ee3ebbd
,
Jul 19 2017
Following the discussion in issue 740955 , policy is to revert first then reland with the fix. Created revert here: https://chromium-review.googlesource.com/c/577197.
,
Jul 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5602e852d482212446cab44097f2907d64297217 commit 5602e852d482212446cab44097f2907d64297217 Author: Eric Stevenson <estevenson@chromium.org> Date: Wed Jul 19 17:24:09 2017 Revert "Enable bounded mode logging on chrome://net-export." This reverts commit c2fadc96f9678d8b8aa87efd8f6cf1d30ee3ebbd. Reason for revert: Added static initializer to MonochromePublic.apk. Original change's description: > Enable bounded mode logging on chrome://net-export. > > There is an option to configure the maximum size of the NetLog. The > default is 100MiB. > > Bug: 679030 > Change-Id: I9260d7ee895d589c4789a350ca4fe1dfc8617b65 > Reviewed-on: https://chromium-review.googlesource.com/571514 > Commit-Queue: Eric Roman <eroman@chromium.org> > Reviewed-by: Helen Li <xunjieli@chromium.org> > Cr-Commit-Position: refs/heads/master@{#487602} TBR=eroman@chromium.org,xunjieli@chromium.org Change-Id: I7d8fb8daee69e381097b441f3ed42bd24ae252d1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 679030 , 746430 Reviewed-on: https://chromium-review.googlesource.com/577197 Commit-Queue: Eric Stevenson <estevenson@chromium.org> Reviewed-by: Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#487900} [modify] https://crrev.com/5602e852d482212446cab44097f2907d64297217/chrome/browser/ui/webui/net_export_ui.cc [modify] https://crrev.com/5602e852d482212446cab44097f2907d64297217/components/net_log/net_export_file_writer.cc [modify] https://crrev.com/5602e852d482212446cab44097f2907d64297217/components/net_log/net_export_file_writer.h [modify] https://crrev.com/5602e852d482212446cab44097f2907d64297217/components/net_log/net_export_file_writer_unittest.cc [modify] https://crrev.com/5602e852d482212446cab44097f2907d64297217/components/net_log/resources/net_export.css [modify] https://crrev.com/5602e852d482212446cab44097f2907d64297217/components/net_log/resources/net_export.html [modify] https://crrev.com/5602e852d482212446cab44097f2907d64297217/components/net_log/resources/net_export.js [modify] https://crrev.com/5602e852d482212446cab44097f2907d64297217/ios/chrome/browser/ui/webui/net_export/net_export_ui.cc
,
Jul 19 2017
Given this was reverted, I believe it can be closed.
,
Jul 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3c7a60e6088f7446f0ee7315cd4859ef448d64e5 commit 3c7a60e6088f7446f0ee7315cd4859ef448d64e5 Author: Eric Stevenson <estevenson@chromium.org> Date: Mon Jul 24 17:47:57 2017 Revert "gpu: Implement passthrough decoder program cache." This reverts commit c00fbc6170a5726fee8021bde0bb0b0fe7bad793. Reason for revert: Adds static initializers to MonochromePublic.apk Original change's description: > gpu: Implement passthrough decoder program cache. > > This hooks up ANGLE to talk to the disk cache, and instruments the > necessary controls over the cache to handle sizing and memory > pressure. > > Uses an unretained callback to avoid the layering violation of > calling from ui/gl into the command buffer. > > BUG= 738513 > > Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel > Change-Id: I9cb3ad9cbdd756d7b31248e788bb7f9e93aae90a > Reviewed-on: https://chromium-review.googlesource.com/568671 > Reviewed-by: Antoine Labour <piman@chromium.org> > Commit-Queue: Jamie Madill <jmadill@chromium.org> > Cr-Commit-Position: refs/heads/master@{#488984} TBR=jmadill@chromium.org,piman@chromium.org Change-Id: I3f54629a40d8366e9a80513f205a83ffa8572200 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 738513 , 746430 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/583667 Reviewed-by: Eric Stevenson <estevenson@chromium.org> Commit-Queue: Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#489021} [modify] https://crrev.com/3c7a60e6088f7446f0ee7315cd4859ef448d64e5/gpu/command_buffer/service/BUILD.gn [modify] https://crrev.com/3c7a60e6088f7446f0ee7315cd4859ef448d64e5/gpu/command_buffer/service/gles2_cmd_decoder_passthrough.cc [delete] https://crrev.com/d4a941c61b23cf4a59c7e23655249155aea2d6e7/gpu/command_buffer/service/passthrough_program_cache.cc [delete] https://crrev.com/d4a941c61b23cf4a59c7e23655249155aea2d6e7/gpu/command_buffer/service/passthrough_program_cache.h [modify] https://crrev.com/3c7a60e6088f7446f0ee7315cd4859ef448d64e5/gpu/ipc/service/gpu_channel_manager.cc [modify] https://crrev.com/3c7a60e6088f7446f0ee7315cd4859ef448d64e5/ui/gl/angle_platform_impl.cc [modify] https://crrev.com/3c7a60e6088f7446f0ee7315cd4859ef448d64e5/ui/gl/angle_platform_impl.h [modify] https://crrev.com/3c7a60e6088f7446f0ee7315cd4859ef448d64e5/ui/gl/gl_surface_egl.cc |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by 42576172...@developer.gserviceaccount.com
, Jul 19 2017