New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 746294 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Regression : "Pulse" effect is seen for dialog box even when clicking on a overflow scrollbar.

Reported by avsha...@etouch.net, Jul 19 2017

Issue description

Chrome version : 61.0.3161.0 (Official Build) 76e234ed8928315841951a5f170232e9c959633d-refs/heads/master@{#487694} 32/64 bit
OS : Windows (7,8,10), Mac(10.11.6, 10.12.3), Linux(14.04 LTS)

What steps will reproduce the problem?
1. Launch chrome, navigate to chrome://md-settings and open 'import bookmarks and settings' dialog.
2. Now click on 'Restore down' button and resize browser window upwards such that overflow scrollbar appears on a dialog box.
3. Click on up/down arrows of overflow scrollbar and observe the dialog box.

Actual Result : "Pulse" effect is seen for dialog box even when clicking on a overflow scrollbar.

Expected Result : Instead, the "Pulse" effect should only be seen when clicking ouside dialog box and effect should not be seen when clicking on a scrollbar.

This is a regression issue broken in ‘M-61’, below is the Manual Regression range and will soon update other info.
Good build : 61.0.3155.0
Bad build : 61.0.3156.0
 
Actual_Result.mp4
1.3 MB View Download
Expected_Result.mp4
965 KB View Download
Labels: hasbisect-per-revision
Owner: dpa...@chromium.org
Status: Assigned (was: Unconfirmed)
Using the per-revision bisect providing the bisect results,
Good build:61.0.3155.0(Revision:485784).
Bad build:61.0.3156.0(Revision:486205).

You are probably looking for a change made after 486134 (known good), but no later than 486135 (first known bad).

CHANGE-LOG URL:
---------------
https://chromium.googlesource.com/chromium/src/+log/45a4619feedbc6e383d06086997b3f696e2359d6..1da9af16908d1288e8c9d08b6bd27e964b4ae15c

From the CL above, assigning the issue to the concern owner

@dpapad: Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.

Reviewed-on: https://chromium-review.googlesource.com/566093
Note :Able to reproduce the issue in Win 10.0,Ubuntu 14.04 & Mac 10.12.3 and Able to reproduce in latest Canary #61.0.3161.0

Comment 2 by dpa...@chromium.org, Jul 19 2017

Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d0ecf5e935f5b32fa55868ee7d2cd1279f38f330

commit d0ecf5e935f5b32fa55868ee7d2cd1279f38f330
Author: dpapad <dpapad@chromium.org>
Date: Thu Jul 20 23:02:20 2017

WebUI cr-dialog: Don't play "pulse" animation when clicking on the scrollbar.

Bug:  746294 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ie50a57965ca0cea2d5415ac3a6ffea88d6d38201
Reviewed-on: https://chromium-review.googlesource.com/578294
Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488466}
[modify] https://crrev.com/d0ecf5e935f5b32fa55868ee7d2cd1279f38f330/ui/webui/resources/cr_elements/cr_dialog/cr_dialog.html

Comment 4 by dpa...@chromium.org, Jul 20 2017

Status: Fixed (was: Started)

Comment 5 by avsha...@etouch.net, Jul 26 2017

Labels: TE-Verified-M61 TE-Verified-61.0.3163.13
Retested above issue on Win(7,8,10) and Mac(10.11.6, 10.12.5) OS using latest Chrome Dev#61.0.3163.13 and issue is fixed. Now "pulse" animation does not play when clicking on the overflow scrollbar.

Thank you..

Comment 6 by avsha...@etouch.net, Jul 26 2017

Tested above issue on Linux(14.04 LTS)OS on Dev#61.0.3163.13 build and issue is fixed. It is working as intended now.

Sign in to add a comment