New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 746276 link

Starred by 1 user
Status: Fixed
Owner:
mlamouri@chromium.org
Closed: Jul 2017
Cc:
agrieve@chromium.org
█ yipengw@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: ----



Sign in to add a comment

incremental_apk_by_default builds break at gn step

Project Member Reported by bauerb@chromium.org, Jul 19 2017 
Steps to reproduce:
1) Add `incremental_apk_by_default = true` to your gn args
2) Run `gn gen`

Result:
  ERROR at //build/config/android/rules.gni:2448:23: Assignment had no effect.
      _apk_operations = []
                        ^
  You set the variable "_apk_operations" here and it was unused before it went
  out of scope.

Comment 1 by mlamouri@chromium.org, Jul 19 2017

Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 19 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/547811c04560d75abab73a3ebed44e98138896a0

commit 547811c04560d75abab73a3ebed44e98138896a0
Author: Mounir Lamouri <mlamouri@chromium.org>
Date: Wed Jul 19 13:23:28 2017

Fix unused variabl gn error when using `incremental_apk_by_default=true`.

Bug:  746276 
Change-Id: Iab7f806ac062067c599cf7063f83d2a10de92f7a
Reviewed-on: https://chromium-review.googlesource.com/576180
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487842}
[modify] https://crrev.com/547811c04560d75abab73a3ebed44e98138896a0/build/config/android/rules.gni

Comment 3 by mlamouri@chromium.org, Jul 19 2017

Status: Fixed (was: Started)
►

Sign in to add a comment