New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 746270 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocking:
issue 740816



Sign in to add a comment

Files app: Share actions for Android apps have redundant labels in share options menu.

Project Member Reported by fukino@chromium.org, Jul 19 2017

Issue description

Chrome Version: ToT
OS: Chrome

What steps will reproduce the problem?
(1) Install Android apps which support SEND intents (e.g. Google Photos app)
(2) In Files app, select a file and open share menu on toolbar.
(3) Observe the label for the SEND intent.

What is the expected result?
We have "Upload to Photos" menu item in share options.

What happens instead?
We have "Share with Upload to Photos" menu item.

Please use labels and text to provide additional information.


For graphics-related bugs, please copy/paste the contents of the about:gpu
page at the end of this report.

 
Screenshot 2017-07-19 at 18.38.38.png
222 KB View Download

Comment 1 by fukino@chromium.org, Jul 19 2017

We have labels, like "Upload to Photos", for SEND intent handlers from Android world.
https://developer.android.com/reference/android/content/pm/ResolveInfo.html#loadLabel(android.content.pm.PackageManager)

Maybe we should omit the "Share with" prefixes from Android's SEND intent handlers as they can be redundant.
weifangsun@, mcirimele@, WDYT?
I prefer to remove the "Share with" prefix, but not sure if in cases like Gmail, it will be confusing not to have the prefix?

Is there anyway to clean this up on our side? For example:
- If the label = app name, keep the "Share with" prefix
- If the label <> app name, remove the "Share with" prefix

Comment 3 by fukino@chromium.org, Jul 21 2017

I'm not sure if we can reliably compare App name and the label. (e.g. the label and app name might be slightly different, especially when they are translated?)

Since the actions are shown after we hit the share icon, I think the labels without "Share with" prefix is not so confusing and it is consistent with the labels we see on Android.
If there is no way to differentiate when to use the "Share with" prefix I think we should drop it. It becomes very repetitive (and action names are long) to have it in there for each action. 

Fukino-san is this a big change? Could we try dropping it and see how it feels?

Comment 5 by fukino@chromium.org, Jul 25 2017

Status: Started (was: Assigned)
It should not be a big change.
Let me go with dropping "Share with" from ARC 'send' intents. Let's see how it feels.
Project Member

Comment 6 by bugdroid1@chromium.org, Jul 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5f51841b92d9b36f2a85f8393993baee11217c76

commit 5f51841b92d9b36f2a85f8393993baee11217c76
Author: Naoki Fukino <fukino@chromium.org>
Date: Tue Jul 25 09:01:08 2017

Files app: Remove "Share with" prefixes from actions from ARC's SEND handlers.

Actions from SEND intent handlers from Android apps can already have appropriate
verb in their labels. (e.g. "Upload to Photos" from Photos app).
This CL removes the "Share with" prefix from SEND intent handlers.

Bug:  746270 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ib7f4eaf7132906d3a99c89cd335be50cf5f41611
Reviewed-on: https://chromium-review.googlesource.com/583752
Reviewed-by: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Commit-Queue: Naoki Fukino <fukino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#489258}
[modify] https://crrev.com/5f51841b92d9b36f2a85f8393993baee11217c76/ui/file_manager/file_manager/foreground/js/file_tasks.js

Comment 7 by fukino@chromium.org, Jul 25 2017

Labels: M-61 Merge-Request-61
Status: Fixed (was: Started)
Project Member

Comment 8 by sheriffbot@chromium.org, Jul 26 2017

Labels: -Merge-Request-61 Hotlist-Merge-Approved Merge-Approved-61
Your change meets the bar and is auto-approved for M61. Please go ahead and merge the CL to branch 3163 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), ketakid @(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: dhadd...@chromium.org mkarkada@chromium.org
Status: Assigned (was: Fixed)
This issue is still existing on M61 (Chrome os 9765.9.0, 61.0.3163.16 dev build) as well as M62 (Chrome os 9784.0.0, 62.0.3166.0 dev build).
Project Member

Comment 10 by sheriffbot@chromium.org, Jul 31 2017

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 11 by bugdroid1@chromium.org, Aug 1 2017

Labels: -merge-approved-61 merge-merged-3163
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/92b0ce97127ecff19a611303b458bf9c30c0666f

commit 92b0ce97127ecff19a611303b458bf9c30c0666f
Author: Naoki Fukino <fukino@chromium.org>
Date: Tue Aug 01 01:51:46 2017

Files app: Remove "Share with" prefixes from actions from ARC's SEND handlers.

Actions from SEND intent handlers from Android apps can already have appropriate
verb in their labels. (e.g. "Upload to Photos" from Photos app).
This CL removes the "Share with" prefix from SEND intent handlers.

TBR=fukino@chromium.org

(cherry picked from commit 5f51841b92d9b36f2a85f8393993baee11217c76)

Bug:  746270 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ib7f4eaf7132906d3a99c89cd335be50cf5f41611
Reviewed-on: https://chromium-review.googlesource.com/583752
Reviewed-by: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Commit-Queue: Naoki Fukino <fukino@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#489258}
Reviewed-on: https://chromium-review.googlesource.com/594749
Reviewed-by: Naoki Fukino <fukino@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#204}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/92b0ce97127ecff19a611303b458bf9c30c0666f/ui/file_manager/file_manager/foreground/js/file_tasks.js

Status: Fixed (was: Assigned)
Status: Assigned (was: Fixed)
Although this issue is fixed when you select a single file, it is reproduced on selection of multiple files.

Checked on M62 (Chrome OS 9801.0.0, 62.0.3174.0 dev build).
Attached are the screenshots.
Screenshot 2017-08-02 at 11.05.13 AM.png
118 KB View Download
Screenshot 2017-08-02 at 11.05.24 AM.png
132 KB View Download
Status: Fixed (was: Assigned)
The issue on comment #13 was tracked (and fixed) on  issue 751361 .
Marking this as Fixed.

Comment 15 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment