New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 746234 link

Starred by 2 users
Status: Fixed
Owner:
khorimoto@chromium.org
Closed: Jul 2017
Cc:
█ klemenko@google.com
fukino@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Closure compiler build is failing in internet_subpage.js

Project Member Reported by tetsui@chromium.org, Jul 19 2017 
To run closure compiler locally,

third_party/closure_compiler/run_compiler


Link to build or pfq page.
https://build.chromium.org/p/chromium.fyi/builders/Closure%20Compilation%20Linux?numbuilds=200

build # for that buildbot.
https://build.chromium.org/p/chromium.fyi/builders/Closure%20Compilation%20Linux/builds/109543

Snippet of log that contains the failure.
(ERROR) Error in: internet_subpage.js
## /usr/local/google/home/tetsui/chrome/src/chrome/browser/resources/settings/internet_page/internet_subpage.js:500: ERROR - inconsistent return type
## found   : string
## required: boolean
##       return this.i18nAdvanced('internetNoNetworksMobileData');
##              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
## 
## /usr/local/google/home/tetsui/chrome/src/chrome/browser/resources/settings/internet_page/internet_subpage.js:503: ERROR - inconsistent return type
## found   : string
## required: boolean
##     return this.i18n('internetNoNetworks');
##            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Comment 1 by khorimoto@chromium.org, Jul 19 2017

Status: Started (was: Untriaged)
Sorry for the breakage - not sure why Closure compiler didn't run on presubmit. Fixing now.

Comment 3 by dpa...@chromium.org, Jul 19 2017 

Maybe it did not run because of https://bugs.chromium.org/p/chromium/issues/detail?id=740601? That bug is marked as fixed, but we should probably verify the fix addressed the issue.
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 19 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e713c1653fe0874061c6b0cbe038cf2eea7abb29

commit e713c1653fe0874061c6b0cbe038cf2eea7abb29
Author: Kyle Horimoto <khorimoto@google.com>
Date: Wed Jul 19 19:31:38 2017

[CrOS Tether] Fix Closure compiler issue issue in internet_subpage.js.

The issue was that my getNoNetworksString_() function returns a string, but the
@return stated that the function returned a boolean.

Bug: 672263,  746234 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ieb244f304a159dd4ff9c7c5cf20041e742408064
Reviewed-on: https://chromium-review.googlesource.com/577758
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487938}
[modify] https://crrev.com/e713c1653fe0874061c6b0cbe038cf2eea7abb29/chrome/browser/resources/settings/internet_page/internet_subpage.js

Comment 5 by khorimoto@chromium.org, Jul 19 2017

Status: Fixed (was: Started)
►

Sign in to add a comment