New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 746220 link

Starred by 3 users
Status: Fixed
Owner:
horo@chromium.org
Closed: Oct 2017
Cc:
clamy@chromium.org
dgozman@chromium.org
█ susanjuniab@chromium.org
horo@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

"Bypass for network" in Service Workers panel in DevTools doesn't work when PlzNavigate is enabled.

Project Member Reported by horo@chromium.org, Jul 19 2017 
Chrome Version: 61.0.3159.5
OS: All

What steps will reproduce the problem?
(1) Enable browser side navigation: chrome://flags/#browser-side-navigation
(2) Go https://horo-t.github.io/serviceworker/demo/simpleblob/
(3) Click "click this"
(4) Click "test" link. => "Hello world"
(5) Open Service Workers panel in DevTools and check "Bypass for network".
(6) Reload the page.

What is the expected result?
404 error page is shown.

What happens instead?
"Hello world" which is served by the service worker is shown.

Comment 1 by falken@chromium.org, Aug 3 2017 

Do you have any ideas how to fix this? I assume since PlzNavigate starts the navigation without talking to the renderer, the DevTools settings in the current foreground renderer won't affect the navigation. Don't we have the same issue for things like Network Throttling, Disable Cache, etc? Or is there plumbing in place that makes those work?

Comment 2 by falken@chromium.org, Aug 3 2017 

Looks like network throttling doesn't work either:  issue 746220

Comment 3 by falken@chromium.org, Sep 29 2017 

Correct network throttling bug:  issue 749884  which is now fixed. Maybe we can reuse the plumbing added there to NavigationRequest?

Comment 4 by horo@chromium.org, Oct 24 2017

Cc: horo@chromium.org susanjuniab@chromium.org
 Issue 774811  has been merged into this issue.

Comment 5 by horo@chromium.org, Oct 24 2017

Labels: -Pri-3 Pri-2
Owner: horo@chromium.org
Status: Assigned (was: Available)
Look like P2.
Assigned to me.

Comment 6 by horo@chromium.org, Oct 24 2017

Status: Started (was: Assigned)

Comment 7 by horo@chromium.org, Oct 24 2017

Cc: clamy@chromium.org dgozman@chromium.org
Project Member

Comment 8 by bugdroid1@chromium.org, Oct 24 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a66f196008bfe9e895a91a9a66dc56909c4b7614

commit a66f196008bfe9e895a91a9a66dc56909c4b7614
Author: Tsuyoshi Horo <horo@chromium.org>
Date: Tue Oct 24 23:40:10 2017

Check DevTool's BypassServiceWorker flag in browser process for PlzNavigate.

Bug:  746220 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation
Change-Id: Id6158d90b700cdbd4014391aee7dcf3a52c4a2ff
Reviewed-on: https://chromium-review.googlesource.com/735163
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Tsuyoshi Horo <horo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511305}
[modify] https://crrev.com/a66f196008bfe9e895a91a9a66dc56909c4b7614/content/browser/devtools/protocol/network_handler.cc
[modify] https://crrev.com/a66f196008bfe9e895a91a9a66dc56909c4b7614/content/browser/devtools/protocol/network_handler.h
[modify] https://crrev.com/a66f196008bfe9e895a91a9a66dc56909c4b7614/content/browser/devtools/protocol_config.json
[modify] https://crrev.com/a66f196008bfe9e895a91a9a66dc56909c4b7614/content/browser/devtools/render_frame_devtools_agent_host.cc
[modify] https://crrev.com/a66f196008bfe9e895a91a9a66dc56909c4b7614/content/browser/devtools/render_frame_devtools_agent_host.h
[modify] https://crrev.com/a66f196008bfe9e895a91a9a66dc56909c4b7614/content/browser/frame_host/navigation_request.cc
[add] https://crrev.com/a66f196008bfe9e895a91a9a66dc56909c4b7614/third_party/WebKit/LayoutTests/http/tests/devtools/service-workers/resources/service-workers-bypass-for-network-navigation-iframe.html
[add] https://crrev.com/a66f196008bfe9e895a91a9a66dc56909c4b7614/third_party/WebKit/LayoutTests/http/tests/devtools/service-workers/resources/service-workers-bypass-for-network-navigation-worker.js
[add] https://crrev.com/a66f196008bfe9e895a91a9a66dc56909c4b7614/third_party/WebKit/LayoutTests/http/tests/devtools/service-workers/service-workers-bypass-for-network-navigation-expected.txt
[add] https://crrev.com/a66f196008bfe9e895a91a9a66dc56909c4b7614/third_party/WebKit/LayoutTests/http/tests/devtools/service-workers/service-workers-bypass-for-network-navigation.html

Comment 9 by horo@chromium.org, Oct 25 2017

Status: Fixed (was: Started)

Comment 10 by horo@chromium.org, Oct 25 2017 

The patch #8 landed in 64.0.3249.0.

$ git find-releases a66f196008bfe9e895a91a9a66dc56909c4b7614
commit a66f196008bfe9e895a91a9a66dc56909c4b7614 was:
  initially in 64.0.3249.0
►

Sign in to add a comment