Issue metadata
Sign in to add a comment
|
Regression : 'Learn more' link is seen missing at 'Google name servers' option in chrome://md-settings |
||||||||||||||||||||||
Issue descriptionChrome Version: 60.0.3112.71/9592.62.0 Beta channel Candy,Daisy,Peppy & Minnie OS: Chrome What steps will reproduce the problem? (1)Sign into User -> Go to chrome://md-settings page -> At 'Network' section click on Wi-Fi -> select Connected Wi-Fi network (2)Click on 'Network' ->Now at 'Name servers' click on Drop down and observe for 'Learn more' link at 'Google name servers' option (Please refer Video and screenshot) Expected: 'Learn more' link should be available at 'Google name servers' option. Actual: Instead 'Learn more' link is seen missing at 'Google name servers' option This is Regression Issue as 'Learn more' link is available in chrome://settings page @stevenjb : Please confirm the Issue Note: 1.Issue is seen in latest M-61 also 2.Issue is not applicable to Windows & Linux OS
,
Jul 19 2017
I doubt you can put an <a href> within a <select>.
,
Jul 19 2017
Yeah, I wasn't optimistic about that option either design or implementation wise. Do we have any other similar examples? I'm guessing if we do they use a radio button? I guess that wouldn't be too bad.
,
Jul 20 2017
I put together a change that uses toggles for 'Automatic nameservers' and 'Use Google nameservers'. bettes@, tbuckley@ - LMKWYT Screenshots attached.
,
Jul 20 2017
(Note: in the second screenshot the nameservers are editable. We don't indicate that currently; bettes@, we should discuss what that should look like for both IP address, Nameservers, and Proxy. The straightforward thing for me to do is to remove the underline when they are not editable, that would at least make Nameservers consistent with IP Config and Proxy)
,
Jul 24 2017
Awaiting UX feedback.
,
Aug 28 2017
Steven and I met offline. My recollection of the notes: - revert back to the radio button layout - show the input fields between each radio button that's selected. Moving of the UI is expected and satisfactory - Learn more links should be represented with the (?) icon and placed after the string (see chrome://settings/content for an example icon)
,
Aug 29 2017
Not truly urgent, punting to 62
,
Aug 29 2017
,
Sep 13 2017
,
Oct 13 2017
,
Oct 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/17967d4dd7b13d57bfbd96286646e86263c0622b commit 17967d4dd7b13d57bfbd96286646e86263c0622b Author: Steven Bennetts <stevenjb@chromium.org> Date: Wed Oct 25 17:40:23 2017 Settings: Network: Nameservers: Restore learn more links This CL switches to using radio buttons instead of a dropdown which allows adding a 'learn more' link after the 'Google nameservers' option (as per UX request). It also localizes the nameserver options (oops). Bug: 746210 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I1d12e6c870297d2c316840230c768182d5d55d9b Reviewed-on: https://chromium-review.googlesource.com/734287 Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#511508} [modify] https://crrev.com/17967d4dd7b13d57bfbd96286646e86263c0622b/chrome/app/settings_strings.grdp [modify] https://crrev.com/17967d4dd7b13d57bfbd96286646e86263c0622b/chrome/browser/ui/webui/chromeos/network_element_localized_strings_provider.cc [modify] https://crrev.com/17967d4dd7b13d57bfbd96286646e86263c0622b/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc [modify] https://crrev.com/17967d4dd7b13d57bfbd96286646e86263c0622b/chrome/common/url_constants.cc [modify] https://crrev.com/17967d4dd7b13d57bfbd96286646e86263c0622b/chrome/common/url_constants.h [modify] https://crrev.com/17967d4dd7b13d57bfbd96286646e86263c0622b/ui/webui/resources/cr_components/chromeos/network/network_config.html [modify] https://crrev.com/17967d4dd7b13d57bfbd96286646e86263c0622b/ui/webui/resources/cr_components/chromeos/network/network_ip_config.html [modify] https://crrev.com/17967d4dd7b13d57bfbd96286646e86263c0622b/ui/webui/resources/cr_components/chromeos/network/network_ip_config.js [modify] https://crrev.com/17967d4dd7b13d57bfbd96286646e86263c0622b/ui/webui/resources/cr_components/chromeos/network/network_nameservers.html [modify] https://crrev.com/17967d4dd7b13d57bfbd96286646e86263c0622b/ui/webui/resources/cr_components/chromeos/network/network_nameservers.js
,
Oct 25 2017
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by steve...@chromium.org
, Jul 19 2017Status: Started (was: Assigned)