service worker specific code shouldn't pollute these central data structures, and adding a new field requires a ton of plumbing. if we contain all the SW stuff in one place, things should be better.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/434d4dfe55708db7f54d7820626fcf5de0d0b63c commit 434d4dfe55708db7f54d7820626fcf5de0d0b63c Author: Matt Falkenhagen <falken@chromium.org> Date: Mon Jul 24 16:14:59 2017 Move WebServiceWorkerResponseType to mojom::FetchResponseType. This will aid refactoring SW code out of ResourceResponse. Also, as it's a concept from the Fetch spec, FetchResponseType is a better name. Bug: 746197 Change-Id: Ife54d2cfaf1e465308338f6f46aafc56c3e6eaaa Reviewed-on: https://chromium-review.googlesource.com/577488 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#488988} [modify] https://crrev.com/434d4dfe55708db7f54d7820626fcf5de0d0b63c/content/browser/DEPS [modify] https://crrev.com/434d4dfe55708db7f54d7820626fcf5de0d0b63c/content/browser/background_fetch/background_fetch_data_manager.cc [modify] https://crrev.com/434d4dfe55708db7f54d7820626fcf5de0d0b63c/content/browser/background_fetch/background_fetch_service_unittest.cc [modify] https://crrev.com/434d4dfe55708db7f54d7820626fcf5de0d0b63c/content/browser/cache_storage/cache_storage_cache.cc [modify] https://crrev.com/434d4dfe55708db7f54d7820626fcf5de0d0b63c/content/browser/cache_storage/cache_storage_cache_unittest.cc [modify] https://crrev.com/434d4dfe55708db7f54d7820626fcf5de0d0b63c/content/browser/cache_storage/cache_storage_manager_unittest.cc [modify] https://crrev.com/434d4dfe55708db7f54d7820626fcf5de0d0b63c/content/browser/service_worker/embedded_worker_test_helper.cc [modify] https://crrev.com/434d4dfe55708db7f54d7820626fcf5de0d0b63c/content/browser/service_worker/service_worker_controllee_request_handler.h [modify] https://crrev.com/434d4dfe55708db7f54d7820626fcf5de0d0b63c/content/browser/service_worker/service_worker_response_info.cc [modify] https://crrev.com/434d4dfe55708db7f54d7820626fcf5de0d0b63c/content/browser/service_worker/service_worker_response_info.h [modify] https://crrev.com/434d4dfe55708db7f54d7820626fcf5de0d0b63c/content/browser/service_worker/service_worker_url_request_job.cc [modify] https://crrev.com/434d4dfe55708db7f54d7820626fcf5de0d0b63c/content/browser/service_worker/service_worker_url_request_job.h [modify] https://crrev.com/434d4dfe55708db7f54d7820626fcf5de0d0b63c/content/browser/service_worker/service_worker_url_request_job_unittest.cc [modify] https://crrev.com/434d4dfe55708db7f54d7820626fcf5de0d0b63c/content/common/DEPS [modify] https://crrev.com/434d4dfe55708db7f54d7820626fcf5de0d0b63c/content/common/service_worker/service_worker_messages.h [modify] https://crrev.com/434d4dfe55708db7f54d7820626fcf5de0d0b63c/content/common/service_worker/service_worker_types.cc [modify] https://crrev.com/434d4dfe55708db7f54d7820626fcf5de0d0b63c/content/common/service_worker/service_worker_types.h [modify] https://crrev.com/434d4dfe55708db7f54d7820626fcf5de0d0b63c/content/public/common/resource_response_info.cc [modify] https://crrev.com/434d4dfe55708db7f54d7820626fcf5de0d0b63c/content/public/common/resource_response_info.h [modify] https://crrev.com/434d4dfe55708db7f54d7820626fcf5de0d0b63c/content/public/common/service_worker_modes.h [modify] https://crrev.com/434d4dfe55708db7f54d7820626fcf5de0d0b63c/content/shell/browser/layout_test/layout_test_push_messaging_service.cc [modify] https://crrev.com/434d4dfe55708db7f54d7820626fcf5de0d0b63c/third_party/WebKit/Source/core/frame/SubresourceIntegrityTest.cpp [modify] https://crrev.com/434d4dfe55708db7f54d7820626fcf5de0d0b63c/third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp [modify] https://crrev.com/434d4dfe55708db7f54d7820626fcf5de0d0b63c/third_party/WebKit/Source/modules/cachestorage/CacheTest.cpp [modify] https://crrev.com/434d4dfe55708db7f54d7820626fcf5de0d0b63c/third_party/WebKit/Source/modules/fetch/FetchManager.cpp [modify] https://crrev.com/434d4dfe55708db7f54d7820626fcf5de0d0b63c/third_party/WebKit/Source/modules/fetch/FetchResponseData.cpp [modify] https://crrev.com/434d4dfe55708db7f54d7820626fcf5de0d0b63c/third_party/WebKit/Source/modules/fetch/FetchResponseData.h [modify] https://crrev.com/434d4dfe55708db7f54d7820626fcf5de0d0b63c/third_party/WebKit/Source/modules/fetch/FetchResponseDataTest.cpp [modify] https://crrev.com/434d4dfe55708db7f54d7820626fcf5de0d0b63c/third_party/WebKit/Source/modules/fetch/Response.cpp [modify] https://crrev.com/434d4dfe55708db7f54d7820626fcf5de0d0b63c/third_party/WebKit/Source/modules/fetch/ResponseTest.cpp [modify] https://crrev.com/434d4dfe55708db7f54d7820626fcf5de0d0b63c/third_party/WebKit/Source/platform/exported/WebServiceWorkerResponse.cpp [modify] https://crrev.com/434d4dfe55708db7f54d7820626fcf5de0d0b63c/third_party/WebKit/Source/platform/exported/WebURLResponse.cpp [modify] https://crrev.com/434d4dfe55708db7f54d7820626fcf5de0d0b63c/third_party/WebKit/Source/platform/loader/fetch/ResourceFetcher.cpp [modify] https://crrev.com/434d4dfe55708db7f54d7820626fcf5de0d0b63c/third_party/WebKit/Source/platform/loader/fetch/ResourceLoader.cpp [modify] https://crrev.com/434d4dfe55708db7f54d7820626fcf5de0d0b63c/third_party/WebKit/Source/platform/loader/fetch/ResourceLoaderTest.cpp [modify] https://crrev.com/434d4dfe55708db7f54d7820626fcf5de0d0b63c/third_party/WebKit/Source/platform/loader/fetch/ResourceResponse.cpp [modify] https://crrev.com/434d4dfe55708db7f54d7820626fcf5de0d0b63c/third_party/WebKit/Source/platform/loader/fetch/ResourceResponse.h [modify] https://crrev.com/434d4dfe55708db7f54d7820626fcf5de0d0b63c/third_party/WebKit/public/BUILD.gn [modify] https://crrev.com/434d4dfe55708db7f54d7820626fcf5de0d0b63c/third_party/WebKit/public/platform/WebURLResponse.h [modify] https://crrev.com/434d4dfe55708db7f54d7820626fcf5de0d0b63c/third_party/WebKit/public/platform/modules/fetch/fetch_api_request.mojom [modify] https://crrev.com/434d4dfe55708db7f54d7820626fcf5de0d0b63c/third_party/WebKit/public/platform/modules/serviceworker/WebServiceWorkerResponse.h [delete] https://crrev.com/2c2a34b1d1c9dcb7c695419f66e1d7dc554c7a3f/third_party/WebKit/public/platform/modules/serviceworker/WebServiceWorkerResponseType.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/77817e6976a9b99842941f06e73f0706e4d5929e commit 77817e6976a9b99842941f06e73f0706e4d5929e Author: Matt Falkenhagen <falken@chromium.org> Date: Tue Jul 25 06:26:55 2017 Cleanup: Disambiguate "ServiceWorkerResponseType" After https://chromium-review.googlesource.com/c/577488/ moved blink::WebServiceWorkerResponseType to mojom::FetchResponseType, some FetchResponseTypes still had naming based on ServiceWorkerResponseType. Rename them, especially since content::ServiceWorkerResponseType still exists which was confusing. Bug: 746197 Change-Id: I19d62ffb2e701a1b9f787b576622cf374b39fef9 Reviewed-on: https://chromium-review.googlesource.com/583954 Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by: Takeshi Yoshino <tyoshino@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#489242} [modify] https://crrev.com/77817e6976a9b99842941f06e73f0706e4d5929e/content/browser/cache_storage/cache_storage_cache.cc [modify] https://crrev.com/77817e6976a9b99842941f06e73f0706e4d5929e/content/browser/service_worker/service_worker_controllee_request_handler_unittest.cc [modify] https://crrev.com/77817e6976a9b99842941f06e73f0706e4d5929e/content/browser/service_worker/service_worker_url_request_job.cc [modify] https://crrev.com/77817e6976a9b99842941f06e73f0706e4d5929e/content/browser/service_worker/service_worker_url_request_job.h [modify] https://crrev.com/77817e6976a9b99842941f06e73f0706e4d5929e/content/child/web_url_loader_impl.cc [modify] https://crrev.com/77817e6976a9b99842941f06e73f0706e4d5929e/third_party/WebKit/Source/core/frame/SubresourceIntegrityTest.cpp [modify] https://crrev.com/77817e6976a9b99842941f06e73f0706e4d5929e/third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp [modify] https://crrev.com/77817e6976a9b99842941f06e73f0706e4d5929e/third_party/WebKit/Source/modules/fetch/FetchManager.cpp [modify] https://crrev.com/77817e6976a9b99842941f06e73f0706e4d5929e/third_party/WebKit/Source/platform/exported/WebURLResponse.cpp [modify] https://crrev.com/77817e6976a9b99842941f06e73f0706e4d5929e/third_party/WebKit/Source/platform/loader/fetch/ResourceFetcher.cpp [modify] https://crrev.com/77817e6976a9b99842941f06e73f0706e4d5929e/third_party/WebKit/Source/platform/loader/fetch/ResourceLoader.cpp [modify] https://crrev.com/77817e6976a9b99842941f06e73f0706e4d5929e/third_party/WebKit/Source/platform/loader/fetch/ResourceLoaderTest.cpp [modify] https://crrev.com/77817e6976a9b99842941f06e73f0706e4d5929e/third_party/WebKit/Source/platform/loader/fetch/ResourceResponse.cpp [modify] https://crrev.com/77817e6976a9b99842941f06e73f0706e4d5929e/third_party/WebKit/Source/platform/loader/fetch/ResourceResponse.h [modify] https://crrev.com/77817e6976a9b99842941f06e73f0706e4d5929e/third_party/WebKit/public/platform/WebURLResponse.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f8e2c057ec6123b0a1d08294f41e78c427636b49 commit f8e2c057ec6123b0a1d08294f41e78c427636b49 Author: Mike Bjorge <mbjorge@chromium.org> Date: Mon Aug 07 18:41:58 2017 Add mojo_blink dep from WebKit loader/. Now that loader has a direct dependency on the generated mojom-blink headers (https://chromium-review.googlesource.com/c/577488), the loader/ target should have a dep on the mojo target that generates the headers, otherwise the build may fail depending on build order. All the other platform/ targets that depend on the mojom-blink headers are directly included in the platform target, which has the necessary dependency already. Bug: 746197 Bug: 750883 Change-Id: Ife1429ec649605aae3f7920560cec37f3a218154 Reviewed-on: https://chromium-review.googlesource.com/602869 Reviewed-by: Yutaka Hirano <yhirano@chromium.org> Reviewed-by: Matt Falkenhagen <falken@chromium.org> Commit-Queue: Mike Bjorge <mbjorge@chromium.org> Cr-Commit-Position: refs/heads/master@{#492369} [modify] https://crrev.com/f8e2c057ec6123b0a1d08294f41e78c427636b49/third_party/WebKit/Source/platform/loader/BUILD.gn [modify] https://crrev.com/f8e2c057ec6123b0a1d08294f41e78c427636b49/third_party/WebKit/public/BUILD.gn
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2ab4ee36ec9392134e83f60f72b29f10a2d89e22 commit 2ab4ee36ec9392134e83f60f72b29f10a2d89e22 Author: Matt Falkenhagen <falken@chromium.org> Date: Thu Aug 10 10:43:10 2017 Introduce services/network/public/interfaces This moves blink::mojom::FetchResponseType to services/network, since it'll be needed here for mojom::URLLoader. Also, this fixes the flaky build failures caused by FetchResponseType by declaring the proper deps for it. Bug: 750883, 746197, 753658 Change-Id: Id3ae4e5a1be24f91bf1a27ffa8f680b86708f77a Reviewed-on: https://chromium-review.googlesource.com/607737 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Matt Falkenhagen <falken@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by: Yutaka Hirano <yhirano@chromium.org> Reviewed-by: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#493350} [modify] https://crrev.com/2ab4ee36ec9392134e83f60f72b29f10a2d89e22/content/browser/BUILD.gn [modify] https://crrev.com/2ab4ee36ec9392134e83f60f72b29f10a2d89e22/content/browser/background_fetch/background_fetch_data_manager.cc [modify] https://crrev.com/2ab4ee36ec9392134e83f60f72b29f10a2d89e22/content/browser/background_fetch/background_fetch_service_unittest.cc [modify] https://crrev.com/2ab4ee36ec9392134e83f60f72b29f10a2d89e22/content/browser/cache_storage/cache_storage_cache.cc [modify] https://crrev.com/2ab4ee36ec9392134e83f60f72b29f10a2d89e22/content/browser/cache_storage/cache_storage_cache_unittest.cc [modify] https://crrev.com/2ab4ee36ec9392134e83f60f72b29f10a2d89e22/content/browser/cache_storage/cache_storage_manager_unittest.cc [modify] https://crrev.com/2ab4ee36ec9392134e83f60f72b29f10a2d89e22/content/browser/service_worker/embedded_worker_test_helper.cc [modify] https://crrev.com/2ab4ee36ec9392134e83f60f72b29f10a2d89e22/content/browser/service_worker/service_worker_response_info.cc [modify] https://crrev.com/2ab4ee36ec9392134e83f60f72b29f10a2d89e22/content/browser/service_worker/service_worker_response_info.h [modify] https://crrev.com/2ab4ee36ec9392134e83f60f72b29f10a2d89e22/content/browser/service_worker/service_worker_url_loader_job_unittest.cc [modify] https://crrev.com/2ab4ee36ec9392134e83f60f72b29f10a2d89e22/content/browser/service_worker/service_worker_url_request_job.cc [modify] https://crrev.com/2ab4ee36ec9392134e83f60f72b29f10a2d89e22/content/browser/service_worker/service_worker_url_request_job.h [modify] https://crrev.com/2ab4ee36ec9392134e83f60f72b29f10a2d89e22/content/browser/service_worker/service_worker_url_request_job_unittest.cc [modify] https://crrev.com/2ab4ee36ec9392134e83f60f72b29f10a2d89e22/content/common/BUILD.gn [modify] https://crrev.com/2ab4ee36ec9392134e83f60f72b29f10a2d89e22/content/common/DEPS [modify] https://crrev.com/2ab4ee36ec9392134e83f60f72b29f10a2d89e22/content/common/service_worker/service_worker_messages.h [modify] https://crrev.com/2ab4ee36ec9392134e83f60f72b29f10a2d89e22/content/common/service_worker/service_worker_types.cc [modify] https://crrev.com/2ab4ee36ec9392134e83f60f72b29f10a2d89e22/content/common/service_worker/service_worker_types.h [modify] https://crrev.com/2ab4ee36ec9392134e83f60f72b29f10a2d89e22/content/public/DEPS [modify] https://crrev.com/2ab4ee36ec9392134e83f60f72b29f10a2d89e22/content/public/common/BUILD.gn [modify] https://crrev.com/2ab4ee36ec9392134e83f60f72b29f10a2d89e22/content/public/common/resource_response_info.cc [modify] https://crrev.com/2ab4ee36ec9392134e83f60f72b29f10a2d89e22/content/public/common/resource_response_info.h [modify] https://crrev.com/2ab4ee36ec9392134e83f60f72b29f10a2d89e22/content/test/BUILD.gn [add] https://crrev.com/2ab4ee36ec9392134e83f60f72b29f10a2d89e22/services/network/OWNERS [add] https://crrev.com/2ab4ee36ec9392134e83f60f72b29f10a2d89e22/services/network/README.md [add] https://crrev.com/2ab4ee36ec9392134e83f60f72b29f10a2d89e22/services/network/public/interfaces/BUILD.gn [add] https://crrev.com/2ab4ee36ec9392134e83f60f72b29f10a2d89e22/services/network/public/interfaces/OWNERS [add] https://crrev.com/2ab4ee36ec9392134e83f60f72b29f10a2d89e22/services/network/public/interfaces/fetch_api.mojom [modify] https://crrev.com/2ab4ee36ec9392134e83f60f72b29f10a2d89e22/third_party/WebKit/Source/core/DEPS [modify] https://crrev.com/2ab4ee36ec9392134e83f60f72b29f10a2d89e22/third_party/WebKit/Source/core/loader/BUILD.gn [modify] https://crrev.com/2ab4ee36ec9392134e83f60f72b29f10a2d89e22/third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp [modify] https://crrev.com/2ab4ee36ec9392134e83f60f72b29f10a2d89e22/third_party/WebKit/Source/modules/BUILD.gn [modify] https://crrev.com/2ab4ee36ec9392134e83f60f72b29f10a2d89e22/third_party/WebKit/Source/modules/cachestorage/CacheTest.cpp [modify] https://crrev.com/2ab4ee36ec9392134e83f60f72b29f10a2d89e22/third_party/WebKit/Source/modules/cachestorage/DEPS [modify] https://crrev.com/2ab4ee36ec9392134e83f60f72b29f10a2d89e22/third_party/WebKit/Source/modules/fetch/BUILD.gn [modify] https://crrev.com/2ab4ee36ec9392134e83f60f72b29f10a2d89e22/third_party/WebKit/Source/modules/fetch/DEPS [modify] https://crrev.com/2ab4ee36ec9392134e83f60f72b29f10a2d89e22/third_party/WebKit/Source/modules/fetch/FetchManager.cpp [modify] https://crrev.com/2ab4ee36ec9392134e83f60f72b29f10a2d89e22/third_party/WebKit/Source/modules/fetch/FetchResponseData.cpp [modify] https://crrev.com/2ab4ee36ec9392134e83f60f72b29f10a2d89e22/third_party/WebKit/Source/modules/fetch/FetchResponseDataTest.cpp [modify] https://crrev.com/2ab4ee36ec9392134e83f60f72b29f10a2d89e22/third_party/WebKit/Source/modules/fetch/Response.cpp [modify] https://crrev.com/2ab4ee36ec9392134e83f60f72b29f10a2d89e22/third_party/WebKit/Source/modules/fetch/ResponseTest.cpp [modify] https://crrev.com/2ab4ee36ec9392134e83f60f72b29f10a2d89e22/third_party/WebKit/Source/platform/exported/WebServiceWorkerResponse.cpp [modify] https://crrev.com/2ab4ee36ec9392134e83f60f72b29f10a2d89e22/third_party/WebKit/Source/platform/exported/WebURLResponse.cpp [modify] https://crrev.com/2ab4ee36ec9392134e83f60f72b29f10a2d89e22/third_party/WebKit/Source/platform/loader/BUILD.gn [modify] https://crrev.com/2ab4ee36ec9392134e83f60f72b29f10a2d89e22/third_party/WebKit/Source/platform/loader/DEPS [modify] https://crrev.com/2ab4ee36ec9392134e83f60f72b29f10a2d89e22/third_party/WebKit/Source/platform/loader/SubresourceIntegrityTest.cpp [modify] https://crrev.com/2ab4ee36ec9392134e83f60f72b29f10a2d89e22/third_party/WebKit/Source/platform/loader/fetch/Resource.cpp [modify] https://crrev.com/2ab4ee36ec9392134e83f60f72b29f10a2d89e22/third_party/WebKit/Source/platform/loader/fetch/ResourceLoader.cpp [modify] https://crrev.com/2ab4ee36ec9392134e83f60f72b29f10a2d89e22/third_party/WebKit/Source/platform/loader/fetch/ResourceLoaderTest.cpp [modify] https://crrev.com/2ab4ee36ec9392134e83f60f72b29f10a2d89e22/third_party/WebKit/Source/platform/loader/fetch/ResourceResponse.cpp [modify] https://crrev.com/2ab4ee36ec9392134e83f60f72b29f10a2d89e22/third_party/WebKit/Source/platform/loader/fetch/ResourceResponse.h [modify] https://crrev.com/2ab4ee36ec9392134e83f60f72b29f10a2d89e22/third_party/WebKit/common/README.md [modify] https://crrev.com/2ab4ee36ec9392134e83f60f72b29f10a2d89e22/third_party/WebKit/public/BUILD.gn [modify] https://crrev.com/2ab4ee36ec9392134e83f60f72b29f10a2d89e22/third_party/WebKit/public/platform/DEPS [modify] https://crrev.com/2ab4ee36ec9392134e83f60f72b29f10a2d89e22/third_party/WebKit/public/platform/WebURLResponse.h [modify] https://crrev.com/2ab4ee36ec9392134e83f60f72b29f10a2d89e22/third_party/WebKit/public/platform/modules/fetch/fetch_api_request.mojom [modify] https://crrev.com/2ab4ee36ec9392134e83f60f72b29f10a2d89e22/third_party/WebKit/public/platform/modules/serviceworker/WebServiceWorkerResponse.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8003f1f1683d85beee5b5e755838eff42f5a33d6 commit 8003f1f1683d85beee5b5e755838eff42f5a33d6 Author: Matt Falkenhagen <falken@chromium.org> Date: Tue Aug 15 08:32:16 2017 Remove unnecessary includes of fetch_api_request.mojom.h These were obsoleted by https://crrev.com/2ab4ee36ec9392134 Bug: 750883, 746197, 753658 Change-Id: I35da60e985253f46cc027388c6bf2a5476264e06 TBR: kinuko Reviewed-on: https://chromium-review.googlesource.com/614938 Reviewed-by: Matt Falkenhagen <falken@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by: Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#494345} [modify] https://crrev.com/8003f1f1683d85beee5b5e755838eff42f5a33d6/content/browser/DEPS [modify] https://crrev.com/8003f1f1683d85beee5b5e755838eff42f5a33d6/content/browser/background_fetch/background_fetch_data_manager.cc [modify] https://crrev.com/8003f1f1683d85beee5b5e755838eff42f5a33d6/content/browser/cache_storage/cache_storage_cache.cc [modify] https://crrev.com/8003f1f1683d85beee5b5e755838eff42f5a33d6/content/browser/service_worker/service_worker_response_info.h [modify] https://crrev.com/8003f1f1683d85beee5b5e755838eff42f5a33d6/content/browser/service_worker/service_worker_url_loader_job_unittest.cc [modify] https://crrev.com/8003f1f1683d85beee5b5e755838eff42f5a33d6/content/browser/service_worker/service_worker_url_request_job.h [modify] https://crrev.com/8003f1f1683d85beee5b5e755838eff42f5a33d6/content/common/service_worker/service_worker_types.h [modify] https://crrev.com/8003f1f1683d85beee5b5e755838eff42f5a33d6/content/public/common/resource_response_info.h [modify] https://crrev.com/8003f1f1683d85beee5b5e755838eff42f5a33d6/third_party/WebKit/Source/platform/loader/SubresourceIntegrityTest.cpp [modify] https://crrev.com/8003f1f1683d85beee5b5e755838eff42f5a33d6/third_party/WebKit/Source/platform/loader/fetch/ResourceResponse.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4c814b13abb3c06aa66f94a1234baa6ae4b41a3d commit 4c814b13abb3c06aa66f94a1234baa6ae4b41a3d Author: Matt Falkenhagen <falken@chromium.org> Date: Thu Oct 26 04:15:21 2017 Cleanup: Remove duplicate enums of FetchResponseType This type now lives in network::mojom::FetchResponseType which Blink can depend on, so there's no need for duplication. Also fix enums.xml naming for consistency. Bug: 746197 Change-Id: I6b3095554559dd8595edcf3e960e6600815118f5 Reviewed-on: https://chromium-review.googlesource.com/737594 Reviewed-by: Yutaka Hirano <yhirano@chromium.org> Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by: Ilya Sherman <isherman@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#511734} [modify] https://crrev.com/4c814b13abb3c06aa66f94a1234baa6ae4b41a3d/third_party/WebKit/Source/modules/cachestorage/BUILD.gn [modify] https://crrev.com/4c814b13abb3c06aa66f94a1234baa6ae4b41a3d/third_party/WebKit/Source/modules/cachestorage/Cache.cpp [modify] https://crrev.com/4c814b13abb3c06aa66f94a1234baa6ae4b41a3d/third_party/WebKit/Source/modules/fetch/FetchResponseData.cpp [modify] https://crrev.com/4c814b13abb3c06aa66f94a1234baa6ae4b41a3d/third_party/WebKit/Source/modules/fetch/FetchResponseData.h [modify] https://crrev.com/4c814b13abb3c06aa66f94a1234baa6ae4b41a3d/third_party/WebKit/Source/modules/fetch/Response.cpp [modify] https://crrev.com/4c814b13abb3c06aa66f94a1234baa6ae4b41a3d/third_party/WebKit/Source/modules/serviceworkers/BUILD.gn [modify] https://crrev.com/4c814b13abb3c06aa66f94a1234baa6ae4b41a3d/third_party/WebKit/Source/modules/serviceworkers/DEPS [modify] https://crrev.com/4c814b13abb3c06aa66f94a1234baa6ae4b41a3d/third_party/WebKit/Source/modules/serviceworkers/FetchRespondWithObserver.cpp [modify] https://crrev.com/4c814b13abb3c06aa66f94a1234baa6ae4b41a3d/third_party/WebKit/Source/modules/serviceworkers/ForeignFetchRespondWithObserver.cpp [modify] https://crrev.com/4c814b13abb3c06aa66f94a1234baa6ae4b41a3d/tools/metrics/histograms/enums.xml [modify] https://crrev.com/4c814b13abb3c06aa66f94a1234baa6ae4b41a3d/tools/metrics/histograms/histograms.xml
Comment 1 by bugdroid1@chromium.org
, Jul 24 2017