The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2302d2015a29612979ec1990f9dd8491a2b07f3e

commit 2302d2015a29612979ec1990f9dd8491a2b07f3e
Author: CJ DiMeglio <lethalantidote@chromium.org>
Date: Thu Aug 31 08:38:04 2017

Creates VideoFrameSubmitter.

This CL allows for a switch-enabled rerouting of VideoFrames into the
VideoFrameSubmitter, which commits frames to the CompositorFrameSink.
This allows video frames to be rendered onto a Surface.

BUG: 746182,  739854 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Ic4bd3f135e351c8a94c38524c69d5f59f296a0f3
Reviewed-on: https://chromium-review.googlesource.com/592398
Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Dimitri Glazkov <dglazkov@chromium.org>
Reviewed-by: apacible <apacible@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Justin Novosad <junov@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#498788}
[modify] https://crrev.com/2302d2015a29612979ec1990f9dd8491a2b07f3e/content/renderer/media/media_factory.cc
[modify] https://crrev.com/2302d2015a29612979ec1990f9dd8491a2b07f3e/content/renderer/media/media_factory.h
[modify] https://crrev.com/2302d2015a29612979ec1990f9dd8491a2b07f3e/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/2302d2015a29612979ec1990f9dd8491a2b07f3e/content/renderer/render_frame_impl.h
[modify] https://crrev.com/2302d2015a29612979ec1990f9dd8491a2b07f3e/media/blink/DEPS
[modify] https://crrev.com/2302d2015a29612979ec1990f9dd8491a2b07f3e/media/blink/video_frame_compositor.cc
[modify] https://crrev.com/2302d2015a29612979ec1990f9dd8491a2b07f3e/media/blink/video_frame_compositor.h
[modify] https://crrev.com/2302d2015a29612979ec1990f9dd8491a2b07f3e/media/blink/video_frame_compositor_unittest.cc
[modify] https://crrev.com/2302d2015a29612979ec1990f9dd8491a2b07f3e/media/blink/webmediaplayer_impl.cc
[modify] https://crrev.com/2302d2015a29612979ec1990f9dd8491a2b07f3e/media/blink/webmediaplayer_impl.h
[modify] https://crrev.com/2302d2015a29612979ec1990f9dd8491a2b07f3e/media/blink/webmediaplayer_impl_unittest.cc
[modify] https://crrev.com/2302d2015a29612979ec1990f9dd8491a2b07f3e/media/blink/webmediaplayer_params.cc
[modify] https://crrev.com/2302d2015a29612979ec1990f9dd8491a2b07f3e/media/blink/webmediaplayer_params.h
[modify] https://crrev.com/2302d2015a29612979ec1990f9dd8491a2b07f3e/third_party/WebKit/Source/core/CoreInitializer.h
[modify] https://crrev.com/2302d2015a29612979ec1990f9dd8491a2b07f3e/third_party/WebKit/Source/core/exported/LocalFrameClientImpl.cpp
[modify] https://crrev.com/2302d2015a29612979ec1990f9dd8491a2b07f3e/third_party/WebKit/Source/core/exported/LocalFrameClientImpl.h
[modify] https://crrev.com/2302d2015a29612979ec1990f9dd8491a2b07f3e/third_party/WebKit/Source/core/frame/LocalFrameClient.h
[modify] https://crrev.com/2302d2015a29612979ec1990f9dd8491a2b07f3e/third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp
[modify] https://crrev.com/2302d2015a29612979ec1990f9dd8491a2b07f3e/third_party/WebKit/Source/core/html/HTMLCanvasElement.h
[modify] https://crrev.com/2302d2015a29612979ec1990f9dd8491a2b07f3e/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
[modify] https://crrev.com/2302d2015a29612979ec1990f9dd8491a2b07f3e/third_party/WebKit/Source/core/html/HTMLMediaElementEventListenersTest.cpp
[modify] https://crrev.com/2302d2015a29612979ec1990f9dd8491a2b07f3e/third_party/WebKit/Source/core/loader/EmptyClients.cpp
[modify] https://crrev.com/2302d2015a29612979ec1990f9dd8491a2b07f3e/third_party/WebKit/Source/core/loader/EmptyClients.h
[modify] https://crrev.com/2302d2015a29612979ec1990f9dd8491a2b07f3e/third_party/WebKit/Source/core/paint/VideoPainterTest.cpp
[modify] https://crrev.com/2302d2015a29612979ec1990f9dd8491a2b07f3e/third_party/WebKit/Source/modules/ModulesInitializer.cpp
[modify] https://crrev.com/2302d2015a29612979ec1990f9dd8491a2b07f3e/third_party/WebKit/Source/modules/ModulesInitializer.h
[modify] https://crrev.com/2302d2015a29612979ec1990f9dd8491a2b07f3e/third_party/WebKit/Source/modules/media_controls/MediaControlsImplTest.cpp
[modify] https://crrev.com/2302d2015a29612979ec1990f9dd8491a2b07f3e/third_party/WebKit/Source/modules/media_controls/MediaControlsOrientationLockDelegateTest.cpp
[modify] https://crrev.com/2302d2015a29612979ec1990f9dd8491a2b07f3e/third_party/WebKit/Source/modules/media_controls/MediaControlsRotateToFullscreenDelegateTest.cpp
[modify] https://crrev.com/2302d2015a29612979ec1990f9dd8491a2b07f3e/third_party/WebKit/Source/platform/BUILD.gn
[modify] https://crrev.com/2302d2015a29612979ec1990f9dd8491a2b07f3e/third_party/WebKit/Source/platform/DEPS
[modify] https://crrev.com/2302d2015a29612979ec1990f9dd8491a2b07f3e/third_party/WebKit/Source/platform/exported/WebSurfaceLayerBridge.cpp
[add] https://crrev.com/2302d2015a29612979ec1990f9dd8491a2b07f3e/third_party/WebKit/Source/platform/exported/WebVideoFrameSubmitter.cpp
[modify] https://crrev.com/2302d2015a29612979ec1990f9dd8491a2b07f3e/third_party/WebKit/Source/platform/graphics/DEPS
[modify] https://crrev.com/2302d2015a29612979ec1990f9dd8491a2b07f3e/third_party/WebKit/Source/platform/graphics/SurfaceLayerBridge.cpp
[modify] https://crrev.com/2302d2015a29612979ec1990f9dd8491a2b07f3e/third_party/WebKit/Source/platform/graphics/SurfaceLayerBridge.h
[add] https://crrev.com/2302d2015a29612979ec1990f9dd8491a2b07f3e/third_party/WebKit/Source/platform/graphics/VideoFrameResourceProvider.cpp
[add] https://crrev.com/2302d2015a29612979ec1990f9dd8491a2b07f3e/third_party/WebKit/Source/platform/graphics/VideoFrameResourceProvider.h
[add] https://crrev.com/2302d2015a29612979ec1990f9dd8491a2b07f3e/third_party/WebKit/Source/platform/graphics/VideoFrameSubmitter.cpp
[add] https://crrev.com/2302d2015a29612979ec1990f9dd8491a2b07f3e/third_party/WebKit/Source/platform/graphics/VideoFrameSubmitter.h
[add] https://crrev.com/2302d2015a29612979ec1990f9dd8491a2b07f3e/third_party/WebKit/Source/platform/graphics/VideoFrameSubmitterTest.cpp
[modify] https://crrev.com/2302d2015a29612979ec1990f9dd8491a2b07f3e/third_party/WebKit/public/BUILD.gn
[modify] https://crrev.com/2302d2015a29612979ec1990f9dd8491a2b07f3e/third_party/WebKit/public/platform/WebSurfaceLayerBridge.h
[add] https://crrev.com/2302d2015a29612979ec1990f9dd8491a2b07f3e/third_party/WebKit/public/platform/WebVideoFrameSubmitter.h
[modify] https://crrev.com/2302d2015a29612979ec1990f9dd8491a2b07f3e/third_party/WebKit/public/web/WebFrameClient.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c60a5cfd2a5210d67d005e2f6ec2dfc120e38f84

commit c60a5cfd2a5210d67d005e2f6ec2dfc120e38f84
Author: CJ DiMeglio <lethalantidote@chromium.org>
Date: Wed Sep 27 20:08:41 2017

Allows WebMediaPlayerImpl to have direct access to ContextProvider.

This change is a follow up to a TODO that calls for direct access to the
ContextProvider after it has been moved to the gpu. 

Bug: 746182
Change-Id: Iad2e9e89e234724e4f9053b43ae74dfd66cfa901
Reviewed-on: https://chromium-review.googlesource.com/668029
Reviewed-by: Frank Liberato <liberato@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504760}
[modify] https://crrev.com/c60a5cfd2a5210d67d005e2f6ec2dfc120e38f84/content/renderer/media/media_factory.cc
[modify] https://crrev.com/c60a5cfd2a5210d67d005e2f6ec2dfc120e38f84/media/blink/DEPS
[modify] https://crrev.com/c60a5cfd2a5210d67d005e2f6ec2dfc120e38f84/media/blink/webmediaplayer_cast_android.cc
[modify] https://crrev.com/c60a5cfd2a5210d67d005e2f6ec2dfc120e38f84/media/blink/webmediaplayer_cast_android.h
[modify] https://crrev.com/c60a5cfd2a5210d67d005e2f6ec2dfc120e38f84/media/blink/webmediaplayer_impl.cc
[modify] https://crrev.com/c60a5cfd2a5210d67d005e2f6ec2dfc120e38f84/media/blink/webmediaplayer_impl.h
[modify] https://crrev.com/c60a5cfd2a5210d67d005e2f6ec2dfc120e38f84/media/blink/webmediaplayer_impl_unittest.cc
[modify] https://crrev.com/c60a5cfd2a5210d67d005e2f6ec2dfc120e38f84/media/blink/webmediaplayer_params.cc
[modify] https://crrev.com/c60a5cfd2a5210d67d005e2f6ec2dfc120e38f84/media/blink/webmediaplayer_params.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9afba51e790bb0eb3ee41cc0bc0b7739048f99f7

commit 9afba51e790bb0eb3ee41cc0bc0b7739048f99f7
Author: CJ DiMeglio <lethalantidote@chromium.org>
Date: Mon Oct 02 20:26:24 2017

Obtains media ContextProvider for use in VideoFrameResourceProvider.

This work is helpful in the cc::Surface for Videos work, as it allows
easier access to this ContextProvider when obtaining Resources.

Bug: 746182
Change-Id: Ie68c180a047abd36885ac5a6f70bd13b0e92af43
Reviewed-on: https://chromium-review.googlesource.com/671200
Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: enne <enne@chromium.org>
Reviewed-by: Dimitri Glazkov <dglazkov@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505757}
[modify] https://crrev.com/9afba51e790bb0eb3ee41cc0bc0b7739048f99f7/content/renderer/media/gpu/gpu_video_accelerator_factories_impl.cc
[modify] https://crrev.com/9afba51e790bb0eb3ee41cc0bc0b7739048f99f7/content/renderer/media/gpu/gpu_video_accelerator_factories_impl.h
[modify] https://crrev.com/9afba51e790bb0eb3ee41cc0bc0b7739048f99f7/content/renderer/media/media_factory.cc
[modify] https://crrev.com/9afba51e790bb0eb3ee41cc0bc0b7739048f99f7/media/blink/video_frame_compositor.cc
[modify] https://crrev.com/9afba51e790bb0eb3ee41cc0bc0b7739048f99f7/media/blink/video_frame_compositor.h
[modify] https://crrev.com/9afba51e790bb0eb3ee41cc0bc0b7739048f99f7/media/blink/video_frame_compositor_unittest.cc
[modify] https://crrev.com/9afba51e790bb0eb3ee41cc0bc0b7739048f99f7/media/blink/webmediaplayer_impl.cc
[modify] https://crrev.com/9afba51e790bb0eb3ee41cc0bc0b7739048f99f7/media/blink/webmediaplayer_impl_unittest.cc
[modify] https://crrev.com/9afba51e790bb0eb3ee41cc0bc0b7739048f99f7/media/blink/webmediaplayer_params.cc
[modify] https://crrev.com/9afba51e790bb0eb3ee41cc0bc0b7739048f99f7/media/blink/webmediaplayer_params.h
[modify] https://crrev.com/9afba51e790bb0eb3ee41cc0bc0b7739048f99f7/media/video/gpu_video_accelerator_factories.h
[modify] https://crrev.com/9afba51e790bb0eb3ee41cc0bc0b7739048f99f7/media/video/mock_gpu_video_accelerator_factories.h
[modify] https://crrev.com/9afba51e790bb0eb3ee41cc0bc0b7739048f99f7/third_party/WebKit/Source/platform/exported/WebVideoFrameSubmitter.cpp
[modify] https://crrev.com/9afba51e790bb0eb3ee41cc0bc0b7739048f99f7/third_party/WebKit/Source/platform/graphics/VideoFrameResourceProvider.cpp
[modify] https://crrev.com/9afba51e790bb0eb3ee41cc0bc0b7739048f99f7/third_party/WebKit/Source/platform/graphics/VideoFrameResourceProvider.h
[modify] https://crrev.com/9afba51e790bb0eb3ee41cc0bc0b7739048f99f7/third_party/WebKit/Source/platform/graphics/VideoFrameSubmitter.cpp
[modify] https://crrev.com/9afba51e790bb0eb3ee41cc0bc0b7739048f99f7/third_party/WebKit/Source/platform/graphics/VideoFrameSubmitter.h
[modify] https://crrev.com/9afba51e790bb0eb3ee41cc0bc0b7739048f99f7/third_party/WebKit/Source/platform/graphics/VideoFrameSubmitterTest.cpp
[modify] https://crrev.com/9afba51e790bb0eb3ee41cc0bc0b7739048f99f7/third_party/WebKit/public/platform/WebVideoFrameSubmitter.h

Is there any DD or rationale to justify this bug? Haven't found
it here nor in the Blocked-on bug 726219.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d7ac677338da078b9d5815cd94b1a0b474fb2abf

commit d7ac677338da078b9d5815cd94b1a0b474fb2abf
Author: CJ DiMeglio <lethalantidote@chromium.org>
Date: Fri Nov 10 00:19:06 2017

Prepares to properly AppendQuads and cleans up tests.

This CL is a preparatory CL that gathers up the required parameters for obtaining resources for
video frames (viz::SharedBitmapManager*, gpu::GpuMemoryBufferManager*).

Along with this intent, it accomplishes a few other things:

- Moves creation of VideoFrameCompositor and VideoFrameSubmitter into MediaFactory for ease of
testing and moves the use of flags higher up into the code.

- Along with this, we now pass the VideoFrameCompositor a WebVideoFrameSubmitter, which also helps
with testing.

- WebMediaPlayerImpl_unittest has been simplified, using a MockVideoFrameCompositor to narrow down
the scope of testing (before this unittest acted more like an integration test).

- Splits SubmitFrame into SubmitFrameInternal, controlling access to the
VideoFrameProvider in situations where we can't be sure it isn't null. The rest of SubmitFrame is
inlined in OnBeginFrame.

Bug: 746182
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I40ff88f37be8db91aef89284e8351610ad83f043
Reviewed-on: https://chromium-review.googlesource.com/717263
Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org>
Reviewed-by: Dimitri Glazkov <dglazkov@chromium.org>
Reviewed-by: Frank Liberato <liberato@chromium.org>
Reviewed-by: Yuri Wiitala <miu@chromium.org>
Reviewed-by: enne <enne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515363}
[modify] https://crrev.com/d7ac677338da078b9d5815cd94b1a0b474fb2abf/content/renderer/media/media_factory.cc
[modify] https://crrev.com/d7ac677338da078b9d5815cd94b1a0b474fb2abf/media/blink/DEPS
[modify] https://crrev.com/d7ac677338da078b9d5815cd94b1a0b474fb2abf/media/blink/video_frame_compositor.cc
[modify] https://crrev.com/d7ac677338da078b9d5815cd94b1a0b474fb2abf/media/blink/video_frame_compositor.h
[modify] https://crrev.com/d7ac677338da078b9d5815cd94b1a0b474fb2abf/media/blink/video_frame_compositor_unittest.cc
[modify] https://crrev.com/d7ac677338da078b9d5815cd94b1a0b474fb2abf/media/blink/webmediaplayer_impl.cc
[modify] https://crrev.com/d7ac677338da078b9d5815cd94b1a0b474fb2abf/media/blink/webmediaplayer_impl.h
[modify] https://crrev.com/d7ac677338da078b9d5815cd94b1a0b474fb2abf/media/blink/webmediaplayer_impl_unittest.cc
[modify] https://crrev.com/d7ac677338da078b9d5815cd94b1a0b474fb2abf/media/blink/webmediaplayer_params.cc
[modify] https://crrev.com/d7ac677338da078b9d5815cd94b1a0b474fb2abf/media/blink/webmediaplayer_params.h
[modify] https://crrev.com/d7ac677338da078b9d5815cd94b1a0b474fb2abf/third_party/WebKit/Source/platform/exported/WebVideoFrameSubmitter.cpp
[modify] https://crrev.com/d7ac677338da078b9d5815cd94b1a0b474fb2abf/third_party/WebKit/Source/platform/graphics/DEPS
[modify] https://crrev.com/d7ac677338da078b9d5815cd94b1a0b474fb2abf/third_party/WebKit/Source/platform/graphics/VideoFrameResourceProvider.cpp
[modify] https://crrev.com/d7ac677338da078b9d5815cd94b1a0b474fb2abf/third_party/WebKit/Source/platform/graphics/VideoFrameResourceProvider.h
[modify] https://crrev.com/d7ac677338da078b9d5815cd94b1a0b474fb2abf/third_party/WebKit/Source/platform/graphics/VideoFrameSubmitter.cpp
[modify] https://crrev.com/d7ac677338da078b9d5815cd94b1a0b474fb2abf/third_party/WebKit/Source/platform/graphics/VideoFrameSubmitter.h
[modify] https://crrev.com/d7ac677338da078b9d5815cd94b1a0b474fb2abf/third_party/WebKit/Source/platform/graphics/VideoFrameSubmitterTest.cpp
[modify] https://crrev.com/d7ac677338da078b9d5815cd94b1a0b474fb2abf/third_party/WebKit/public/platform/WebVideoFrameSubmitter.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/468b614addd7d1b53ae6f3c1759ca4a9989866c8

commit 468b614addd7d1b53ae6f3c1759ca4a9989866c8
Author: CJ DiMeglio <lethalantidote@chromium.org>
Date: Sat Nov 11 02:22:34 2017

Allows VideoFrameSubmitter to return resources.

The VideoFrameSubmitter will signal to the VideoFrameResourceProvider to
PrepareSendToCompositor resources. When the compositor is done with
these resources, they must be returned.

Bug: 746182
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I90ac8fded8eb74b7435cd7763e4fa1cf8e4a3a50
Reviewed-on: https://chromium-review.googlesource.com/723862
Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org>
Reviewed-by: enne <enne@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Reviewed-by: Frank Liberato <liberato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515801}
[modify] https://crrev.com/468b614addd7d1b53ae6f3c1759ca4a9989866c8/third_party/WebKit/Source/platform/graphics/VideoFrameResourceProvider.cpp
[modify] https://crrev.com/468b614addd7d1b53ae6f3c1759ca4a9989866c8/third_party/WebKit/Source/platform/graphics/VideoFrameResourceProvider.h
[modify] https://crrev.com/468b614addd7d1b53ae6f3c1759ca4a9989866c8/third_party/WebKit/Source/platform/graphics/VideoFrameSubmitter.cpp
[modify] https://crrev.com/468b614addd7d1b53ae6f3c1759ca4a9989866c8/third_party/WebKit/Source/platform/graphics/VideoFrameSubmitter.h
[modify] https://crrev.com/468b614addd7d1b53ae6f3c1759ca4a9989866c8/third_party/WebKit/Source/platform/graphics/VideoFrameSubmitterTest.cpp

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ffe2e04125aa98597913eed49b4f0bb863d06e25

commit ffe2e04125aa98597913eed49b4f0bb863d06e25
Author: CJ DiMeglio <lethalantidote@chromium.org>
Date: Wed Nov 15 21:58:53 2017

Takes locks appropriately to prevent crash.

Creation of the ResourceProvider and PrepareSendToParent now call functions that
require locking of the content_provider_. This CL updates VideoFrameResourceProvider
such that it now takes the appropriate locks.

Bug: 746182
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I82cb7c3b9f5ee6b1f46faeed6b04b64937141503
Reviewed-on: https://chromium-review.googlesource.com/772089
Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org>
Reviewed-by: Florin Malita <fmalita@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516843}
[modify] https://crrev.com/ffe2e04125aa98597913eed49b4f0bb863d06e25/third_party/WebKit/Source/platform/graphics/VideoFrameResourceProvider.cpp

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/013d4c479af75619664b102a1bc3d821f653406a

commit 013d4c479af75619664b102a1bc3d821f653406a
Author: CJ DiMeglio <lethalantidote@chromium.org>
Date: Tue Nov 21 03:27:30 2017

Stops double registering content in surfaces for video.

cc::Surfaces for Video path was crashing due to calling RegisterContentsLayer twice.
This fixes it by making sure that both observers of SurfaceLayerBridge handle calling
RegisterContentsLayer, making its use consistent.

Bug: 746182
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I2728c45a6cfa788ae9dc56101388f19ed51a05a5
Reviewed-on: https://chromium-review.googlesource.com/761765
Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Reviewed-by: Frank Liberato <liberato@chromium.org>
Reviewed-by: Olivia Lai <xlai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518080}
[modify] https://crrev.com/013d4c479af75619664b102a1bc3d821f653406a/media/blink/webmediaplayer_impl.cc
[modify] https://crrev.com/013d4c479af75619664b102a1bc3d821f653406a/media/blink/webmediaplayer_impl.h
[modify] https://crrev.com/013d4c479af75619664b102a1bc3d821f653406a/media/blink/webmediaplayer_impl_unittest.cc
[modify] https://crrev.com/013d4c479af75619664b102a1bc3d821f653406a/third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp
[modify] https://crrev.com/013d4c479af75619664b102a1bc3d821f653406a/third_party/WebKit/Source/core/html/HTMLCanvasElement.h
[modify] https://crrev.com/013d4c479af75619664b102a1bc3d821f653406a/third_party/WebKit/Source/platform/graphics/SurfaceLayerBridge.cpp
[modify] https://crrev.com/013d4c479af75619664b102a1bc3d821f653406a/third_party/WebKit/public/platform/WebSurfaceLayerBridge.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f3ca99e31d9dfad2a1c2c09e7cf76bf7f62b8ce6

commit f3ca99e31d9dfad2a1c2c09e7cf76bf7f62b8ce6
Author: CJ DiMeglio <lethalantidote@chromium.org>
Date: Wed Nov 22 23:12:01 2017

Obtains LayerTreeSettings for VideoFrameResourceProvider.

This CL fulfills two TODO's that required access to LayerTreeSettings
in VideoFrameResourceProvider. Previously we were just using dummy
values for prototyping, but this CL grabs the true values.

Bug: 746182
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I7d4c1b4c8acdb2f99785dac2d2b2c3198169e3c0
Reviewed-on: https://chromium-review.googlesource.com/784355
Reviewed-by: Rick Byers <rbyers@chromium.org>
Reviewed-by: enne <enne@chromium.org>
Reviewed-by: Frank Liberato <liberato@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518790}
[modify] https://crrev.com/f3ca99e31d9dfad2a1c2c09e7cf76bf7f62b8ce6/content/renderer/gpu/render_widget_compositor.h
[modify] https://crrev.com/f3ca99e31d9dfad2a1c2c09e7cf76bf7f62b8ce6/content/renderer/media/media_factory.cc
[modify] https://crrev.com/f3ca99e31d9dfad2a1c2c09e7cf76bf7f62b8ce6/content/renderer/media/media_factory.h
[modify] https://crrev.com/f3ca99e31d9dfad2a1c2c09e7cf76bf7f62b8ce6/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/f3ca99e31d9dfad2a1c2c09e7cf76bf7f62b8ce6/third_party/WebKit/Source/platform/exported/WebVideoFrameSubmitter.cpp
[modify] https://crrev.com/f3ca99e31d9dfad2a1c2c09e7cf76bf7f62b8ce6/third_party/WebKit/Source/platform/graphics/VideoFrameResourceProvider.cpp
[modify] https://crrev.com/f3ca99e31d9dfad2a1c2c09e7cf76bf7f62b8ce6/third_party/WebKit/Source/platform/graphics/VideoFrameResourceProvider.h
[modify] https://crrev.com/f3ca99e31d9dfad2a1c2c09e7cf76bf7f62b8ce6/third_party/WebKit/Source/platform/graphics/VideoFrameSubmitterTest.cpp
[modify] https://crrev.com/f3ca99e31d9dfad2a1c2c09e7cf76bf7f62b8ce6/third_party/WebKit/public/platform/WebVideoFrameSubmitter.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5cd222d752184dbff6815e70a53b85c347e48598

commit 5cd222d752184dbff6815e70a53b85c347e48598
Author: CJ DiMeglio <lethalantidote@chromium.org>
Date: Wed Nov 29 01:51:37 2017

Obtains ExternalResources for VideoFrameSubmitter.

The result of this CL should be that the frames submitted by the
VideoFrameSubmitter now have complete information and thus should show
up on the screen.

This CL accomplishes this mainly through a refactor of VideoLayerImpl
shared functions into VideoResourceUpdater, making them accessible to
VideoFrameSubmitter.

Bug: 746182
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I6cfe9d181e3cde4c13299c42df40ab73480a0587
Reviewed-on: https://chromium-review.googlesource.com/701917
Reviewed-by: enne <enne@chromium.org>
Reviewed-by: Frank Liberato <liberato@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519952}
[modify] https://crrev.com/5cd222d752184dbff6815e70a53b85c347e48598/cc/layers/video_layer_impl.cc
[modify] https://crrev.com/5cd222d752184dbff6815e70a53b85c347e48598/cc/layers/video_layer_impl.h
[modify] https://crrev.com/5cd222d752184dbff6815e70a53b85c347e48598/cc/resources/video_resource_updater.cc
[modify] https://crrev.com/5cd222d752184dbff6815e70a53b85c347e48598/cc/resources/video_resource_updater.h
[modify] https://crrev.com/5cd222d752184dbff6815e70a53b85c347e48598/cc/resources/video_resource_updater_unittest.cc
[modify] https://crrev.com/5cd222d752184dbff6815e70a53b85c347e48598/cc/test/fake_resource_provider.h
[modify] https://crrev.com/5cd222d752184dbff6815e70a53b85c347e48598/components/viz/service/display/renderer_pixeltest.cc
[modify] https://crrev.com/5cd222d752184dbff6815e70a53b85c347e48598/third_party/WebKit/Source/platform/graphics/VideoFrameResourceProvider.cpp
[modify] https://crrev.com/5cd222d752184dbff6815e70a53b85c347e48598/third_party/WebKit/Source/platform/graphics/VideoFrameResourceProvider.h
[modify] https://crrev.com/5cd222d752184dbff6815e70a53b85c347e48598/third_party/WebKit/Source/platform/graphics/VideoFrameSubmitter.cpp
[modify] https://crrev.com/5cd222d752184dbff6815e70a53b85c347e48598/third_party/WebKit/Source/platform/graphics/VideoFrameSubmitterTest.cpp

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7b4a199ffc3672ab584f24d8542fcaf260c5dc31

commit 7b4a199ffc3672ab584f24d8542fcaf260c5dc31
Author: CJ DiMeglio <lethalantidote@chromium.org>
Date: Thu Nov 30 01:26:50 2017

Adds about flag for cc::Surfaces for Videos.

This CL allows one to turn on cc::Surfaces for Videos using an about
flag.

Bug: 746182
Change-Id: Iaf02e16bd5c0168a9788a57e682ab21442d9d802
Reviewed-on: https://chromium-review.googlesource.com/798026
Reviewed-by: apacible <apacible@chromium.org>
Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520369}
[modify] https://crrev.com/7b4a199ffc3672ab584f24d8542fcaf260c5dc31/chrome/browser/about_flags.cc
[modify] https://crrev.com/7b4a199ffc3672ab584f24d8542fcaf260c5dc31/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/7b4a199ffc3672ab584f24d8542fcaf260c5dc31/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/7b4a199ffc3672ab584f24d8542fcaf260c5dc31/tools/metrics/histograms/enums.xml

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0eadbe3790c9fe78c3c392da409020a334cca7ac

commit 0eadbe3790c9fe78c3c392da409020a334cca7ac
Author: CJ Dimeglio <lethalantidote@chromium.org>
Date: Tue Mar 27 08:26:13 2018

Adds tracing events for VideoFrameSubmitter flow.

This CL adds tracing events for the cc::Surfaces for Video feature.
This allows the events to be readily viewed in chrome://tracing.

Bug: 746182
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Ibd2637027e4d781ca547991eaea0f3862dce4d81
Reviewed-on: https://chromium-review.googlesource.com/978512
Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546060}
[modify] https://crrev.com/0eadbe3790c9fe78c3c392da409020a334cca7ac/third_party/WebKit/Source/platform/graphics/VideoFrameResourceProvider.cpp
[modify] https://crrev.com/0eadbe3790c9fe78c3c392da409020a334cca7ac/third_party/WebKit/Source/platform/graphics/VideoFrameSubmitter.cpp

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fd7d3dd83a7b5bb09b39d0d90a222858b76600e7

commit fd7d3dd83a7b5bb09b39d0d90a222858b76600e7
Author: CJ DiMeglio <lethalantidote@chromium.org>
Date: Mon Apr 09 22:57:02 2018

Removes leftover placeholder comment.

Removes line in VideoFrameResourceProvider indicating that it is a
placeholder class. This is now incorrect, as it has been filled in.

Bug: 746182
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Id7be5af35c6ded2aca95e9721c33c961b171efc7
Reviewed-on: https://chromium-review.googlesource.com/1000524
Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549310}
[modify] https://crrev.com/fd7d3dd83a7b5bb09b39d0d90a222858b76600e7/third_party/blink/renderer/platform/graphics/video_frame_resource_provider.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a3155c40304cc3c6b567ed42da094297655c000b

commit a3155c40304cc3c6b567ed42da094297655c000b
Author: CJ DiMeglio <lethalantidote@chromium.org>
Date: Wed Jun 06 21:01:56 2018

Removes comment.

The comment refers to a field that does not exist.

Bug: 746182
Change-Id: I76586b938980f95e93a01386ea7bde7844d59f4d
Reviewed-on: https://chromium-review.googlesource.com/1087324
Reviewed-by: Frank Liberato <liberato@chromium.org>
Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565032}
[modify] https://crrev.com/a3155c40304cc3c6b567ed42da094297655c000b/media/blink/video_frame_compositor.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e6e258a17c67e59b03924353b6485f4e36ca612e

commit e6e258a17c67e59b03924353b6485f4e36ca612e
Author: CJ DiMeglio <lethalantidote@chromium.org>
Date: Fri Aug 10 21:41:57 2018

Adds use of SurfaceLayerBridge into WebMediaPlayerMS.

This CL allows for WebMediaPlayerMS to create a SurfaceLayerBridge and
interface with it in order to use a Surface for video playback.

Bug: 746182
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I39174499a7e659eeeef13a81f8f5679d5f73425a
Reviewed-on: https://chromium-review.googlesource.com/1087587
Reviewed-by: Frank Liberato <liberato@chromium.org>
Reviewed-by: Emircan Uysaler <emircan@chromium.org>
Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582346}
[modify] https://crrev.com/e6e258a17c67e59b03924353b6485f4e36ca612e/chrome/browser/about_flags.cc
[modify] https://crrev.com/e6e258a17c67e59b03924353b6485f4e36ca612e/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/e6e258a17c67e59b03924353b6485f4e36ca612e/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/e6e258a17c67e59b03924353b6485f4e36ca612e/content/renderer/media/media_factory.cc
[modify] https://crrev.com/e6e258a17c67e59b03924353b6485f4e36ca612e/content/renderer/media/media_factory.h
[modify] https://crrev.com/e6e258a17c67e59b03924353b6485f4e36ca612e/content/renderer/media/stream/webmediaplayer_ms.cc
[modify] https://crrev.com/e6e258a17c67e59b03924353b6485f4e36ca612e/content/renderer/media/stream/webmediaplayer_ms.h
[modify] https://crrev.com/e6e258a17c67e59b03924353b6485f4e36ca612e/content/renderer/media/stream/webmediaplayer_ms_compositor.h
[modify] https://crrev.com/e6e258a17c67e59b03924353b6485f4e36ca612e/content/renderer/media/stream/webmediaplayer_ms_unittest.cc
[modify] https://crrev.com/e6e258a17c67e59b03924353b6485f4e36ca612e/media/base/media_switches.cc
[modify] https://crrev.com/e6e258a17c67e59b03924353b6485f4e36ca612e/media/base/media_switches.h
[modify] https://crrev.com/e6e258a17c67e59b03924353b6485f4e36ca612e/media/blink/webmediaplayer_impl.h
[modify] https://crrev.com/e6e258a17c67e59b03924353b6485f4e36ca612e/media/blink/webmediaplayer_params.cc
[modify] https://crrev.com/e6e258a17c67e59b03924353b6485f4e36ca612e/media/blink/webmediaplayer_params.h
[modify] https://crrev.com/e6e258a17c67e59b03924353b6485f4e36ca612e/tools/metrics/histograms/enums.xml

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/39d513103fdbf8bfde46b4ae398b783d0053cebb

commit 39d513103fdbf8bfde46b4ae398b783d0053cebb
Author: CJ DiMeglio <lethalantidote@chromium.org>
Date: Thu Sep 13 21:26:40 2018

Gives WebMediaPlayerMSCompositor access to VideoFrameSubmitter.

This CL makes it so that WebMediaPlayerMSCompositor can make proper calls
to a VideoFrameSubmitter to use cc::Surfaces for video instead of the
video layer. With this CL, cc::Surface for Video now works end to end
with WebMediaPlayerMS.

Bug: 746182
Change-Id: I90e100ba06dc7570d6ab10d6dc3862681fe80552
Reviewed-on: https://chromium-review.googlesource.com/1090031
Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org>
Reviewed-by: Emircan Uysaler <emircan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591163}
[modify] https://crrev.com/39d513103fdbf8bfde46b4ae398b783d0053cebb/content/renderer/media/media_factory.cc
[modify] https://crrev.com/39d513103fdbf8bfde46b4ae398b783d0053cebb/content/renderer/media/media_factory.h
[modify] https://crrev.com/39d513103fdbf8bfde46b4ae398b783d0053cebb/content/renderer/media/stream/webmediaplayer_ms.cc
[modify] https://crrev.com/39d513103fdbf8bfde46b4ae398b783d0053cebb/content/renderer/media/stream/webmediaplayer_ms.h
[modify] https://crrev.com/39d513103fdbf8bfde46b4ae398b783d0053cebb/content/renderer/media/stream/webmediaplayer_ms_compositor.cc
[modify] https://crrev.com/39d513103fdbf8bfde46b4ae398b783d0053cebb/content/renderer/media/stream/webmediaplayer_ms_compositor.h
[modify] https://crrev.com/39d513103fdbf8bfde46b4ae398b783d0053cebb/content/renderer/media/stream/webmediaplayer_ms_unittest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a22026d9c0465e3cd8d0e9c985964ea8b69d41c1

commit a22026d9c0465e3cd8d0e9c985964ea8b69d41c1
Author: François Beaufort <beaufort.francois@gmail.com>
Date: Tue Sep 25 08:51:11 2018

Add Picture-in-Picture support for MediaStreams.

This CL makes sures Picture-in-Picture button is available for
MediaStreams videos and that Picture-in-Picture Web API works as well.

Note that Picture-in-Picture window won't show a play/pause button for
MediaStreams videos.

Bug: 746182
Change-Id: I197bbd1ac0bd44a1ee5354dd1670856d80e6f08d
Reviewed-on: https://chromium-review.googlesource.com/1196515
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: CJ DiMeglio <lethalantidote@chromium.org>
Commit-Queue: François Beaufort <beaufort.francois@gmail.com>
Cr-Commit-Position: refs/heads/master@{#593867}
[modify] https://crrev.com/a22026d9c0465e3cd8d0e9c985964ea8b69d41c1/chrome/browser/chromeos/arc/pip/arc_picture_in_picture_window_controller_impl.cc
[modify] https://crrev.com/a22026d9c0465e3cd8d0e9c985964ea8b69d41c1/chrome/browser/chromeos/arc/pip/arc_picture_in_picture_window_controller_impl.h
[modify] https://crrev.com/a22026d9c0465e3cd8d0e9c985964ea8b69d41c1/chrome/browser/picture_in_picture/picture_in_picture_window_controller_browsertest.cc
[modify] https://crrev.com/a22026d9c0465e3cd8d0e9c985964ea8b69d41c1/chrome/browser/ui/views/overlay/overlay_window_views.cc
[modify] https://crrev.com/a22026d9c0465e3cd8d0e9c985964ea8b69d41c1/chrome/browser/ui/views/overlay/overlay_window_views.h
[modify] https://crrev.com/a22026d9c0465e3cd8d0e9c985964ea8b69d41c1/content/browser/media/media_web_contents_observer.cc
[modify] https://crrev.com/a22026d9c0465e3cd8d0e9c985964ea8b69d41c1/content/browser/media/media_web_contents_observer.h
[modify] https://crrev.com/a22026d9c0465e3cd8d0e9c985964ea8b69d41c1/content/browser/picture_in_picture/picture_in_picture_window_controller_impl.cc
[modify] https://crrev.com/a22026d9c0465e3cd8d0e9c985964ea8b69d41c1/content/browser/picture_in_picture/picture_in_picture_window_controller_impl.h
[modify] https://crrev.com/a22026d9c0465e3cd8d0e9c985964ea8b69d41c1/content/browser/web_contents/web_contents_impl_unittest.cc
[modify] https://crrev.com/a22026d9c0465e3cd8d0e9c985964ea8b69d41c1/content/common/media/media_player_delegate_messages.h
[modify] https://crrev.com/a22026d9c0465e3cd8d0e9c985964ea8b69d41c1/content/public/browser/overlay_window.h
[modify] https://crrev.com/a22026d9c0465e3cd8d0e9c985964ea8b69d41c1/content/public/browser/picture_in_picture_window_controller.h
[modify] https://crrev.com/a22026d9c0465e3cd8d0e9c985964ea8b69d41c1/content/renderer/media/renderer_webmediaplayer_delegate.cc
[modify] https://crrev.com/a22026d9c0465e3cd8d0e9c985964ea8b69d41c1/content/renderer/media/renderer_webmediaplayer_delegate.h
[modify] https://crrev.com/a22026d9c0465e3cd8d0e9c985964ea8b69d41c1/content/renderer/media/stream/webmediaplayer_ms.cc
[modify] https://crrev.com/a22026d9c0465e3cd8d0e9c985964ea8b69d41c1/content/renderer/media/stream/webmediaplayer_ms_unittest.cc
[modify] https://crrev.com/a22026d9c0465e3cd8d0e9c985964ea8b69d41c1/content/shell/browser/layout_test/layout_test_content_browser_client.cc
[modify] https://crrev.com/a22026d9c0465e3cd8d0e9c985964ea8b69d41c1/media/blink/webmediaplayer_delegate.h
[modify] https://crrev.com/a22026d9c0465e3cd8d0e9c985964ea8b69d41c1/media/blink/webmediaplayer_impl.cc
[modify] https://crrev.com/a22026d9c0465e3cd8d0e9c985964ea8b69d41c1/media/blink/webmediaplayer_impl_unittest.cc
[modify] https://crrev.com/a22026d9c0465e3cd8d0e9c985964ea8b69d41c1/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/a22026d9c0465e3cd8d0e9c985964ea8b69d41c1/third_party/WebKit/LayoutTests/VirtualTestSuites
[add] https://crrev.com/a22026d9c0465e3cd8d0e9c985964ea8b69d41c1/third_party/WebKit/LayoutTests/media/picture-in-picture/detached-iframe.html
[add] https://crrev.com/a22026d9c0465e3cd8d0e9c985964ea8b69d41c1/third_party/WebKit/LayoutTests/media/picture-in-picture/mediastream.html
[delete] https://crrev.com/506506db8766d5c1e5e49d8fe085c741b100f038/third_party/WebKit/LayoutTests/media/picture-in-picture/request-picture-in-picture.html
[modify] https://crrev.com/a22026d9c0465e3cd8d0e9c985964ea8b69d41c1/third_party/blink/renderer/core/frame/picture_in_picture_controller.h
[modify] https://crrev.com/a22026d9c0465e3cd8d0e9c985964ea8b69d41c1/third_party/blink/renderer/modules/picture_in_picture/html_video_element_picture_in_picture.cc
[modify] https://crrev.com/a22026d9c0465e3cd8d0e9c985964ea8b69d41c1/third_party/blink/renderer/modules/picture_in_picture/picture_in_picture_controller_impl.cc

Please merge https://chromium-review.googlesource.com/1196515to M70.

This bug requires manual review: We are only 12 days from stable.
Please contact the milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Approving CL in #29 to M70. Confirmed, it's behind a flag. 

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3acd2385c4ed66bf3ef58a16df77d75a4ebaf0f5

commit 3acd2385c4ed66bf3ef58a16df77d75a4ebaf0f5
Author: CJ DiMeglio <lethalantidote@chromium.org>
Date: Sat Oct 13 06:27:43 2018

Removes EnableSurfaceLayerForVideoMS flag.

Because the conditions in which we turn on surfaces for videos have grown
more complicated, and because surfaces for MS (MediaStream) has pretty much been implemented,
it has been decided that special-casing MS videos was no longer required.

Bug: 746182
Change-Id: Ie79c56ba80707c9b3e102eba9bcc712e994065b2
Reviewed-on: https://chromium-review.googlesource.com/c/1250095
Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Emircan Uysaler <emircan@chromium.org>
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Frank Liberato <liberato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599492}
[modify] https://crrev.com/3acd2385c4ed66bf3ef58a16df77d75a4ebaf0f5/chrome/browser/about_flags.cc
[modify] https://crrev.com/3acd2385c4ed66bf3ef58a16df77d75a4ebaf0f5/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/3acd2385c4ed66bf3ef58a16df77d75a4ebaf0f5/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/3acd2385c4ed66bf3ef58a16df77d75a4ebaf0f5/chrome/browser/picture_in_picture/picture_in_picture_window_controller_browsertest.cc
[modify] https://crrev.com/3acd2385c4ed66bf3ef58a16df77d75a4ebaf0f5/content/browser/webrtc/webrtc_getusermedia_browsertest.cc
[modify] https://crrev.com/3acd2385c4ed66bf3ef58a16df77d75a4ebaf0f5/content/renderer/media/media_factory.cc
[modify] https://crrev.com/3acd2385c4ed66bf3ef58a16df77d75a4ebaf0f5/content/renderer/media/media_factory.h
[modify] https://crrev.com/3acd2385c4ed66bf3ef58a16df77d75a4ebaf0f5/content/renderer/media/stream/webmediaplayer_ms.cc
[modify] https://crrev.com/3acd2385c4ed66bf3ef58a16df77d75a4ebaf0f5/content/renderer/media/stream/webmediaplayer_ms.h
[modify] https://crrev.com/3acd2385c4ed66bf3ef58a16df77d75a4ebaf0f5/content/renderer/media/stream/webmediaplayer_ms_compositor.cc
[modify] https://crrev.com/3acd2385c4ed66bf3ef58a16df77d75a4ebaf0f5/content/renderer/media/stream/webmediaplayer_ms_compositor.h
[modify] https://crrev.com/3acd2385c4ed66bf3ef58a16df77d75a4ebaf0f5/content/renderer/media/stream/webmediaplayer_ms_unittest.cc
[modify] https://crrev.com/3acd2385c4ed66bf3ef58a16df77d75a4ebaf0f5/content/renderer/media_capture_from_element/html_video_element_capturer_source_unittest.cc
[modify] https://crrev.com/3acd2385c4ed66bf3ef58a16df77d75a4ebaf0f5/content/renderer/render_view_impl.cc
[modify] https://crrev.com/3acd2385c4ed66bf3ef58a16df77d75a4ebaf0f5/media/base/media_switches.cc
[modify] https://crrev.com/3acd2385c4ed66bf3ef58a16df77d75a4ebaf0f5/media/base/media_switches.h
[modify] https://crrev.com/3acd2385c4ed66bf3ef58a16df77d75a4ebaf0f5/media/blink/webmediaplayer_impl.cc
[modify] https://crrev.com/3acd2385c4ed66bf3ef58a16df77d75a4ebaf0f5/media/blink/webmediaplayer_impl.h
[modify] https://crrev.com/3acd2385c4ed66bf3ef58a16df77d75a4ebaf0f5/media/blink/webmediaplayer_impl_unittest.cc
[modify] https://crrev.com/3acd2385c4ed66bf3ef58a16df77d75a4ebaf0f5/media/blink/webmediaplayer_params.cc
[modify] https://crrev.com/3acd2385c4ed66bf3ef58a16df77d75a4ebaf0f5/media/blink/webmediaplayer_params.h
[modify] https://crrev.com/3acd2385c4ed66bf3ef58a16df77d75a4ebaf0f5/third_party/WebKit/LayoutTests/VirtualTestSuites
[modify] https://crrev.com/3acd2385c4ed66bf3ef58a16df77d75a4ebaf0f5/third_party/blink/public/platform/web_media_player.h
[modify] https://crrev.com/3acd2385c4ed66bf3ef58a16df77d75a4ebaf0f5/third_party/blink/renderer/core/frame/picture_in_picture_controller.h
[modify] https://crrev.com/3acd2385c4ed66bf3ef58a16df77d75a4ebaf0f5/third_party/blink/renderer/core/html/media/html_video_element.cc
[modify] https://crrev.com/3acd2385c4ed66bf3ef58a16df77d75a4ebaf0f5/third_party/blink/renderer/core/html/media/html_video_element.h
[modify] https://crrev.com/3acd2385c4ed66bf3ef58a16df77d75a4ebaf0f5/third_party/blink/renderer/core/page/context_menu_controller_test.cc
[modify] https://crrev.com/3acd2385c4ed66bf3ef58a16df77d75a4ebaf0f5/third_party/blink/renderer/modules/media_controls/media_controls_impl_test.cc
[modify] https://crrev.com/3acd2385c4ed66bf3ef58a16df77d75a4ebaf0f5/third_party/blink/renderer/modules/picture_in_picture/html_video_element_picture_in_picture.cc
[modify] https://crrev.com/3acd2385c4ed66bf3ef58a16df77d75a4ebaf0f5/third_party/blink/renderer/modules/picture_in_picture/picture_in_picture_controller_impl.cc
[modify] https://crrev.com/3acd2385c4ed66bf3ef58a16df77d75a4ebaf0f5/third_party/blink/renderer/platform/testing/empty_web_media_player.h
[modify] https://crrev.com/3acd2385c4ed66bf3ef58a16df77d75a4ebaf0f5/tools/metrics/histograms/enums.xml

Merge Request for https://chromium-review.googlesource.com/c/1250095

This bug requires manual review: DEPS changes referenced in bugdroid comments.
Please contact the milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6a13a053f9f1aa8f0fee27b9a61922833732e9c2

commit 6a13a053f9f1aa8f0fee27b9a61922833732e9c2
Author: Patti <patricialor@chromium.org>
Date: Mon Oct 15 01:37:49 2018

Revert "Removes EnableSurfaceLayerForVideoMS flag."

This reverts commit 3acd2385c4ed66bf3ef58a16df77d75a4ebaf0f5.

Reason for revert: This patch may be the culprit behind consistent failures in three bots - win-asan [23 out of the last 23 builds have failed], Win 7 Tests x64 (1) [48 out of the last 48 builds have failed], and Win7 Tests (1) [45 out of the last 45 builds have failed]. Reverting to try and fix.

Original change's description:
> Removes EnableSurfaceLayerForVideoMS flag.
> 
> Because the conditions in which we turn on surfaces for videos have grown
> more complicated, and because surfaces for MS (MediaStream) has pretty much been implemented,
> it has been decided that special-casing MS videos was no longer required.
> 
> Bug: 746182
> Change-Id: Ie79c56ba80707c9b3e102eba9bcc712e994065b2
> Reviewed-on: https://chromium-review.googlesource.com/c/1250095
> Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org>
> Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
> Reviewed-by: Emircan Uysaler <emircan@chromium.org>
> Reviewed-by: Fady Samuel <fsamuel@chromium.org>
> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
> Reviewed-by: Frank Liberato <liberato@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#599492}

TBR=beaufort.francois@gmail.com,chrishtr@chromium.org,fsamuel@chromium.org,mlamouri@chromium.org,emircan@chromium.org,liberato@chromium.org,lethalantidote@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 746182
Change-Id: I251dae1ff54c43d16e91108a741507a33523a475
Reviewed-on: https://chromium-review.googlesource.com/c/1277800
Reviewed-by: Patti <patricialor@chromium.org>
Commit-Queue: Patti <patricialor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599552}
[modify] https://crrev.com/6a13a053f9f1aa8f0fee27b9a61922833732e9c2/chrome/browser/about_flags.cc
[modify] https://crrev.com/6a13a053f9f1aa8f0fee27b9a61922833732e9c2/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/6a13a053f9f1aa8f0fee27b9a61922833732e9c2/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/6a13a053f9f1aa8f0fee27b9a61922833732e9c2/chrome/browser/picture_in_picture/picture_in_picture_window_controller_browsertest.cc
[modify] https://crrev.com/6a13a053f9f1aa8f0fee27b9a61922833732e9c2/content/browser/webrtc/webrtc_getusermedia_browsertest.cc
[modify] https://crrev.com/6a13a053f9f1aa8f0fee27b9a61922833732e9c2/content/renderer/media/media_factory.cc
[modify] https://crrev.com/6a13a053f9f1aa8f0fee27b9a61922833732e9c2/content/renderer/media/media_factory.h
[modify] https://crrev.com/6a13a053f9f1aa8f0fee27b9a61922833732e9c2/content/renderer/media/stream/webmediaplayer_ms.cc
[modify] https://crrev.com/6a13a053f9f1aa8f0fee27b9a61922833732e9c2/content/renderer/media/stream/webmediaplayer_ms.h
[modify] https://crrev.com/6a13a053f9f1aa8f0fee27b9a61922833732e9c2/content/renderer/media/stream/webmediaplayer_ms_compositor.cc
[modify] https://crrev.com/6a13a053f9f1aa8f0fee27b9a61922833732e9c2/content/renderer/media/stream/webmediaplayer_ms_compositor.h
[modify] https://crrev.com/6a13a053f9f1aa8f0fee27b9a61922833732e9c2/content/renderer/media/stream/webmediaplayer_ms_unittest.cc
[modify] https://crrev.com/6a13a053f9f1aa8f0fee27b9a61922833732e9c2/content/renderer/media_capture_from_element/html_video_element_capturer_source_unittest.cc
[modify] https://crrev.com/6a13a053f9f1aa8f0fee27b9a61922833732e9c2/content/renderer/render_view_impl.cc
[modify] https://crrev.com/6a13a053f9f1aa8f0fee27b9a61922833732e9c2/media/base/media_switches.cc
[modify] https://crrev.com/6a13a053f9f1aa8f0fee27b9a61922833732e9c2/media/base/media_switches.h
[modify] https://crrev.com/6a13a053f9f1aa8f0fee27b9a61922833732e9c2/media/blink/webmediaplayer_impl.cc
[modify] https://crrev.com/6a13a053f9f1aa8f0fee27b9a61922833732e9c2/media/blink/webmediaplayer_impl.h
[modify] https://crrev.com/6a13a053f9f1aa8f0fee27b9a61922833732e9c2/media/blink/webmediaplayer_impl_unittest.cc
[modify] https://crrev.com/6a13a053f9f1aa8f0fee27b9a61922833732e9c2/media/blink/webmediaplayer_params.cc
[modify] https://crrev.com/6a13a053f9f1aa8f0fee27b9a61922833732e9c2/media/blink/webmediaplayer_params.h
[modify] https://crrev.com/6a13a053f9f1aa8f0fee27b9a61922833732e9c2/third_party/WebKit/LayoutTests/VirtualTestSuites
[modify] https://crrev.com/6a13a053f9f1aa8f0fee27b9a61922833732e9c2/third_party/blink/public/platform/web_media_player.h
[modify] https://crrev.com/6a13a053f9f1aa8f0fee27b9a61922833732e9c2/third_party/blink/renderer/core/frame/picture_in_picture_controller.h
[modify] https://crrev.com/6a13a053f9f1aa8f0fee27b9a61922833732e9c2/third_party/blink/renderer/core/html/media/html_video_element.cc
[modify] https://crrev.com/6a13a053f9f1aa8f0fee27b9a61922833732e9c2/third_party/blink/renderer/core/html/media/html_video_element.h
[modify] https://crrev.com/6a13a053f9f1aa8f0fee27b9a61922833732e9c2/third_party/blink/renderer/core/page/context_menu_controller_test.cc
[modify] https://crrev.com/6a13a053f9f1aa8f0fee27b9a61922833732e9c2/third_party/blink/renderer/modules/media_controls/media_controls_impl_test.cc
[modify] https://crrev.com/6a13a053f9f1aa8f0fee27b9a61922833732e9c2/third_party/blink/renderer/modules/picture_in_picture/html_video_element_picture_in_picture.cc
[modify] https://crrev.com/6a13a053f9f1aa8f0fee27b9a61922833732e9c2/third_party/blink/renderer/modules/picture_in_picture/picture_in_picture_controller_impl.cc
[modify] https://crrev.com/6a13a053f9f1aa8f0fee27b9a61922833732e9c2/third_party/blink/renderer/platform/testing/empty_web_media_player.h
[modify] https://crrev.com/6a13a053f9f1aa8f0fee27b9a61922833732e9c2/tools/metrics/histograms/enums.xml

Please use individual bugs to request merges for specific CLs. This is really confusing to track what has been merged to which branch, and which CL. 

Can you please confirm what has been merged in m70?

Still seeing browser test failure on Win clang and Win64 clang on official desktop builder.

failures:
WebRtcGetUserMediaBrowserTest.TestGetUserMediaAspectRatio4To3/0
WebRtcGetUserMediaBrowserTest.TestGetUserMediaAspectRatio4To3/1
WebRtcGetUserMediaBrowserTest.TestGetUserMediaAspectRatio1To1/1
WebRtcGetUserMediaBrowserTest.TestGetUserMediaAspectRatio1To1/0

Link to the builder:
-------------------
https://uberchromegw.corp.google.com/i/official.desktop/builders/win-clang/builds/1569
https://uberchromegw.corp.google.com/i/official.desktop/builders/win64-clang/builds/1565

As per C#35 seems issue got fixed & CL reverted as per C#38.But today's Canary(72.0.3581.0) seems not available in the below CL.
https://chromium.googlesource.com/chromium/src/+log/72.0.3580.0..72.0.3581.0?pretty=fuller&n=10000

Will verify the same on tomorrow's Canary and update the issue.
Thanks..!

Per comment #36, M71 merge request is for  https://chromium-review.googlesource.com/c/1250095.  Could you pls confirm this and provide merge justification?

Yes it is for https://chromium-review.googlesource.com/c/1250095. We want to have the surface layer feature for media streams under the same flag as non media streams for M71

How many more changes can we expect for this until bug is marked fixed or feature is considered launched?

There's at least 3 more CL's in the pipeline related to MediaStreams. I am not sure about the state of the regressions, but I think that there's a couple left. Until the regressions are solved, as I understand it, the feature will only be turned on for PiP.

OK Approving this for M71. However, please don't use this same bug for future merge requests. New specific bug highlighting specifically what is launching or being fixed should be highlighted in the bug. It's extremely confusing to see what has landed when and where from this bug. 

What has landed in M70 for this? 

Pls merge you change https://chromium-review.googlesource.com/c/1250095 to M71 branch 3578 ASAP so we can pick it up for this week M71 dev release. Thank you.

Pls merge your change to M71 branch 3578 before 1:00 PM PT today, 10/16 so we can pick it up for tomorrow's M71 Dev release. Thank you.

The change was reverted, I have to do more research into this and will not be able to make the deadline. 

Rejecting merge to M71 based on comment #48. Pls re request a merge to M71 when ready and safe. 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/892404731a96d57c5162ae52a0fe978ecff80fbf

commit 892404731a96d57c5162ae52a0fe978ecff80fbf
Author: CJ DiMeglio <lethalantidote@chromium.org>
Date: Thu Oct 18 18:21:10 2018

Reland "Removes EnableSurfaceLayerForVideoMS flag."

This is a reland of 3acd2385c4ed66bf3ef58a16df77d75a4ebaf0f5

Original change's description:
> Removes EnableSurfaceLayerForVideoMS flag.
>
> Because the conditions in which we turn on surfaces for videos have grown
> more complicated, and because surfaces for MS (MediaStream) has pretty much been implemented,
> it has been decided that special-casing MS videos was no longer required.
>
> Bug: 746182
> Change-Id: Ie79c56ba80707c9b3e102eba9bcc712e994065b2
> Reviewed-on: https://chromium-review.googlesource.com/c/1250095
> Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org>
> Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
> Reviewed-by: Emircan Uysaler <emircan@chromium.org>
> Reviewed-by: Fady Samuel <fsamuel@chromium.org>
> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
> Reviewed-by: Frank Liberato <liberato@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#599492}

TBR=beaufort.francois@gmail.com,chrishtr@chromium.org,fsamuel@chromium.org,mlamouri@chromium.org,emircan@chromium.org,liberato@chromium.org

Bug: 746182
Change-Id: Ic55d683279bf7cc01b8cc57b560ba22a8cb055f6
Reviewed-on: https://chromium-review.googlesource.com/c/1284434
Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org>
Reviewed-by: CJ DiMeglio <lethalantidote@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600832}
[modify] https://crrev.com/892404731a96d57c5162ae52a0fe978ecff80fbf/chrome/browser/about_flags.cc
[modify] https://crrev.com/892404731a96d57c5162ae52a0fe978ecff80fbf/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/892404731a96d57c5162ae52a0fe978ecff80fbf/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/892404731a96d57c5162ae52a0fe978ecff80fbf/chrome/browser/picture_in_picture/picture_in_picture_window_controller_browsertest.cc
[modify] https://crrev.com/892404731a96d57c5162ae52a0fe978ecff80fbf/content/renderer/media/media_factory.cc
[modify] https://crrev.com/892404731a96d57c5162ae52a0fe978ecff80fbf/content/renderer/media/media_factory.h
[modify] https://crrev.com/892404731a96d57c5162ae52a0fe978ecff80fbf/content/renderer/media/stream/webmediaplayer_ms.cc
[modify] https://crrev.com/892404731a96d57c5162ae52a0fe978ecff80fbf/content/renderer/media/stream/webmediaplayer_ms.h
[modify] https://crrev.com/892404731a96d57c5162ae52a0fe978ecff80fbf/content/renderer/media/stream/webmediaplayer_ms_compositor.cc
[modify] https://crrev.com/892404731a96d57c5162ae52a0fe978ecff80fbf/content/renderer/media/stream/webmediaplayer_ms_compositor.h
[modify] https://crrev.com/892404731a96d57c5162ae52a0fe978ecff80fbf/content/renderer/media/stream/webmediaplayer_ms_unittest.cc
[modify] https://crrev.com/892404731a96d57c5162ae52a0fe978ecff80fbf/content/renderer/media_capture_from_element/html_video_element_capturer_source_unittest.cc
[modify] https://crrev.com/892404731a96d57c5162ae52a0fe978ecff80fbf/content/renderer/render_view_impl.cc
[modify] https://crrev.com/892404731a96d57c5162ae52a0fe978ecff80fbf/media/base/media_switches.cc
[modify] https://crrev.com/892404731a96d57c5162ae52a0fe978ecff80fbf/media/base/media_switches.h
[modify] https://crrev.com/892404731a96d57c5162ae52a0fe978ecff80fbf/media/blink/webmediaplayer_impl.cc
[modify] https://crrev.com/892404731a96d57c5162ae52a0fe978ecff80fbf/media/blink/webmediaplayer_impl.h
[modify] https://crrev.com/892404731a96d57c5162ae52a0fe978ecff80fbf/media/blink/webmediaplayer_impl_unittest.cc
[modify] https://crrev.com/892404731a96d57c5162ae52a0fe978ecff80fbf/media/blink/webmediaplayer_params.cc
[modify] https://crrev.com/892404731a96d57c5162ae52a0fe978ecff80fbf/media/blink/webmediaplayer_params.h
[modify] https://crrev.com/892404731a96d57c5162ae52a0fe978ecff80fbf/third_party/WebKit/LayoutTests/VirtualTestSuites
[modify] https://crrev.com/892404731a96d57c5162ae52a0fe978ecff80fbf/third_party/blink/public/platform/web_media_player.h
[modify] https://crrev.com/892404731a96d57c5162ae52a0fe978ecff80fbf/third_party/blink/renderer/core/frame/picture_in_picture_controller.h
[modify] https://crrev.com/892404731a96d57c5162ae52a0fe978ecff80fbf/third_party/blink/renderer/core/html/media/html_video_element.cc
[modify] https://crrev.com/892404731a96d57c5162ae52a0fe978ecff80fbf/third_party/blink/renderer/core/html/media/html_video_element.h
[modify] https://crrev.com/892404731a96d57c5162ae52a0fe978ecff80fbf/third_party/blink/renderer/core/page/context_menu_controller_test.cc
[modify] https://crrev.com/892404731a96d57c5162ae52a0fe978ecff80fbf/third_party/blink/renderer/modules/media_controls/media_controls_impl_test.cc
[modify] https://crrev.com/892404731a96d57c5162ae52a0fe978ecff80fbf/third_party/blink/renderer/modules/picture_in_picture/html_video_element_picture_in_picture.cc
[modify] https://crrev.com/892404731a96d57c5162ae52a0fe978ecff80fbf/third_party/blink/renderer/modules/picture_in_picture/picture_in_picture_controller_impl.cc
[modify] https://crrev.com/892404731a96d57c5162ae52a0fe978ecff80fbf/third_party/blink/renderer/platform/testing/empty_web_media_player.h
[modify] https://crrev.com/892404731a96d57c5162ae52a0fe978ecff80fbf/tools/metrics/histograms/enums.xml

71 Merge Request for https://chromium-review.googlesource.com/c/1250095

This bug requires manual review: Reverts referenced in bugdroid comments after merge request.
Please contact the milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

How safe and critical is this change (https://chromium-review.googlesource.com/c/1250095) to merge to M71?

This is pretty safe (we are turning off surfaces feature). This cl is critical as it will help allow picture-and-picture for media streams, a common use case.

Approving merge for (https://chromium-review.googlesource.com/c/1250095)

to M71 branch 3578 based on comment #54. Pls merge ASAP as we're cutting M71 beta RC soon today for desktop. Thank you.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d3dbf9d9d6f0d0bd6bd360e1e9f1020b8c784469

commit d3dbf9d9d6f0d0bd6bd360e1e9f1020b8c784469
Author: CJ DiMeglio <lethalantidote@chromium.org>
Date: Mon Oct 22 17:44:06 2018

Removes EnableSurfaceLayerForVideoMS flag.

Because the conditions in which we turn on surfaces for videos have grown
more complicated, and because surfaces for MS (MediaStream) has pretty much been implemented,
it has been decided that special-casing MS videos was no longer required.

Bug: 746182
Change-Id: Ie79c56ba80707c9b3e102eba9bcc712e994065b2
Reviewed-on: https://chromium-review.googlesource.com/c/1250095
Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Emircan Uysaler <emircan@chromium.org>
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Frank Liberato <liberato@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#599492}(cherry picked from commit 3acd2385c4ed66bf3ef58a16df77d75a4ebaf0f5)
Reviewed-on: https://chromium-review.googlesource.com/c/1294203
Reviewed-by: CJ DiMeglio <lethalantidote@chromium.org>
Cr-Commit-Position: refs/branch-heads/3578@{#224}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
[modify] https://crrev.com/d3dbf9d9d6f0d0bd6bd360e1e9f1020b8c784469/chrome/browser/about_flags.cc
[modify] https://crrev.com/d3dbf9d9d6f0d0bd6bd360e1e9f1020b8c784469/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/d3dbf9d9d6f0d0bd6bd360e1e9f1020b8c784469/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/d3dbf9d9d6f0d0bd6bd360e1e9f1020b8c784469/chrome/browser/picture_in_picture/picture_in_picture_window_controller_browsertest.cc
[modify] https://crrev.com/d3dbf9d9d6f0d0bd6bd360e1e9f1020b8c784469/content/browser/webrtc/webrtc_getusermedia_browsertest.cc
[modify] https://crrev.com/d3dbf9d9d6f0d0bd6bd360e1e9f1020b8c784469/content/renderer/media/media_factory.cc
[modify] https://crrev.com/d3dbf9d9d6f0d0bd6bd360e1e9f1020b8c784469/content/renderer/media/media_factory.h
[modify] https://crrev.com/d3dbf9d9d6f0d0bd6bd360e1e9f1020b8c784469/content/renderer/media/stream/webmediaplayer_ms.cc
[modify] https://crrev.com/d3dbf9d9d6f0d0bd6bd360e1e9f1020b8c784469/content/renderer/media/stream/webmediaplayer_ms.h
[modify] https://crrev.com/d3dbf9d9d6f0d0bd6bd360e1e9f1020b8c784469/content/renderer/media/stream/webmediaplayer_ms_compositor.cc
[modify] https://crrev.com/d3dbf9d9d6f0d0bd6bd360e1e9f1020b8c784469/content/renderer/media/stream/webmediaplayer_ms_compositor.h
[modify] https://crrev.com/d3dbf9d9d6f0d0bd6bd360e1e9f1020b8c784469/content/renderer/media/stream/webmediaplayer_ms_unittest.cc
[modify] https://crrev.com/d3dbf9d9d6f0d0bd6bd360e1e9f1020b8c784469/content/renderer/media_capture_from_element/html_video_element_capturer_source_unittest.cc
[modify] https://crrev.com/d3dbf9d9d6f0d0bd6bd360e1e9f1020b8c784469/content/renderer/render_view_impl.cc
[modify] https://crrev.com/d3dbf9d9d6f0d0bd6bd360e1e9f1020b8c784469/media/base/media_switches.cc
[modify] https://crrev.com/d3dbf9d9d6f0d0bd6bd360e1e9f1020b8c784469/media/base/media_switches.h
[modify] https://crrev.com/d3dbf9d9d6f0d0bd6bd360e1e9f1020b8c784469/media/blink/webmediaplayer_impl.cc
[modify] https://crrev.com/d3dbf9d9d6f0d0bd6bd360e1e9f1020b8c784469/media/blink/webmediaplayer_impl.h
[modify] https://crrev.com/d3dbf9d9d6f0d0bd6bd360e1e9f1020b8c784469/media/blink/webmediaplayer_impl_unittest.cc
[modify] https://crrev.com/d3dbf9d9d6f0d0bd6bd360e1e9f1020b8c784469/media/blink/webmediaplayer_params.cc
[modify] https://crrev.com/d3dbf9d9d6f0d0bd6bd360e1e9f1020b8c784469/media/blink/webmediaplayer_params.h
[modify] https://crrev.com/d3dbf9d9d6f0d0bd6bd360e1e9f1020b8c784469/third_party/WebKit/LayoutTests/VirtualTestSuites
[modify] https://crrev.com/d3dbf9d9d6f0d0bd6bd360e1e9f1020b8c784469/third_party/blink/public/platform/web_media_player.h
[modify] https://crrev.com/d3dbf9d9d6f0d0bd6bd360e1e9f1020b8c784469/third_party/blink/renderer/core/frame/picture_in_picture_controller.h
[modify] https://crrev.com/d3dbf9d9d6f0d0bd6bd360e1e9f1020b8c784469/third_party/blink/renderer/core/html/media/html_video_element.cc
[modify] https://crrev.com/d3dbf9d9d6f0d0bd6bd360e1e9f1020b8c784469/third_party/blink/renderer/core/html/media/html_video_element.h
[modify] https://crrev.com/d3dbf9d9d6f0d0bd6bd360e1e9f1020b8c784469/third_party/blink/renderer/core/page/context_menu_controller_test.cc
[modify] https://crrev.com/d3dbf9d9d6f0d0bd6bd360e1e9f1020b8c784469/third_party/blink/renderer/modules/media_controls/media_controls_impl_test.cc
[modify] https://crrev.com/d3dbf9d9d6f0d0bd6bd360e1e9f1020b8c784469/third_party/blink/renderer/modules/picture_in_picture/html_video_element_picture_in_picture.cc
[modify] https://crrev.com/d3dbf9d9d6f0d0bd6bd360e1e9f1020b8c784469/third_party/blink/renderer/modules/picture_in_picture/picture_in_picture_controller_impl.cc
[modify] https://crrev.com/d3dbf9d9d6f0d0bd6bd360e1e9f1020b8c784469/third_party/blink/renderer/platform/testing/empty_web_media_player.h
[modify] https://crrev.com/d3dbf9d9d6f0d0bd6bd360e1e9f1020b8c784469/tools/metrics/histograms/enums.xml

lethalantidote@, Pls revert cl listed at #56 from M71 branch ASAP per offline chat. Thank you.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fe5f36a89b7522bb6df5aea4ab68fcd93c822f70

commit fe5f36a89b7522bb6df5aea4ab68fcd93c822f70
Author: CJ DiMeglio <lethalantidote@chromium.org>
Date: Mon Oct 22 20:28:37 2018

Revert "Removes EnableSurfaceLayerForVideoMS flag."

This reverts commit d3dbf9d9d6f0d0bd6bd360e1e9f1020b8c784469.

Reason for revert: Should not have been merged.

Original change's description:
> Removes EnableSurfaceLayerForVideoMS flag.
> 
> Because the conditions in which we turn on surfaces for videos have grown
> more complicated, and because surfaces for MS (MediaStream) has pretty much been implemented,
> it has been decided that special-casing MS videos was no longer required.
> 
> Bug: 746182
> Change-Id: Ie79c56ba80707c9b3e102eba9bcc712e994065b2
> Reviewed-on: https://chromium-review.googlesource.com/c/1250095
> Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org>
> Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
> Reviewed-by: Emircan Uysaler <emircan@chromium.org>
> Reviewed-by: Fady Samuel <fsamuel@chromium.org>
> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
> Reviewed-by: Frank Liberato <liberato@chromium.org>
> Cr-Original-Commit-Position: refs/heads/master@{#599492}(cherry picked from commit 3acd2385c4ed66bf3ef58a16df77d75a4ebaf0f5)
> Reviewed-on: https://chromium-review.googlesource.com/c/1294203
> Reviewed-by: CJ DiMeglio <lethalantidote@chromium.org>
> Cr-Commit-Position: refs/branch-heads/3578@{#224}
> Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}

TBR=lethalantidote@chromium.org

Change-Id: I21efdbe1bbb0c1cf357de327042273f9d3a7b210
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 746182
Reviewed-on: https://chromium-review.googlesource.com/c/1294749
Reviewed-by: Frank Liberato <liberato@chromium.org>
Cr-Commit-Position: refs/branch-heads/3578@{#241}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
[modify] https://crrev.com/fe5f36a89b7522bb6df5aea4ab68fcd93c822f70/chrome/browser/about_flags.cc
[modify] https://crrev.com/fe5f36a89b7522bb6df5aea4ab68fcd93c822f70/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/fe5f36a89b7522bb6df5aea4ab68fcd93c822f70/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/fe5f36a89b7522bb6df5aea4ab68fcd93c822f70/chrome/browser/picture_in_picture/picture_in_picture_window_controller_browsertest.cc
[modify] https://crrev.com/fe5f36a89b7522bb6df5aea4ab68fcd93c822f70/content/browser/webrtc/webrtc_getusermedia_browsertest.cc
[modify] https://crrev.com/fe5f36a89b7522bb6df5aea4ab68fcd93c822f70/content/renderer/media/media_factory.cc
[modify] https://crrev.com/fe5f36a89b7522bb6df5aea4ab68fcd93c822f70/content/renderer/media/media_factory.h
[modify] https://crrev.com/fe5f36a89b7522bb6df5aea4ab68fcd93c822f70/content/renderer/media/stream/webmediaplayer_ms.cc
[modify] https://crrev.com/fe5f36a89b7522bb6df5aea4ab68fcd93c822f70/content/renderer/media/stream/webmediaplayer_ms.h
[modify] https://crrev.com/fe5f36a89b7522bb6df5aea4ab68fcd93c822f70/content/renderer/media/stream/webmediaplayer_ms_compositor.cc
[modify] https://crrev.com/fe5f36a89b7522bb6df5aea4ab68fcd93c822f70/content/renderer/media/stream/webmediaplayer_ms_compositor.h
[modify] https://crrev.com/fe5f36a89b7522bb6df5aea4ab68fcd93c822f70/content/renderer/media/stream/webmediaplayer_ms_unittest.cc
[modify] https://crrev.com/fe5f36a89b7522bb6df5aea4ab68fcd93c822f70/content/renderer/media_capture_from_element/html_video_element_capturer_source_unittest.cc
[modify] https://crrev.com/fe5f36a89b7522bb6df5aea4ab68fcd93c822f70/content/renderer/render_view_impl.cc
[modify] https://crrev.com/fe5f36a89b7522bb6df5aea4ab68fcd93c822f70/media/base/media_switches.cc
[modify] https://crrev.com/fe5f36a89b7522bb6df5aea4ab68fcd93c822f70/media/base/media_switches.h
[modify] https://crrev.com/fe5f36a89b7522bb6df5aea4ab68fcd93c822f70/media/blink/webmediaplayer_impl.cc
[modify] https://crrev.com/fe5f36a89b7522bb6df5aea4ab68fcd93c822f70/media/blink/webmediaplayer_impl.h
[modify] https://crrev.com/fe5f36a89b7522bb6df5aea4ab68fcd93c822f70/media/blink/webmediaplayer_impl_unittest.cc
[modify] https://crrev.com/fe5f36a89b7522bb6df5aea4ab68fcd93c822f70/media/blink/webmediaplayer_params.cc
[modify] https://crrev.com/fe5f36a89b7522bb6df5aea4ab68fcd93c822f70/media/blink/webmediaplayer_params.h
[modify] https://crrev.com/fe5f36a89b7522bb6df5aea4ab68fcd93c822f70/third_party/WebKit/LayoutTests/VirtualTestSuites
[modify] https://crrev.com/fe5f36a89b7522bb6df5aea4ab68fcd93c822f70/third_party/blink/public/platform/web_media_player.h
[modify] https://crrev.com/fe5f36a89b7522bb6df5aea4ab68fcd93c822f70/third_party/blink/renderer/core/frame/picture_in_picture_controller.h
[modify] https://crrev.com/fe5f36a89b7522bb6df5aea4ab68fcd93c822f70/third_party/blink/renderer/core/html/media/html_video_element.cc
[modify] https://crrev.com/fe5f36a89b7522bb6df5aea4ab68fcd93c822f70/third_party/blink/renderer/core/html/media/html_video_element.h
[modify] https://crrev.com/fe5f36a89b7522bb6df5aea4ab68fcd93c822f70/third_party/blink/renderer/core/page/context_menu_controller_test.cc
[modify] https://crrev.com/fe5f36a89b7522bb6df5aea4ab68fcd93c822f70/third_party/blink/renderer/modules/media_controls/media_controls_impl_test.cc
[modify] https://crrev.com/fe5f36a89b7522bb6df5aea4ab68fcd93c822f70/third_party/blink/renderer/modules/picture_in_picture/html_video_element_picture_in_picture.cc
[modify] https://crrev.com/fe5f36a89b7522bb6df5aea4ab68fcd93c822f70/third_party/blink/renderer/modules/picture_in_picture/picture_in_picture_controller_impl.cc
[modify] https://crrev.com/fe5f36a89b7522bb6df5aea4ab68fcd93c822f70/third_party/blink/renderer/platform/testing/empty_web_media_player.h
[modify] https://crrev.com/fe5f36a89b7522bb6df5aea4ab68fcd93c822f70/tools/metrics/histograms/enums.xml

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c211d9b5dffde7802391bb3356ebf124e8206689

commit c211d9b5dffde7802391bb3356ebf124e8206689
Author: CJ DiMeglio <lethalantidote@chromium.org>
Date: Mon Oct 22 20:46:42 2018

Reland "Removes EnableSurfaceLayerForVideoMS flag."

This is a reland of 3acd2385c4ed66bf3ef58a16df77d75a4ebaf0f5

Original change's description:
> Removes EnableSurfaceLayerForVideoMS flag.
>
> Because the conditions in which we turn on surfaces for videos have grown
> more complicated, and because surfaces for MS (MediaStream) has pretty much been implemented,
> it has been decided that special-casing MS videos was no longer required.
>
> Bug: 746182
> Change-Id: Ie79c56ba80707c9b3e102eba9bcc712e994065b2
> Reviewed-on: https://chromium-review.googlesource.com/c/1250095
> Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org>
> Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
> Reviewed-by: Emircan Uysaler <emircan@chromium.org>
> Reviewed-by: Fady Samuel <fsamuel@chromium.org>
> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
> Reviewed-by: Frank Liberato <liberato@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#599492}

TBR=beaufort.francois@gmail.com,chrishtr@chromium.org,fsamuel@chromium.org,mlamouri@chromium.org,emircan@chromium.org,liberato@chromium.org

Bug: 746182
Change-Id: Ic55d683279bf7cc01b8cc57b560ba22a8cb055f6
Reviewed-on: https://chromium-review.googlesource.com/c/1284434
Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org>
Reviewed-by: CJ DiMeglio <lethalantidote@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#600832}(cherry picked from commit 892404731a96d57c5162ae52a0fe978ecff80fbf)
Reviewed-on: https://chromium-review.googlesource.com/c/1294694
Cr-Commit-Position: refs/branch-heads/3578@{#245}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
[modify] https://crrev.com/c211d9b5dffde7802391bb3356ebf124e8206689/chrome/browser/about_flags.cc
[modify] https://crrev.com/c211d9b5dffde7802391bb3356ebf124e8206689/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/c211d9b5dffde7802391bb3356ebf124e8206689/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/c211d9b5dffde7802391bb3356ebf124e8206689/chrome/browser/picture_in_picture/picture_in_picture_window_controller_browsertest.cc
[modify] https://crrev.com/c211d9b5dffde7802391bb3356ebf124e8206689/content/renderer/media/media_factory.cc
[modify] https://crrev.com/c211d9b5dffde7802391bb3356ebf124e8206689/content/renderer/media/media_factory.h
[modify] https://crrev.com/c211d9b5dffde7802391bb3356ebf124e8206689/content/renderer/media/stream/webmediaplayer_ms.cc
[modify] https://crrev.com/c211d9b5dffde7802391bb3356ebf124e8206689/content/renderer/media/stream/webmediaplayer_ms.h
[modify] https://crrev.com/c211d9b5dffde7802391bb3356ebf124e8206689/content/renderer/media/stream/webmediaplayer_ms_compositor.cc
[modify] https://crrev.com/c211d9b5dffde7802391bb3356ebf124e8206689/content/renderer/media/stream/webmediaplayer_ms_compositor.h
[modify] https://crrev.com/c211d9b5dffde7802391bb3356ebf124e8206689/content/renderer/media/stream/webmediaplayer_ms_unittest.cc
[modify] https://crrev.com/c211d9b5dffde7802391bb3356ebf124e8206689/content/renderer/media_capture_from_element/html_video_element_capturer_source_unittest.cc
[modify] https://crrev.com/c211d9b5dffde7802391bb3356ebf124e8206689/content/renderer/render_view_impl.cc
[modify] https://crrev.com/c211d9b5dffde7802391bb3356ebf124e8206689/media/base/media_switches.cc
[modify] https://crrev.com/c211d9b5dffde7802391bb3356ebf124e8206689/media/base/media_switches.h
[modify] https://crrev.com/c211d9b5dffde7802391bb3356ebf124e8206689/media/blink/webmediaplayer_impl.cc
[modify] https://crrev.com/c211d9b5dffde7802391bb3356ebf124e8206689/media/blink/webmediaplayer_impl.h
[modify] https://crrev.com/c211d9b5dffde7802391bb3356ebf124e8206689/media/blink/webmediaplayer_impl_unittest.cc
[modify] https://crrev.com/c211d9b5dffde7802391bb3356ebf124e8206689/media/blink/webmediaplayer_params.cc
[modify] https://crrev.com/c211d9b5dffde7802391bb3356ebf124e8206689/media/blink/webmediaplayer_params.h
[modify] https://crrev.com/c211d9b5dffde7802391bb3356ebf124e8206689/third_party/WebKit/LayoutTests/VirtualTestSuites
[modify] https://crrev.com/c211d9b5dffde7802391bb3356ebf124e8206689/third_party/blink/public/platform/web_media_player.h
[modify] https://crrev.com/c211d9b5dffde7802391bb3356ebf124e8206689/third_party/blink/renderer/core/frame/picture_in_picture_controller.h
[modify] https://crrev.com/c211d9b5dffde7802391bb3356ebf124e8206689/third_party/blink/renderer/core/html/media/html_video_element.cc
[modify] https://crrev.com/c211d9b5dffde7802391bb3356ebf124e8206689/third_party/blink/renderer/core/html/media/html_video_element.h
[modify] https://crrev.com/c211d9b5dffde7802391bb3356ebf124e8206689/third_party/blink/renderer/core/page/context_menu_controller_test.cc
[modify] https://crrev.com/c211d9b5dffde7802391bb3356ebf124e8206689/third_party/blink/renderer/modules/media_controls/media_controls_impl_test.cc
[modify] https://crrev.com/c211d9b5dffde7802391bb3356ebf124e8206689/third_party/blink/renderer/modules/picture_in_picture/html_video_element_picture_in_picture.cc
[modify] https://crrev.com/c211d9b5dffde7802391bb3356ebf124e8206689/third_party/blink/renderer/modules/picture_in_picture/picture_in_picture_controller_impl.cc
[modify] https://crrev.com/c211d9b5dffde7802391bb3356ebf124e8206689/third_party/blink/renderer/platform/testing/empty_web_media_player.h
[modify] https://crrev.com/c211d9b5dffde7802391bb3356ebf124e8206689/tools/metrics/histograms/enums.xml

The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/c211d9b5dffde7802391bb3356ebf124e8206689

Commit: c211d9b5dffde7802391bb3356ebf124e8206689
Author: lethalantidote@chromium.org
Commiter: lethalantidote@chromium.org
Date: 2018-10-22 20:46:42 +0000 UTC

Reland "Removes EnableSurfaceLayerForVideoMS flag."

This is a reland of 3acd2385c4ed66bf3ef58a16df77d75a4ebaf0f5

Original change's description:
> Removes EnableSurfaceLayerForVideoMS flag.
>
> Because the conditions in which we turn on surfaces for videos have grown
> more complicated, and because surfaces for MS (MediaStream) has pretty much been implemented,
> it has been decided that special-casing MS videos was no longer required.
>
> Bug: 746182
> Change-Id: Ie79c56ba80707c9b3e102eba9bcc712e994065b2
> Reviewed-on: https://chromium-review.googlesource.com/c/1250095
> Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org>
> Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
> Reviewed-by: Emircan Uysaler <emircan@chromium.org>
> Reviewed-by: Fady Samuel <fsamuel@chromium.org>
> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
> Reviewed-by: Frank Liberato <liberato@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#599492}

TBR=beaufort.francois@gmail.com,chrishtr@chromium.org,fsamuel@chromium.org,mlamouri@chromium.org,emircan@chromium.org,liberato@chromium.org

Bug: 746182
Change-Id: Ic55d683279bf7cc01b8cc57b560ba22a8cb055f6
Reviewed-on: https://chromium-review.googlesource.com/c/1284434
Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org>
Reviewed-by: CJ DiMeglio <lethalantidote@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#600832}(cherry picked from commit 892404731a96d57c5162ae52a0fe978ecff80fbf)
Reviewed-on: https://chromium-review.googlesource.com/c/1294694
Cr-Commit-Position: refs/branch-heads/3578@{#245}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}

The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/d3dbf9d9d6f0d0bd6bd360e1e9f1020b8c784469

Commit: d3dbf9d9d6f0d0bd6bd360e1e9f1020b8c784469
Author: lethalantidote@chromium.org
Commiter: lethalantidote@chromium.org
Date: 2018-10-22 17:44:06 +0000 UTC

Removes EnableSurfaceLayerForVideoMS flag.

Because the conditions in which we turn on surfaces for videos have grown
more complicated, and because surfaces for MS (MediaStream) has pretty much been implemented,
it has been decided that special-casing MS videos was no longer required.

Bug: 746182
Change-Id: Ie79c56ba80707c9b3e102eba9bcc712e994065b2
Reviewed-on: https://chromium-review.googlesource.com/c/1250095
Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Emircan Uysaler <emircan@chromium.org>
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Frank Liberato <liberato@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#599492}(cherry picked from commit 3acd2385c4ed66bf3ef58a16df77d75a4ebaf0f5)
Reviewed-on: https://chromium-review.googlesource.com/c/1294203
Reviewed-by: CJ DiMeglio <lethalantidote@chromium.org>
Cr-Commit-Position: refs/branch-heads/3578@{#224}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}

The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/fe5f36a89b7522bb6df5aea4ab68fcd93c822f70

Commit: fe5f36a89b7522bb6df5aea4ab68fcd93c822f70
Author: lethalantidote@chromium.org
Commiter: liberato@chromium.org
Date: 2018-10-22 20:28:37 +0000 UTC

Revert "Removes EnableSurfaceLayerForVideoMS flag."

This reverts commit d3dbf9d9d6f0d0bd6bd360e1e9f1020b8c784469.

Reason for revert: Should not have been merged.

Original change's description:
> Removes EnableSurfaceLayerForVideoMS flag.
> 
> Because the conditions in which we turn on surfaces for videos have grown
> more complicated, and because surfaces for MS (MediaStream) has pretty much been implemented,
> it has been decided that special-casing MS videos was no longer required.
> 
> Bug: 746182
> Change-Id: Ie79c56ba80707c9b3e102eba9bcc712e994065b2
> Reviewed-on: https://chromium-review.googlesource.com/c/1250095
> Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org>
> Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
> Reviewed-by: Emircan Uysaler <emircan@chromium.org>
> Reviewed-by: Fady Samuel <fsamuel@chromium.org>
> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
> Reviewed-by: Frank Liberato <liberato@chromium.org>
> Cr-Original-Commit-Position: refs/heads/master@{#599492}(cherry picked from commit 3acd2385c4ed66bf3ef58a16df77d75a4ebaf0f5)
> Reviewed-on: https://chromium-review.googlesource.com/c/1294203
> Reviewed-by: CJ DiMeglio <lethalantidote@chromium.org>
> Cr-Commit-Position: refs/branch-heads/3578@{#224}
> Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}

TBR=lethalantidote@chromium.org

Change-Id: I21efdbe1bbb0c1cf357de327042273f9d3a7b210
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 746182
Reviewed-on: https://chromium-review.googlesource.com/c/1294749
Reviewed-by: Frank Liberato <liberato@chromium.org>
Cr-Commit-Position: refs/branch-heads/3578@{#241}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}

Still seeing browser test failure on Win64 Beta on desktop continuous builder.

Failures:
---------
WebRtcGetUserMediaBrowserTest.TestGetUserMediaAspectRatio4To3/0
WebRtcGetUserMediaBrowserTest.TestGetUserMediaAspectRatio4To3/1
WebRtcGetUserMediaBrowserTest.TestGetUserMediaAspectRatio1To1/1
WebRtcGetUserMediaBrowserTest.TestGetUserMediaAspectRatio1To1/0
WebRtcGetUserMediaBrowserTest.SrcObjectReassignSameObject/0
WebRtcGetUserMediaBrowserTest.SrcObjectReassignSameObject/1
DumpAccessibilityTreeTest.AccessibilityAriaEditable

Link to the builder:
-------------------
https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/win64%20beta/builds/5660

Thanks!

lethalantidote@, are those the flaky MediaStreams tests we were talking about?

I'm not sure anymore. Do these failures still occur? 

It seems to happen on the stable bot now: https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/win64%20stable/builds/1354 but I do not think there is much we can do.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ca1b78f61f79400a7f5765d42d0a919bd3d90043

commit ca1b78f61f79400a7f5765d42d0a919bd3d90043
Author: Dale Curtis <dalecurtis@chromium.org>
Date: Tue Jan 15 03:11:26 2019

Notify WebVideoFrameSubmitter of page visibility changes.

When put into the background non-surface-layer mode stops receiving
VideoFrameCompositor::UpdateCurrentFrame() calls and starts relying
on the background rendering timer firing every 250ms and, most
importantly, setting the |is_background_rendering| flag on every
Render() call to true. This flag changes how VideoRendererImpl
counts dropped frames, expires the queue, and signals underflow.

SurfaceLayer videos do not stop calling UpdateCurrentFrame in the
background, instead they are delivered every ~500ms -- this causes
VRI to oscillate in and out of background rendering mode and thus
drops more frames and underflows more than non-surface-layer mode.

The fix is to notify WebVideoFrameSubmitter of the page visibility
status (via the existing RenderFrameObserver on each WebMediaPlayer)
so that it can stop begin frame callbacks.

There's a slight complication in that the submitter already has one
notion of visibility through the surface layer, which is specifically:
Is this surface visible? So the existing WVFS::UpdateSubmissionState()
method is renamed to SetIsSurfaceVisible() for clarity and a new
SetIsPageVisible() has been added.

BUG=746182
TEST=tbd

Change-Id: I0ade358dc996563aa292acfeb4f410f36dd64b52
Reviewed-on: https://chromium-review.googlesource.com/c/1407593
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Reviewed-by: Frank Liberato <liberato@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: CJ DiMeglio <lethalantidote@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622704}
[modify] https://crrev.com/ca1b78f61f79400a7f5765d42d0a919bd3d90043/content/renderer/media/stream/webmediaplayer_ms.cc
[modify] https://crrev.com/ca1b78f61f79400a7f5765d42d0a919bd3d90043/content/renderer/media/stream/webmediaplayer_ms_compositor.cc
[modify] https://crrev.com/ca1b78f61f79400a7f5765d42d0a919bd3d90043/content/renderer/media/stream/webmediaplayer_ms_compositor.h
[modify] https://crrev.com/ca1b78f61f79400a7f5765d42d0a919bd3d90043/content/renderer/media/stream/webmediaplayer_ms_unittest.cc
[modify] https://crrev.com/ca1b78f61f79400a7f5765d42d0a919bd3d90043/media/blink/video_frame_compositor.cc
[modify] https://crrev.com/ca1b78f61f79400a7f5765d42d0a919bd3d90043/media/blink/video_frame_compositor.h
[modify] https://crrev.com/ca1b78f61f79400a7f5765d42d0a919bd3d90043/media/blink/video_frame_compositor_unittest.cc
[modify] https://crrev.com/ca1b78f61f79400a7f5765d42d0a919bd3d90043/media/blink/webmediaplayer_impl.cc
[modify] https://crrev.com/ca1b78f61f79400a7f5765d42d0a919bd3d90043/media/blink/webmediaplayer_impl_unittest.cc
[modify] https://crrev.com/ca1b78f61f79400a7f5765d42d0a919bd3d90043/third_party/blink/public/platform/web_video_frame_submitter.h
[modify] https://crrev.com/ca1b78f61f79400a7f5765d42d0a919bd3d90043/third_party/blink/renderer/platform/graphics/video_frame_submitter.cc
[modify] https://crrev.com/ca1b78f61f79400a7f5765d42d0a919bd3d90043/third_party/blink/renderer/platform/graphics/video_frame_submitter.h
[modify] https://crrev.com/ca1b78f61f79400a7f5765d42d0a919bd3d90043/third_party/blink/renderer/platform/graphics/video_frame_submitter_test.cc

📍 Pinpoint job started.
https://pinpoint-dot-chromeperf.appspot.com/job/129e9f84540000

📍 Job complete. See results below.
https://pinpoint-dot-chromeperf.appspot.com/job/129e9f84540000

📍 Pinpoint job started.
https://pinpoint-dot-chromeperf.appspot.com/job/17939e42540000

📍 Job complete. See results below.
https://pinpoint-dot-chromeperf.appspot.com/job/17939e42540000

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/357630f22eee31ae1523f1550cb32c101e325fb9

commit 357630f22eee31ae1523f1550cb32c101e325fb9
Author: Dale Curtis <dalecurtis@chromium.org>
Date: Fri Jan 18 01:10:17 2019

Improve thread checking and remove SetOpaque for VideoFrameSubmitter.

Does the following:
- Add THREAD_CHECKER macros to every function.
- Removes opacity setter in favor of getting it from video frame.
- Cleans up a few variables, method names, and comments.

BUG=746182
TEST=cq passes, https://simpl.info/videoalpha/

Change-Id: I44149dea6667b6ca4b49d12d6dc228819fe5805d
Reviewed-on: https://chromium-review.googlesource.com/c/1419157
Auto-Submit: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623934}
[modify] https://crrev.com/357630f22eee31ae1523f1550cb32c101e325fb9/content/renderer/media/stream/webmediaplayer_ms.cc
[modify] https://crrev.com/357630f22eee31ae1523f1550cb32c101e325fb9/content/renderer/media/stream/webmediaplayer_ms_compositor.cc
[modify] https://crrev.com/357630f22eee31ae1523f1550cb32c101e325fb9/content/renderer/media/stream/webmediaplayer_ms_compositor.h
[modify] https://crrev.com/357630f22eee31ae1523f1550cb32c101e325fb9/content/renderer/media/stream/webmediaplayer_ms_unittest.cc
[modify] https://crrev.com/357630f22eee31ae1523f1550cb32c101e325fb9/media/blink/video_frame_compositor.cc
[modify] https://crrev.com/357630f22eee31ae1523f1550cb32c101e325fb9/media/blink/video_frame_compositor.h
[modify] https://crrev.com/357630f22eee31ae1523f1550cb32c101e325fb9/media/blink/video_frame_compositor_unittest.cc
[modify] https://crrev.com/357630f22eee31ae1523f1550cb32c101e325fb9/media/blink/webmediaplayer_impl.cc
[modify] https://crrev.com/357630f22eee31ae1523f1550cb32c101e325fb9/media/blink/webmediaplayer_impl_unittest.cc
[modify] https://crrev.com/357630f22eee31ae1523f1550cb32c101e325fb9/third_party/blink/public/platform/web_video_frame_submitter.h
[modify] https://crrev.com/357630f22eee31ae1523f1550cb32c101e325fb9/third_party/blink/renderer/platform/graphics/DEPS
[modify] https://crrev.com/357630f22eee31ae1523f1550cb32c101e325fb9/third_party/blink/renderer/platform/graphics/video_frame_submitter.cc
[modify] https://crrev.com/357630f22eee31ae1523f1550cb32c101e325fb9/third_party/blink/renderer/platform/graphics/video_frame_submitter.h
[modify] https://crrev.com/357630f22eee31ae1523f1550cb32c101e325fb9/third_party/blink/renderer/platform/graphics/video_frame_submitter_test.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0e87b4ebbd6fc663a61876c49dcf2b480ed458a6

commit 0e87b4ebbd6fc663a61876c49dcf2b480ed458a6
Author: Dale Curtis <dalecurtis@chromium.org>
Date: Sat Jan 19 01:48:03 2019

Reorder VideoFrameSubmitter methods to align with header. Add docs.

No functional changes. Just documentation and reordering of methods
to comply with the style guide. Also removes a bunch of test only
methods to the unittest since it has friend class status.

Documents the memory savings from various features within the
VideoFrameSubmitter which are not clearly understandable.

Introduces a helper method so SubmitEmptyFrame/SubmitFrame can share
code for creating a viz::CompositorFrame.

BUG=746182
TEST=passes cq.

Change-Id: I950e1a2220b84c2b71b0d8ae9844ac50f547d67c
Reviewed-on: https://chromium-review.googlesource.com/c/1419248
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Reviewed-by: CJ DiMeglio <lethalantidote@chromium.org>
Reviewed-by: Frank Liberato <liberato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#624408}
[modify] https://crrev.com/0e87b4ebbd6fc663a61876c49dcf2b480ed458a6/third_party/blink/renderer/platform/graphics/video_frame_submitter.cc
[modify] https://crrev.com/0e87b4ebbd6fc663a61876c49dcf2b480ed458a6/third_party/blink/renderer/platform/graphics/video_frame_submitter.h
[modify] https://crrev.com/0e87b4ebbd6fc663a61876c49dcf2b480ed458a6/third_party/blink/renderer/platform/graphics/video_frame_submitter_test.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fcdd378dc5685cf45391ec9a522136e059d15ef7

commit fcdd378dc5685cf45391ec9a522136e059d15ef7
Author: Dale Curtis <dalecurtis@chromium.org>
Date: Tue Jan 22 20:06:38 2019

Add media/ and a few other OWNERS for video SurfaceLayer functionality.

Adds standard media/OWNERS + mlamouri@ + lethalantidote@ for the
following files:

blink/public/platform/web_surface_layer_bridge.h
blink/public/platform/web_video_frame_submitter.h
blink/renderer/platform/graphics/surface_layer_bridge.cc
blink/renderer/platform/graphics/surface_layer_bridge.h
blink/renderer/platform/graphics/video_frame_submitter_test.cc
blink/renderer/platform/graphics/video_frame_submitter.cc
blink/renderer/platform/graphics/video_frame_submitter.h
blink/renderer/platform/graphics/video_frame_resource_provider.cc
blink/renderer/platform/graphics/video_frame_resource_provider.h

BUG=746182

Change-Id: I4612c011421fcf7ba3ee33b96e51dd03c7acc1b6
Reviewed-on: https://chromium-review.googlesource.com/c/1423086
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#624889}
[modify] https://crrev.com/fcdd378dc5685cf45391ec9a522136e059d15ef7/third_party/blink/public/platform/OWNERS
[modify] https://crrev.com/fcdd378dc5685cf45391ec9a522136e059d15ef7/third_party/blink/renderer/platform/graphics/OWNERS

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7050ea6a38d4123e12e35e18d7e0412177485624

commit 7050ea6a38d4123e12e35e18d7e0412177485624
Author: Dale Curtis <dalecurtis@chromium.org>
Date: Tue Jan 22 23:33:26 2019

Fix broken ContextGL loss for Video SurfaceLayer.

Turns out less is more. Presuambly since we're actually getting a real
SurfaceID these days, we don't need to call ClearSurfaceID on the layer
when context is lost. The remote side seems to restore and resurrect
the existing SurfaceID in a way that allows the existing one to continue
to work properly once a new frame sink is fetched.

This also removes an unnecessary reset of |is_surface_visible_| upon
context loss, which does not help anything.

You still get green frames if GpuMemoryBuffer's are enabled, but
otherwise all frames are displayed again when the new context is
retrieved. This all works since UpdateSubmissionState() will either
submit a frame or rendering is in action and one will come in soon.

TODO: We really need an automated test for ContextLoss to ensure it
still works. Will start on that in a separate CL.

BUG=746182
TEST=kill gpu process, video resumes.

Change-Id: Ic0e480b9788baf4145971be6fe247e431f698c65
Reviewed-on: https://chromium-review.googlesource.com/c/1423463
Reviewed-by: Frank Liberato <liberato@chromium.org>
Reviewed-by: CJ DiMeglio <lethalantidote@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#624986}
[modify] https://crrev.com/7050ea6a38d4123e12e35e18d7e0412177485624/content/renderer/media/stream/webmediaplayer_ms.cc
[modify] https://crrev.com/7050ea6a38d4123e12e35e18d7e0412177485624/content/renderer/media/stream/webmediaplayer_ms.h
[modify] https://crrev.com/7050ea6a38d4123e12e35e18d7e0412177485624/content/renderer/media/stream/webmediaplayer_ms_compositor.cc
[modify] https://crrev.com/7050ea6a38d4123e12e35e18d7e0412177485624/content/renderer/media/stream/webmediaplayer_ms_compositor.h
[modify] https://crrev.com/7050ea6a38d4123e12e35e18d7e0412177485624/content/renderer/media/stream/webmediaplayer_ms_unittest.cc
[modify] https://crrev.com/7050ea6a38d4123e12e35e18d7e0412177485624/media/blink/video_frame_compositor.cc
[modify] https://crrev.com/7050ea6a38d4123e12e35e18d7e0412177485624/media/blink/video_frame_compositor.h
[modify] https://crrev.com/7050ea6a38d4123e12e35e18d7e0412177485624/media/blink/video_frame_compositor_unittest.cc
[modify] https://crrev.com/7050ea6a38d4123e12e35e18d7e0412177485624/media/blink/webmediaplayer_impl.cc
[modify] https://crrev.com/7050ea6a38d4123e12e35e18d7e0412177485624/media/blink/webmediaplayer_impl.h
[modify] https://crrev.com/7050ea6a38d4123e12e35e18d7e0412177485624/media/blink/webmediaplayer_impl_unittest.cc
[modify] https://crrev.com/7050ea6a38d4123e12e35e18d7e0412177485624/third_party/blink/public/platform/web_surface_layer_bridge.h
[modify] https://crrev.com/7050ea6a38d4123e12e35e18d7e0412177485624/third_party/blink/public/platform/web_video_frame_submitter.h
[modify] https://crrev.com/7050ea6a38d4123e12e35e18d7e0412177485624/third_party/blink/renderer/platform/graphics/surface_layer_bridge.cc
[modify] https://crrev.com/7050ea6a38d4123e12e35e18d7e0412177485624/third_party/blink/renderer/platform/graphics/surface_layer_bridge.h
[modify] https://crrev.com/7050ea6a38d4123e12e35e18d7e0412177485624/third_party/blink/renderer/platform/graphics/video_frame_submitter.cc
[modify] https://crrev.com/7050ea6a38d4123e12e35e18d7e0412177485624/third_party/blink/renderer/platform/graphics/video_frame_submitter.h
[modify] https://crrev.com/7050ea6a38d4123e12e35e18d7e0412177485624/third_party/blink/renderer/platform/graphics/video_frame_submitter_test.cc