New issue
Advanced search Search tips

Issue 746150 link

Starred by 2 users
Status: WontFix
Owner: ----
Closed: Sep 25
Cc:
kouhei@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

Audit suspicious usages of GetFrame

Project Member Reported by kochi@chromium.org, Jul 19 2017 
There appear to some usages of GetFrame() via HTML Import's
master document, e.g.

https://chromium-review.googlesource.com/c/571109/4/third_party/WebKit/Source/core/css/MediaValues.cpp

but during the review it was pointed out that the document should
be ContextDocument(), rather than executing_document (master document
of HTML Imports).

Investigate whether such usages are correct or not, and if not,
fix by using ContextDocument().
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 30 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5b21d9f1d7105abb171ba16311d0f27dc7f7f09e

commit 5b21d9f1d7105abb171ba16311d0f27dc7f7f09e
Author: Takayoshi Kochi <kochi@chromium.org>
Date: Wed Aug 30 08:28:24 2017

Clean up usage of HTMLImportsController in Document

There are some common usages of Document.ImportsController() to
see if the document is an import or not, or if it is, to access
its master document.

It required some internal knowledge about how HTMLImportsController
is used for a master document and its imports, and made code hard
to understand.

Added some APIs in Document class so its users do not have to
access .ImportsController() directly.

Bug:  673669 ,  746150 
Change-Id: I4850c78988c224fb989045191f44f0f4d9ef0373
Reviewed-on: https://chromium-review.googlesource.com/571109
Commit-Queue: Takayoshi Kochi <kochi@chromium.org>
Reviewed-by: Dominic Cooney <dominicc@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Takeshi Yoshino <tyoshino@chromium.org>
Reviewed-by: Hayato Ito <hayato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#498396}
[modify] https://crrev.com/5b21d9f1d7105abb171ba16311d0f27dc7f7f09e/third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.cpp
[modify] https://crrev.com/5b21d9f1d7105abb171ba16311d0f27dc7f7f09e/third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp
[modify] https://crrev.com/5b21d9f1d7105abb171ba16311d0f27dc7f7f09e/third_party/WebKit/Source/core/css/MediaValues.cpp
[modify] https://crrev.com/5b21d9f1d7105abb171ba16311d0f27dc7f7f09e/third_party/WebKit/Source/core/css/MediaValues.h
[modify] https://crrev.com/5b21d9f1d7105abb171ba16311d0f27dc7f7f09e/third_party/WebKit/Source/core/css/MediaValuesCached.cpp
[modify] https://crrev.com/5b21d9f1d7105abb171ba16311d0f27dc7f7f09e/third_party/WebKit/Source/core/css/MediaValuesDynamic.cpp
[modify] https://crrev.com/5b21d9f1d7105abb171ba16311d0f27dc7f7f09e/third_party/WebKit/Source/core/dom/Document.cpp
[modify] https://crrev.com/5b21d9f1d7105abb171ba16311d0f27dc7f7f09e/third_party/WebKit/Source/core/dom/Document.h
[modify] https://crrev.com/5b21d9f1d7105abb171ba16311d0f27dc7f7f09e/third_party/WebKit/Source/core/dom/StyleEngine.cpp
[modify] https://crrev.com/5b21d9f1d7105abb171ba16311d0f27dc7f7f09e/third_party/WebKit/Source/core/html/LinkResource.cpp

Comment 2 by yoichio@chromium.org, Mar 16 2018

Owner: yoichio@chromium.org

Comment 3 by yoichio@chromium.org, Sep 25

Owner: ----
Status: Available (was: Assigned)

Comment 4 by yoichio@chromium.org, Sep 25

Status: WontFix (was: Available)
HTML Imports is deprecated. See crbug.com/766694.
►

Sign in to add a comment