New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 746142 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Last visit > 30 days ago
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

factory_install: Add a new menu action item to update Cr50 firmware.

Project Member Reported by hungte@chromium.org, Jul 19 2017

Issue description

We find that it may be hard to update Cr50 if it falls to some error state.

Factory reset shim boots in recovery mode if "dev switch is enabled", so this may be the better choice to update and reset a device.

Please add two menu items:
1. Reset TPM (calls chromeos-tpm-recovery)
2. Update CR50 (calls usb_updater /opt/google/cr50/firmware/cr50.bin.prod)

Well, currently factory shims do not have /opt so we may need to figure out a way - either changing INSTALL_MASK to include /opt/google/cr50 again, or allowing user to put a firmware image on stateful partition and update from it (since cr50 is self crypto-signed I think this may be good enough).

Temporarily assign to Ting - please get Peter's help if your plate is full.
 
Cc: ppichai@google.com mruthven@chromium.org
Status: Fixed (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory_installer/+/256ef4c43d64c52c58e692d6b9a4062f0a13e0c5

commit 256ef4c43d64c52c58e692d6b9a4062f0a13e0c5
Author: Ting Shen <phoenixshen@google.com>
Date: Tue Aug 01 04:39:39 2017

factory_install: Add a new menu action item to update Cr50 firmware.

Support two new options:
1. reset tpm
2. update cr50

BUG= chromium:746142 
TEST=manual

Change-Id: I7b30a702cc1cf374445e3d0951312a7d942c5c44
Reviewed-on: https://chromium-review.googlesource.com/579407
Commit-Ready: Hung-Te Lin <hungte@chromium.org>
Tested-by: Hung-Te Lin <hungte@chromium.org>
Reviewed-by: Hung-Te Lin <hungte@chromium.org>

[modify] https://crrev.com/256ef4c43d64c52c58e692d6b9a4062f0a13e0c5/factory_install.sh

Project Member

Comment 4 by bugdroid1@chromium.org, Aug 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory_installer/+/e461edb9a56660f466486ca7cca35b369ed84f1f

commit e461edb9a56660f466486ca7cca35b369ed84f1f
Author: Ting Shen <phoenixshen@google.com>
Date: Wed Aug 02 05:59:47 2017

factory_install: improve cr50 fw update script

Based on dicussion in CL:579407, added following feature:

1) Add -s -u
2) report error if return value = 3 (update_error)

BUG= chromium:746142 
TEST=manual

Change-Id: Ie9ce70d1a93804260af18348834fa3c0f5ec2635
Reviewed-on: https://chromium-review.googlesource.com/594610
Commit-Ready: Ting Shen <phoenixshen@chromium.org>
Tested-by: Ting Shen <phoenixshen@chromium.org>
Reviewed-by: Hung-Te Lin <hungte@chromium.org>
Reviewed-by: Vadim Bendebury <vbendeb@chromium.org>

[modify] https://crrev.com/e461edb9a56660f466486ca7cca35b369ed84f1f/factory_install.sh

Cc: marcochen@chromium.org

Comment 6 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment