bluetooth::mojom::AdapterFactory is available to any renderer without permission checks |
||||||||||||||||||||||||
Issue descriptionChromeContentBrowserClient::InitFrameInterfaces exposes bluetooth::mojom::AdapterFactory[1] to all RenderFrames. This interface provides full bluetooth access without permission checks. This interface is intended to only be used by webui. [1] https://cs.chromium.org/chromium/src/chrome/browser/chrome_content_browser_client.cc?type=cs&q=ChromeContentBrowserClient::InitFrameInterfaces&sq=package:chromium&l=3288
,
Jul 19 2017
,
Jul 19 2017
,
Jul 19 2017
That's a sandbox escape if all bluetooth access is available and should not be. Assigning to ben@ who added that code. It was added on June 20th, 2017 so I do not believe this change is in M-60, which branched on Thu, May 25, 2017 PT.
,
Jul 19 2017
,
Jul 19 2017
fwiw: ben's patch just moved things around without introducing any new bugs. The original patch landed in September of last year: https://crrev.com/2357383002. Assigning to scheib for triage.
,
Jul 19 2017
,
Jul 19 2017
,
Jul 26 2017
,
Aug 23 2017
,
Sep 6 2017
,
Sep 17 2017
We commit ourselves to a 60 day deadline for fixing for high severity vulnerabilities, and have exceeded it here. If you're unable to look into this soon, could you please find another owner or remove yourself so that this gets back into the security triage queue? For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 18 2017
,
Nov 3 2017
scheib@ -- friendly ping from the security sheriff. can you please share an update on this high priority security bug? thanks.
,
Nov 3 2017
There is a patch in progress.
,
Nov 9 2017
scheib: any updates on the in-progress patch? Thanks!
,
Nov 10 2017
Stalled since Nov 3 with non-code obligations.
,
Nov 29 2017
Friendly ping. :) We've blown our fix deadline, and the CL has been quiescent for 12 days. We really need to get this nailed down. Thank you!
,
Nov 29 2017
,
Nov 29 2017
Patch needs cleanup and build rules scrutiny, but is progressing and now functional. I've gotten it unblocked on the mojo changes that were blocking the refactor.
,
Dec 5 2017
,
Dec 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dbe693beefc371f59a6561d6113ddc0c5af76889 commit dbe693beefc371f59a6561d6113ddc0c5af76889 Author: Vincent Scheib <scheib@chromium.org> Date: Wed Dec 06 00:54:18 2017 bluetooth: internals page: Refactor instantiation of Bluetooth service. Moves ability to create the //device/bluetooth/public/interfaces Adapter to chrome/browser/ui/webui/bluetooth_internals/bluetooth_internals_handler.cc instead of chrome/browser/chrome_content_browser_client.cc //chrome/browser/ui/webui/bluetooth_internals target created to allow visibility of //device/bluetooth/public/interfaces:deprecated_experimental_interfaces to be restricted precisely to the single allowed client. Numerous build files adjusted as needed to enforce that visibility restriction and clearly document that the interfaces are only intended to be used by bluetooth-internals. Bug: 746132 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Idcaa51d1ed4fb818bd3d8ae617e41a28eabfcb44 Reviewed-on: https://chromium-review.googlesource.com/775782 Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by: Greg Kerr <kerrnel@chromium.org> Commit-Queue: Vincent Scheib <scheib@chromium.org> Cr-Commit-Position: refs/heads/master@{#521924} [modify] https://crrev.com/dbe693beefc371f59a6561d6113ddc0c5af76889/chrome/browser/BUILD.gn [modify] https://crrev.com/dbe693beefc371f59a6561d6113ddc0c5af76889/chrome/browser/browser_resources.grd [modify] https://crrev.com/dbe693beefc371f59a6561d6113ddc0c5af76889/chrome/browser/chrome_content_browser_client.cc [modify] https://crrev.com/dbe693beefc371f59a6561d6113ddc0c5af76889/chrome/browser/chrome_content_browser_manifest_overlay.json [modify] https://crrev.com/dbe693beefc371f59a6561d6113ddc0c5af76889/chrome/browser/resources/bluetooth_internals/adapter_broker.js [modify] https://crrev.com/dbe693beefc371f59a6561d6113ddc0c5af76889/chrome/browser/resources/bluetooth_internals/bluetooth_internals.html [modify] https://crrev.com/dbe693beefc371f59a6561d6113ddc0c5af76889/chrome/browser/ui/BUILD.gn [add] https://crrev.com/dbe693beefc371f59a6561d6113ddc0c5af76889/chrome/browser/ui/webui/bluetooth_internals/BUILD.gn [add] https://crrev.com/dbe693beefc371f59a6561d6113ddc0c5af76889/chrome/browser/ui/webui/bluetooth_internals/OWNERS [add] https://crrev.com/dbe693beefc371f59a6561d6113ddc0c5af76889/chrome/browser/ui/webui/bluetooth_internals/bluetooth_internals.mojom [add] https://crrev.com/dbe693beefc371f59a6561d6113ddc0c5af76889/chrome/browser/ui/webui/bluetooth_internals/bluetooth_internals_handler.cc [add] https://crrev.com/dbe693beefc371f59a6561d6113ddc0c5af76889/chrome/browser/ui/webui/bluetooth_internals/bluetooth_internals_handler.h [modify] https://crrev.com/dbe693beefc371f59a6561d6113ddc0c5af76889/chrome/browser/ui/webui/bluetooth_internals/bluetooth_internals_ui.cc [modify] https://crrev.com/dbe693beefc371f59a6561d6113ddc0c5af76889/chrome/browser/ui/webui/bluetooth_internals/bluetooth_internals_ui.h [modify] https://crrev.com/dbe693beefc371f59a6561d6113ddc0c5af76889/chrome/test/data/webui/bluetooth_internals_browsertest.js [modify] https://crrev.com/dbe693beefc371f59a6561d6113ddc0c5af76889/device/BUILD.gn [modify] https://crrev.com/dbe693beefc371f59a6561d6113ddc0c5af76889/device/bluetooth/BUILD.gn [delete] https://crrev.com/9d0c82f471d7dfe177f059f9265f4919912823c1/device/bluetooth/adapter_factory.cc [delete] https://crrev.com/9d0c82f471d7dfe177f059f9265f4919912823c1/device/bluetooth/adapter_factory.h [modify] https://crrev.com/dbe693beefc371f59a6561d6113ddc0c5af76889/device/bluetooth/public/interfaces/BUILD.gn [modify] https://crrev.com/dbe693beefc371f59a6561d6113ddc0c5af76889/device/bluetooth/public/interfaces/adapter.mojom
,
Dec 6 2017
,
Dec 7 2017
,
Dec 15 2017
,
Dec 15 2017
This bug requires manual review: There is .grd file changes and we are only 38 days from stable. Please contact the milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 18 2017
abdulsyed@ - good for M64
,
Dec 19 2017
Thanks awhalley@ and scheib@ - a large refactor worries me a bit at this stage. This also contains a grd change. Can we target this for M65 instead?
,
Dec 19 2017
Rejecting merge for M64. Seems like this has been around for a while (since July) and my recommendation is to wait until M65.
,
Jan 22 2018
,
Mar 6 2018
,
Mar 15 2018
This bug has been closed for more than 14 weeks. Removing security view restrictions. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot |
||||||||||||||||||||||||
►
Sign in to add a comment |
||||||||||||||||||||||||
Comment 1 by ortuno@chromium.org
, Jul 19 2017Components: Blink>Bluetooth