New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 746128 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Cc:
EstimatedDays: ----
NextAction: ----
OS: Windows , Mac
Pri: 1
Type: Bug

Blocking:
issue 860368



Sign in to add a comment

video-enter-exit-fullscreen-without-hovering-doesnt-show-controls.html is failing consistently (?) on Win7 dbg and flakily on Mac

Project Member Reported by aboxhall@chromium.org, Jul 19 2017

Issue description

Looks like the earliest failure was https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Win7%20%28dbg%29/builds/10324

I can't see any obvious culprits in the Blamelist, so assigning to you as the test author :\

I'll add a TestExpectation for now, but would you be able to try and figure out what's going on here?
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ad293538b24326b590dcb32defb09d9043395d75

commit ad293538b24326b590dcb32defb09d9043395d75
Author: Alice Boxhall <aboxhall@chromium.org>
Date: Wed Jul 19 04:00:08 2017

Add TestExpectation for video-enter-exit-fullscreen-without-hovering-doesnt-show-controls.html

TBR=johnme@chromium.org

Bug: 746128
Change-Id: Ibc2af441890fe722205ac53ce1140c720dfff4fa
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/576600
Commit-Queue: Alice Boxhall <aboxhall@chromium.org>
Reviewed-by: Alice Boxhall <aboxhall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487741}
[modify] https://crrev.com/ad293538b24326b590dcb32defb09d9043395d75/third_party/WebKit/LayoutTests/TestExpectations

Comment 2 by joh...@chromium.org, Jul 19 2017

Shame that bot doesn't upload to https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_tests&tests=video-enter-exit-fullscreen-without-hovering-doesnt-show-controls.html

I looked back further, and it also failed on builds 10305 & 10302. And the virtual/new-remote-playback-pipeline/ variant failed on builds 10331-10328, 10326-10324, 10302, 10300 & 10293.

Seems both tests are just very flaky on this bot. They're also flaky on WebKit Linux Trusty (dbg): https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=video-enter-exit-fullscreen-without-hovering-doesnt-show-controls.html

Since this only happens on dbg bots, there's probably a race condition somewhere.

The error I see on WebKit Win7 (dbg) is:
assert_equals: Inline controls should not show after exiting fullscreen since mouse is not hovering over controls expected "0" but got "0.192067"

The error I see on WebKit Linux Trusty (dbg) is:
assert_equals: Inline controls should not show after exiting fullscreen since mouse is not hovering over controls expected "0" but got "1"

In both cases, since the previous opacity check successfully tested that the opacity was zero before exiting fullscreen, it seems the controls were incorrectly shown as a result of exiting fullscreen (or as a delayed result of some previous step).

One possibility might be that the test-25fps video reached its end, which would cause the controls to show. It's only a 10 second video, and we already had to mark these tests as SlowTests. We should try using a longer video instead.
 Issue 745853  has been merged into this issue.
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e24f41667474d388ad8ace016323db825d4d89df

commit e24f41667474d388ad8ace016323db825d4d89df
Author: Ojan Vafai <ojan@chromium.org>
Date: Fri Jul 21 16:59:14 2017

Add failure expectation for video-enter-exit-fullscreen-without-hovering-doesnt-show-controls.html

The non-virtual test is already listed as failing.
Mark the virtual one as failing as well. Also, make them
both only debug since it passes on release builds.

BUG=746128
TBR=johnme@chromium.org

Change-Id: I840dc81c2c0434f88974d4a3ff95c3dad79ec43f
Reviewed-on: https://chromium-review.googlesource.com/581416
Reviewed-by: Ojan Vafai <ojan@chromium.org>
Reviewed-by: John Mellor <johnme@chromium.org>
Commit-Queue: Ojan Vafai <ojan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488685}
[modify] https://crrev.com/e24f41667474d388ad8ace016323db825d4d89df/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 5 by bugdroid1@chromium.org, Jul 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6f044e1b30928813d047b0a411351b4d50138776

commit 6f044e1b30928813d047b0a411351b4d50138776
Author: Ojan Vafai <ojan@chromium.org>
Date: Sat Jul 22 02:12:00 2017

Mark controls-video-keynav.html as failing.

This is also failing on Win7 Debug along with the other video tests.
They both seem flaky, so likely have the same root cause.

BUG=746128
TBR=johnme@chromium.org

Change-Id: I3622dc76166bc229222f4966eb2bafcfac7de0f1
Reviewed-on: https://chromium-review.googlesource.com/582470
Reviewed-by: Ojan Vafai <ojan@chromium.org>
Commit-Queue: Ojan Vafai <ojan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488839}
[modify] https://crrev.com/6f044e1b30928813d047b0a411351b4d50138776/third_party/WebKit/LayoutTests/TestExpectations

Labels: -Pri-3 Test-Layout Pri-2
This issue looks related to  issue 749965 . Maybe one of them should be marked as duplicate?

Comment 7 by joh...@chromium.org, Dec 16 2017

Cc: joh...@chromium.org
Owner: mlamouri@chromium.org
I'm not going to be able to get to this. At least it seems reliable on release builds.
Blocking: 860368
Project Member

Comment 9 by bugdroid1@chromium.org, Aug 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fc330293ae3900dbae89b2a10318a2aafa53dd0b

commit fc330293ae3900dbae89b2a10318a2aafa53dd0b
Author: Avi Drissman <avi@chromium.org>
Date: Wed Aug 08 16:30:30 2018

Disable failing tests.

BUG= 867628 , 746128
TBR=hubbe@chromium.org

Change-Id: I71f6dba4710bf7c3ffb0f14ed430d6419f59e0ed
Reviewed-on: https://chromium-review.googlesource.com/1167468
Commit-Queue: Avi Drissman <avi@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581588}
[modify] https://crrev.com/fc330293ae3900dbae89b2a10318a2aafa53dd0b/third_party/WebKit/LayoutTests/TestExpectations

This is also flaky on Mac and I will disable the test there as well. See  issue 872632  for details.
Labels: Sheriff-Chromium
Labels: -Pri-2 OS-Mac OS-Windows Pri-1
Summary: video-enter-exit-fullscreen-without-hovering-doesnt-show-controls.html is failing consistently (?) on Win7 dbg and flakily on Mac (was: video-enter-exit-fullscreen-without-hovering-doesnt-show-controls.html is failing consistently (?) on Win7 dbg)
Project Member

Comment 13 by bugdroid1@chromium.org, Aug 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8662296560d3dbd5e76092c8e4136f4e406d1185

commit 8662296560d3dbd5e76092c8e4136f4e406d1185
Author: vitaliii <vitaliii@chromium.org>
Date: Thu Aug 09 09:14:27 2018

Disable flaky m/c/video-enter-exit-{...}-show-controls.html (Mac).

media/controls/video-enter-exit-fullscreen-without-hovering-doesnt-show-controls.html

TBR=mlamouri@chromium.org
NOTRY=true

Bug: 746128, 872632 
Change-Id: Ib6d822f0a6ddfed1604ca1358f141b3b38ca8d35
Reviewed-on: https://chromium-review.googlesource.com/1169013
Reviewed-by: vitaliii <vitaliii@chromium.org>
Commit-Queue: vitaliii <vitaliii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581837}
[modify] https://crrev.com/8662296560d3dbd5e76092c8e4136f4e406d1185/third_party/WebKit/LayoutTests/TestExpectations

Labels: -Sheriff-Chromium
Please have a look.

Sign in to add a comment