Issue metadata
Sign in to add a comment
|
net_perftests failing on 2 builders |
||||||||||||||||||||
Issue descriptionnet_perftests failing on 2 builders Builders failed on: - Linux Perf: https://build.chromium.org/p/chromium.perf/builders/Linux%20Perf - Mac 10.12 Perf: https://build.chromium.org/p/chromium.perf/builders/Mac%2010.12%20Perf Log: https://chromium-swarm.appspot.com/task?id=376f0d4ee9d08910&refresh=10&show_raw=1 *RESULT URLRequestQuicPerfTest.TestGetRequest: time= 0 ms ../../net/url_request/url_request_quic_perftest.cc:274: Failure Expected: 1u Which is: 1 To be equal to: trace_analyzer::CountMatches( events, trace_analyzer::Query::EventNameIs( base::trace_event::MemoryDumpTypeToString( base::trace_event::MemoryDumpType::EXPLICITLY_TRIGGERED))) Which is: 0 Received signal 11 SEGV_MAPERR 000000000000 [0x000104e4f64c] [0x000104e4f541] [0x7fffaa9b9bba] [0x000105294e00] [0x000104c45616] [0x000104c45df0] [0x000104c46317] [0x000104c4c1d7] [0x000104c4be43] [0x00010511bc23] [0x000104c08949] [0x7fffaa7ac255] [0x000000000003] [end of stack trace]
,
Jul 19 2017
Ssid@: I think this is caused by your change: https://chromium.googlesource.com/chromium/src/+/43929085bfb1df7bc1ad3231a3a71736a72dea38 Could you take a look?
,
Jul 20 2017
Wow this is not part of CQ! fixing the test, sorry
,
Jul 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0bb892a48da3b65f772060e7d2d680343815585b commit 0bb892a48da3b65f772060e7d2d680343815585b Author: Siddhartha <ssid@chromium.org> Date: Fri Jul 21 06:26:00 2017 Fix URLRequestQuicPerfTest to check the memory dumps directly The test was broken because enabling tracing no longer enables MemoryDumpManager. Directly use memory tracing api for checking the dump values instead of trace file analyzer. BUG= 746124 Change-Id: I950a1e43a63b6424afd67f0c6d30e0c50722fe24 Reviewed-on: https://chromium-review.googlesource.com/580338 Commit-Queue: Siddhartha S <ssid@chromium.org> Reviewed-by: Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#488600} [modify] https://crrev.com/0bb892a48da3b65f772060e7d2d680343815585b/net/url_request/url_request_quic_perftest.cc
,
Jul 21 2017
|
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by sheriffbot@chromium.org
, Jul 19 2017