New issue
Advanced search Search tips

Issue 746113 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Jul 2017
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Imageloader EnterSandbox leaks memory

Project Member Reported by mpdenton@google.com, Jul 19 2017

Issue description

ImageLoader::EnterSandbox doesn't free the struct minijail or the pointers inside of it. It should probably use "ScopedMinijail" or "minijail_destroy".
 
Project Member

Comment 1 by sheriffbot@chromium.org, Jul 19 2017

Labels: Hotlist-Google
Labels: -Pri-3 -Hotlist-Google Pri-2
Status: Started (was: Untriaged)
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/imageloader/+/4be757e63b726c0f97d16e6193ca2d054ac4f777

commit 4be757e63b726c0f97d16e6193ca2d054ac4f777
Author: Greg Kerr <kerrnel@chromium.org>
Date: Thu Jul 20 07:36:59 2017

Fix memory leak of minijail object.

Use ScopedMinijail to fix a memory leak of the minijail object and its
associated data.

BUG= chromium:746113 
TEST=platform_ImageLoaderServer

Change-Id: I00b80122d1e111e3b3055e56bce09469c0e560a9
Reviewed-on: https://chromium-review.googlesource.com/578448
Commit-Ready: Greg Kerr <kerrnel@chromium.org>
Tested-by: Greg Kerr <kerrnel@chromium.org>
Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org>

[modify] https://crrev.com/4be757e63b726c0f97d16e6193ca2d054ac4f777/imageloader.cc
[modify] https://crrev.com/4be757e63b726c0f97d16e6193ca2d054ac4f777/mount_helper.cc

Project Member

Comment 4 by sheriffbot@chromium.org, Jul 20 2017

Labels: Hotlist-Google
Status: Fixed (was: Started)

Comment 6 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment