New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 746107 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Last visit > 30 days ago
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocking:
issue 740640



Sign in to add a comment

Add more descriptive accessibility names to system tray

Project Member Reported by lesliewatkins@chromium.org, Jul 19 2017

Issue description

What steps will reproduce the problem?
(1) Enable ChromeVox (CTL+ALT+Z)
(2) Click on the system tray, then Networks
(3) Tab over the message row under Mobile Data (eg "Scanning for mobile networks...", "Turn on Bluetooth", etc)

What is the expected result?
A descriptive label appears at the top of the screen.

What happens instead?
The node role (eg "Button", "labelText") appears at the top of the screen.
 
Labels: M-61
Blocking: 740640
Status: Assigned (was: Untriaged)
Don't worry too much about message rows other than the Bluetooth message row that you created. If you can incidentally fix them that would be great, but be sure to focus on the Bluetooth message row.
Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b15287cba7207048d9023ef3bf8d4a2574b0a04d

commit b15287cba7207048d9023ef3bf8d4a2574b0a04d
Author: Leslie Watkins <lesliewatkins@chromium.org>
Date: Fri Jul 21 22:08:51 2017

Add accessible names to TrayInfoLabels.

Bug: 672263, 673874,  746107 
Change-Id: I5a1f7a4d86307bd84e236dc29d3da224abdcaef4
Reviewed-on: https://chromium-review.googlesource.com/580406
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488770}
[modify] https://crrev.com/b15287cba7207048d9023ef3bf8d4a2574b0a04d/ash/system/tray/tray_info_label.cc
[modify] https://crrev.com/b15287cba7207048d9023ef3bf8d4a2574b0a04d/ash/system/tray/tray_info_label_unittest.cc

Status: Fixed (was: Started)
Labels: Merge-Request-61

Comment 7 by gov...@chromium.org, Jul 26 2017

Pls apply appropriate OSs label. Thank you.
Labels: OS-Chrome
Project Member

Comment 9 by sheriffbot@chromium.org, Jul 26 2017

Labels: -Merge-Request-61 Hotlist-Merge-Approved Merge-Approved-61
Your change meets the bar and is auto-approved for M61. Please go ahead and merge the CL to branch 3163 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), ketakid @(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 10 by bugdroid1@chromium.org, Jul 27 2017

Labels: -merge-approved-61 merge-merged-3163
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/889a2fdad0db9da252c99c8ec5f1b18e6f7a0ac5

commit 889a2fdad0db9da252c99c8ec5f1b18e6f7a0ac5
Author: Kyle Horimoto <khorimoto@google.com>
Date: Thu Jul 27 16:55:38 2017

Add accessible names to TrayInfoLabels.

TBR=lesliewatkins@chromium.org

(cherry picked from commit b15287cba7207048d9023ef3bf8d4a2574b0a04d)

Bug: 672263, 673874,  746107 
Change-Id: I5a1f7a4d86307bd84e236dc29d3da224abdcaef4
Reviewed-on: https://chromium-review.googlesource.com/580406
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#488770}
Reviewed-on: https://chromium-review.googlesource.com/590088
Cr-Commit-Position: refs/branch-heads/3163@{#82}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/889a2fdad0db9da252c99c8ec5f1b18e6f7a0ac5/ash/system/tray/tray_info_label.cc
[modify] https://crrev.com/889a2fdad0db9da252c99c8ec5f1b18e6f7a0ac5/ash/system/tray/tray_info_label_unittest.cc

Comment 11 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment