[CRD iOS] Refactor the main function |
||
Issue descriptionCurrently Chromium and private builds have their own main functions while most of the code is the same. This is painful to maintain since adding new initialization code will require adding the same code and deps in two repos. We should refactor the main function to avoid redundant initialization code.
,
Jul 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0f8b5a5cc02b1ecf53a0c28544aac4d9248111b2 commit 0f8b5a5cc02b1ecf53a0c28544aac4d9248111b2 Author: Yuwei Huang <yuweih@chromium.org> Date: Wed Jul 19 22:13:26 2017 [CRD iOS] Adding an AppInitializer This CL introduces an AppInitializer class for initializing the app differently in different builds before launching the app. Previously we had two different main.mm for the Chromium and internal build. It's a pain to keep them in sync and introduce some unnecessary dependencies (e.g. base:i18n and ui/base) to the internal build target. This is especially painful when I try to add initialization code for i18n stuff. This refactoring should help reducing redundant code and simplify the dependency map of the internal build a bit. This should be landed after internal CL: https://chromereviews.googleplex.com/595547013/ Bug: 746105 Change-Id: I4e80ef92cb3f9f68a0f811a6e9d749c36b06b145 Reviewed-on: https://chromium-review.googlesource.com/575260 Commit-Queue: Yuwei Huang <yuweih@chromium.org> Reviewed-by: Scott Nichols <nicholss@chromium.org> Cr-Commit-Position: refs/heads/master@{#488011} [modify] https://crrev.com/0f8b5a5cc02b1ecf53a0c28544aac4d9248111b2/remoting/ios/app/BUILD.gn [add] https://crrev.com/0f8b5a5cc02b1ecf53a0c28544aac4d9248111b2/remoting/ios/app/app_initializer.h [add] https://crrev.com/0f8b5a5cc02b1ecf53a0c28544aac4d9248111b2/remoting/ios/app/app_initializer_chromium.mm [modify] https://crrev.com/0f8b5a5cc02b1ecf53a0c28544aac4d9248111b2/remoting/ios/app/main.mm [modify] https://crrev.com/0f8b5a5cc02b1ecf53a0c28544aac4d9248111b2/remoting/ios/app/remoting_ios_tmpl.gni
,
Jul 20 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/eb15da1316e99a35ee173523016af89e947903f6 commit eb15da1316e99a35ee173523016af89e947903f6 Author: yuweih <yuweih@google.com> Date: Thu Jul 20 00:18:51 2017
,
Jul 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2ecfa829deb9aa082e248b53156c42eab8abbdf6 commit 2ecfa829deb9aa082e248b53156c42eab8abbdf6 Author: Yuwei Huang <yuweih@chromium.org> Date: Fri Jul 21 20:33:54 2017 [CRD iOS] Remove the supports_app_initializer flag Follow up CL for adding AppInitializer. Bug: 746105 Change-Id: I45fd6e39cfd3d748e185bc1e515f5be9ee33cc48 Reviewed-on: https://chromium-review.googlesource.com/578708 Reviewed-by: Scott Nichols <nicholss@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#488742} [modify] https://crrev.com/2ecfa829deb9aa082e248b53156c42eab8abbdf6/remoting/ios/app/remoting_ios_tmpl.gni
,
Aug 3 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by bugdroid1@chromium.org
, Jul 19 2017