New issue
Advanced search Search tips

Issue 746097 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug

Blocking:
issue 745970



Sign in to add a comment

[TTS] our CJKV language-detection isn't working

Project Member Reported by donnd@chromium.org, Jul 19 2017

Issue description

I just discovered that our detection of CJKV languages doesn't work!  The Android method Character.isIdeographic does not do what I thought it did!

This affects some of our tap-suppression heuristics.
 

Comment 1 by donnd@chromium.org, Jul 19 2017

Blocking: 745970
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f59c3a2376e6f75fff13560c2c94853efe3cb38d

commit f59c3a2376e6f75fff13560c2c94853efe3cb38d
Author: Donn Denman <donnd@google.com>
Date: Wed Jul 19 17:21:03 2017

[TTS] Fix word parsing in East Asian alphabets.

Updates Contextual Search to correctly handle words in alphabets
with unreliable word-break characters. The Android method
Character.isIdeographic does not do what I thought it did!
Instead we now use a regular expression to scan a string
for non latin_basic characters.

Also updates the short/long word suppression to be less
confusing when applied to non-latin languages. Since these
characters in CJKV alphabets are data-dense the shortness rule
should not apply.

BUG=745970,  746097 

Change-Id: I65527c614a2ae3a1e74df90a01f00f5e60fea197
Reviewed-on: https://chromium-review.googlesource.com/576909
Commit-Queue: Donn Denman <donnd@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487898}
[modify] https://crrev.com/f59c3a2376e6f75fff13560c2c94853efe3cb38d/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchContext.java
[modify] https://crrev.com/f59c3a2376e6f75fff13560c2c94853efe3cb38d/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchEntityHeuristic.java
[modify] https://crrev.com/f59c3a2376e6f75fff13560c2c94853efe3cb38d/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/TapWordLengthSuppression.java
[modify] https://crrev.com/f59c3a2376e6f75fff13560c2c94853efe3cb38d/chrome/android/junit/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchContextForTest.java
[modify] https://crrev.com/f59c3a2376e6f75fff13560c2c94853efe3cb38d/chrome/android/junit/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchContextTest.java

Comment 3 by donnd@chromium.org, Jul 19 2017

Status: Fixed (was: Started)

Sign in to add a comment