New issue
Advanced search Search tips

Issue 746085 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

repair_test whacks servo V4 database attributes.

Reported by jrbarnette@chromium.org, Jul 18 2017

Issue description

If you run repair_test on a servo V4 host, it'll break
the database entry for the host.  For an example, before
running repair_test, I saw this:

    $ atest host stat chromeos6-row2-rack15-host20
    -----
    Host: chromeos6-row2-rack15-host20
    Platform: relm
[ ... ]
    Host Attributes
    servo_serial : ND00168
    servo_port : 9990
    servo_host : chromeos6-row2-rack15-labstation2

I then ran repair_test, and it failed.  Afterwards, I saw this:
    $ atest host stat chromeos6-row2-rack15-host20
    -----
    Host: chromeos6-row2-rack15-host20
    Platform: relm
[ ... ]
    Host Attributes
    servo_serial : ND00168
    servo_port : 9999
    servo_host : chromeos6-row2-rack15-host20-servo

 
Status: Started (was: Available)
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/a9d65a2dbd5a081ea4345866f2cbb78a9a83e3ea

commit a9d65a2dbd5a081ea4345866f2cbb78a9a83e3ea
Author: Richard Barnette <jrbarnette@chromium.org>
Date: Thu Jan 25 20:03:13 2018

[autotest] Fix repair_test for servo V4.

When using repair_test on DUTs attached to servo V4, the host update
code was incorrectly applying servo V3 defaults to the host's
attributes.  Fix the script not to do that.

BUG=chromium:746085
TEST=run the command locally

Change-Id: I33ee474508d2da69f3dc87eaf41b9930dad3778c
Reviewed-on: https://chromium-review.googlesource.com/884838
Commit-Ready: Richard Barnette <jrbarnette@chromium.org>
Tested-by: Richard Barnette <jrbarnette@chromium.org>
Reviewed-by: Richard Barnette <jrbarnette@google.com>

[modify] https://crrev.com/a9d65a2dbd5a081ea4345866f2cbb78a9a83e3ea/site_utils/deployment/install.py

Status: Available (was: Started)
This issue has been marked as started, but has no owner. Making available.

Sign in to add a comment