New issue
Advanced search Search tips

Issue 746082 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Retry in download service immediately run out retry times

Project Member Reported by xingliu@chromium.org, Jul 18 2017

Issue description

Download something via service, then switch off the WIFI.

The download fails after immediately run all the retries.

The cause is network change observer notifies the offline signal after the download actually fails. Similar to the issue of signal online too late.


 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1c0e3345fd37a2b7e94f3be874b01241d1cf59ae

commit 1c0e3345fd37a2b7e94f3be874b01241d1cf59ae
Author: Xing Liu <xingliu@chromium.org>
Date: Thu Jul 20 03:13:41 2017

Download service: Add a delay when retry the download.

The network change observer notifies the offline signal later than the
actual failure in download request. The controller will immediately
retry since the state is still online.

This CL adds a delay to the retry logic, so it potentially can wait
for an actual online timing to retry.

Bug:  746082 
Change-Id: I42e519618538f6db857b1c173a5bada828c6512d
Reviewed-on: https://chromium-review.googlesource.com/575572
Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488121}
[modify] https://crrev.com/1c0e3345fd37a2b7e94f3be874b01241d1cf59ae/components/download/internal/config.cc
[modify] https://crrev.com/1c0e3345fd37a2b7e94f3be874b01241d1cf59ae/components/download/internal/config.h
[modify] https://crrev.com/1c0e3345fd37a2b7e94f3be874b01241d1cf59ae/components/download/internal/controller_impl.cc
[modify] https://crrev.com/1c0e3345fd37a2b7e94f3be874b01241d1cf59ae/components/download/internal/controller_impl.h
[modify] https://crrev.com/1c0e3345fd37a2b7e94f3be874b01241d1cf59ae/components/download/internal/controller_impl_unittest.cc
[modify] https://crrev.com/1c0e3345fd37a2b7e94f3be874b01241d1cf59ae/components/download/internal/scheduler/scheduler_impl.cc

Status: Fixed (was: Assigned)

Sign in to add a comment