Issue metadata
Sign in to add a comment
|
Optional GPU bots are no longer added by PRESUBMIT scripts |
||||||||||||||||||||
Issue descriptionWhen I uploaded https://chromium-review.googlesource.com/c/576394, optional GPU bots that should have been added by content/test/gpu/PRESUBMIT.py to CQ_INCLUDE_TRYBOTS are not there. I also saw that https://chromium-review.googlesource.com/c/571294/, which should have had optional GPU bots added by gpu/PRESUBMIT.py, doesn't have them. agable@, could you please take a look?
,
Jul 19 2017
Issue 746119 has been merged into this issue.
,
Jul 19 2017
For the record: this regressed in https://chromium-review.googlesource.com/541675/ from Issue 685321 .
,
Jul 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2434914307233a6b2b1bfaa3f1758dbce9600e6a commit 2434914307233a6b2b1bfaa3f1758dbce9600e6a Author: Aaron Gable <agable@chromium.org> Date: Wed Jul 19 15:56:02 2017 Start running post-upload hooks again This was a typo, I accidentally removed the RUN_POST_UPLOAD_HOOKS line (which still has a function) when I meant to remove the TRY_ON_UPLOAD line (which doesn't). I blame them both containing the word 'UPLOAD'. Bug: 746079 Change-Id: I007ed90443680a7f3741367b368c55e5056e3252 Reviewed-on: https://chromium-review.googlesource.com/576530 Reviewed-by: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#487875} [modify] https://crrev.com/2434914307233a6b2b1bfaa3f1758dbce9600e6a/codereview.settings
,
Jul 19 2017
Sorry for the regression, everybody, this should be fixed now.
,
Jul 19 2017
Thanks for the quick fix Aaron. |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by aga...@chromium.org
, Jul 19 2017