WebGLImageChromium doesn't work on ChromeOS |
||||||||
Issue descriptionRecently WebGLImageChromium is enabled on eve, and webgl on eve is broken. The error log is as follows: [14991:14991:0718/154740.229076:ERROR:gpu_command_buffer_stub.cc(1138)] Format is not supported. [14991:14991:0718/154740.229467:ERROR:gles2_cmd_decoder.cc(17904)] [.Offscreen-For-WebGL-0x3c8422c9cc00]GL ERROR :GL_INVALID_OPERATION : glBindTexImage2DCHROMIUM: no image found with the given ID [14991:14991:0718/154740.234584:ERROR:gpu_command_buffer_stub.cc(1138)] Format is not supported. [14991:14991:0718/154740.234809:ERROR:gles2_cmd_decoder.cc(17904)] [.Offscreen-For-WebGL-0x3c8422c9cc00]GL ERROR :GL_INVALID_OPERATION : glBindTexImage2DCHROMIUM: no image found with the given ID [14991:14991:0718/154740.234859:ERROR:gles2_cmd_decoder.cc(17954)] [.Offscreen-For-WebGL-0x3c8422c9cc00]GL ERROR :GL_INVALID_OPERATION : glReleaseTexImage2DCHROMIUM: no image found with the given ID [14991:14991:0718/154740.234925:ERROR:gpu_command_buffer_stub.cc(1169)] Image with ID doesn't exist. [14991:14991:0718/154740.241303:ERROR:gpu_command_buffer_stub.cc(1138)] Format is not supported. [14991:14991:0718/154740.241690:ERROR:gles2_cmd_decoder.cc(17904)] [.Offscreen-For-WebGL-0x3c8422c9cc00]GL ERROR :GL_INVALID_OPERATION : glBindTexImage2DCHROMIUM: no image found with the given ID [14991:14991:0718/154740.241782:ERROR:gles2_cmd_decoder.cc(17954)] [.Offscreen-For-WebGL-0x3c8422c9cc00]GL ERROR :GL_INVALID_OPERATION : glReleaseTexImage2DCHROMIUM: no image found with the given ID [14991:14991:0718/154740.247908:ERROR:gpu_command_buffer_stub.cc(1169)] Image with ID doesn't exist. [14991:14991:0718/154740.256674:ERROR:gpu_command_buffer_stub.cc(1138)] Format is not supported. [14991:14991:0718/154740.259277:ERROR:gles2_cmd_decoder.cc(17904)] [.Offscreen-For-WebGL-0x3c8422c9cc00]GL ERROR :GL_INVALID_OPERATION : glBindTexImage2DCHROMIUM: no image found with the given ID [14991:14991:0718/154740.259423:ERROR:gles2_cmd_decoder.cc(17954)] [.Offscreen-For-WebGL-0x3c8422c9cc00]GL ERROR :GL_INVALID_OPERATION : glReleaseTexImage2DCHROMIUM: no image found with the given ID
,
Jul 18 2017
submitted the CL; https://chromium-review.googlesource.com/c/576616/
,
Jul 18 2017
,
Jul 19 2017
One problem that's going to come up due to RGB emulation on top of RGBA textures is Issue 699566 . The fix for that bug was Mac-specific (being able to bind two textures to the same GPU memory buffer / IOSurface) and I have a feeling that it's not going to work on Chrome OS.
,
Jul 20 2017
,
Jul 20 2017
,
Jul 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ab29a5f0b7dbe72343f9435e811aa6aea20e8ad9 commit ab29a5f0b7dbe72343f9435e811aa6aea20e8ad9 Author: Dongseong Hwang <dongseong.hwang@intel.com> Date: Thu Jul 20 20:10:46 2017 webgl, cros: make chromium image work on ChromeOS. BGRX_8888 Gpu Memory Buffer is not always supported. Before using it, check it available first. BUG= 746069 TEST=run WebGL Aquarium on eve Change-Id: Ib49784a7706cfebd8edd572011c874b18f805f86 Reviewed-on: https://chromium-review.googlesource.com/576616 Reviewed-by: Dongseong Hwang <dongseong.hwang@intel.com> Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Dongseong Hwang <dongseong.hwang@intel.com> Cr-Commit-Position: refs/heads/master@{#488374} [modify] https://crrev.com/ab29a5f0b7dbe72343f9435e811aa6aea20e8ad9/third_party/WebKit/Source/platform/graphics/gpu/DEPS [modify] https://crrev.com/ab29a5f0b7dbe72343f9435e811aa6aea20e8ad9/third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.cpp
,
Jul 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8780d0364351b12562f6505be6685e47a0c24261 commit 8780d0364351b12562f6505be6685e47a0c24261 Author: Dongseong Hwang <dongseong.hwang@intel.com> Date: Thu Jul 20 22:55:19 2017 webgl, cros: hardware overlay requires BGR native GBM RGB texture backed by native GMB cannot be bound to FBO on Intel, but BGR texture backed by native GMB can be bound. When GL_EXT_texture_format_BGRA8888 is supported, as-is chromium doesn't allow BGRA and glTexStorage2D together, because the extensions doesn't define BGRA8 storage format. Now native GBM needs BGR for WebGL hardware overlay, so this CL allows both of them for WebGL context. It's safe because WebGL API doesn't expose BGRA, and DrawingBuffer never use glTexStorage2D(BGRA8). BUG= 746069 TEST=run WebGL Aquarium on eve CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I0e74f738beff16826dcc7af5684791712923851c Reviewed-on: https://chromium-review.googlesource.com/576967 Commit-Queue: Dongseong Hwang <dongseong.hwang@intel.com> Reviewed-by: Kenneth Russell <kbr@chromium.org> Reviewed-by: Dongseong Hwang <dongseong.hwang@intel.com> Cr-Commit-Position: refs/heads/master@{#488461} [modify] https://crrev.com/8780d0364351b12562f6505be6685e47a0c24261/gpu/command_buffer/service/feature_info.cc
,
Jul 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8780d0364351b12562f6505be6685e47a0c24261 commit 8780d0364351b12562f6505be6685e47a0c24261 Author: Dongseong Hwang <dongseong.hwang@intel.com> Date: Thu Jul 20 22:55:19 2017 webgl, cros: hardware overlay requires BGR native GBM RGB texture backed by native GMB cannot be bound to FBO on Intel, but BGR texture backed by native GMB can be bound. When GL_EXT_texture_format_BGRA8888 is supported, as-is chromium doesn't allow BGRA and glTexStorage2D together, because the extensions doesn't define BGRA8 storage format. Now native GBM needs BGR for WebGL hardware overlay, so this CL allows both of them for WebGL context. It's safe because WebGL API doesn't expose BGRA, and DrawingBuffer never use glTexStorage2D(BGRA8). BUG= 746069 TEST=run WebGL Aquarium on eve CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I0e74f738beff16826dcc7af5684791712923851c Reviewed-on: https://chromium-review.googlesource.com/576967 Commit-Queue: Dongseong Hwang <dongseong.hwang@intel.com> Reviewed-by: Kenneth Russell <kbr@chromium.org> Reviewed-by: Dongseong Hwang <dongseong.hwang@intel.com> Cr-Commit-Position: refs/heads/master@{#488461} [modify] https://crrev.com/8780d0364351b12562f6505be6685e47a0c24261/gpu/command_buffer/service/feature_info.cc
,
Jul 21 2017
,
Aug 3 2017
Verified on 9801.1.0/62.0.3174.0 |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 Deleted