Issue metadata
Sign in to add a comment
|
TopDocumentIsolationTest fails in Win64 trunk builder |
||||||||||||||||||||||
Issue descriptionBelow mentioned content_browsertests fails in Win64 trunk builder. TopDocumentIsolationTest.FramesForSitesInHistory TopDocumentIsolationTest.NavigateSubframeToTopSite TopDocumentIsolationTest.NavigateToSubframeSiteWithPopup Link to the builder =================== https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/win64%20trunk/builds/19084 Link to the log file ==================== https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/win64%20trunk/builds/19084/steps/content_browsertests/logs/stdio Error Log ========= TopDocumentIsolationTest.FramesForSitesInHistory (run #2): [ RUN ] TopDocumentIsolationTest.FramesForSitesInHistory [8400:4392:0718/133141.713:24265659:ERROR:devtools_http_handler.cc(786)] DevTools listening on 127.0.0.1:51241 [8400:8612:0718/133207.525:24291461:WARNING:render_frame_host_impl.cc(2589)] OnDidStopLoading was called twice. [8400:8612:0718/133209.689:24293630:WARNING:render_frame_host_impl.cc(2589)] OnDidStopLoading was called twice. These tests were failing since long time.We are trying to make the builder green and in this case unable to find the regressed range and the test is not flaky. Assigning to creis@ since he fixed few of similar test failures based on Issue 611300 . Also looping to sheriff for disabling the failure.
,
Jul 19 2017
Removing sheriff label now that tests are disabled on Windows.
,
Jul 25 2017
Thanks for disabling the test, verified in latest win trunk build. https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/win64%20trunk/builds/19273 Can we tag the bug as fixed?
,
Jul 25 2017
Comment 3: No, we should get these tests fixed and re-enabled before closing this. It looks like all of these tests were timing out, so that's probably a different issue than issue 611300 (where we were occasionally getting the wrong output from DepictFrameTree).
,
Jul 25 2017
This looks very similar to issue 746055 (which has been marked a duplicate of issue 650175). It sounds like content_browsertests are just timing out in general on that bot? We should not be disabling tests across all Windows bots if that's the case. Can we revert this CL and fix issue 650175 instead?
,
Jul 25 2017
Issue 741189 may be similar as well.
,
Jul 31 2017
I think we probably should revert r487790 and let the underlying issue be resolved in issue 650175. I'll revert it and mark this as duplicate.
,
Jul 31 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/aee10624b70963310816351b6f7fd356877bb9e5 commit aee10624b70963310816351b6f7fd356877bb9e5 Author: Charlie Reis <creis@chromium.org> Date: Mon Jul 31 23:42:15 2017 Revert "Disable Failing TopDocumentIsolationTests on Windows" This reverts commit 9934ccbc242de2a3c5dff837083703065c9926bd. Reason for revert: Many content_browsertests are timing out on the official builder due to https://crbug.com/650175, which should be solved separately. These individual tests shouldn't be disabled on all Windows bots. Original change's description: > Disable Failing TopDocumentIsolationTests on Windows > > This change disables failing TopDocumentIsolationTests on Windows. > > http://uberchromegw/i/official.desktop.continuous/builders/win64%20trunk/builds/19098 > > TBR=creis@chromium.org > > Bug: 746063 > Change-Id: I3e77e55e5c30d55906f8ff5885eddc319a6e72bd > Reviewed-on: https://chromium-review.googlesource.com/575973 > Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org> > Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> > Cr-Commit-Position: refs/heads/master@{#487790} TBR=creis@chromium.org,jdoerrie@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 746063 Change-Id: I45a9407a9ee0ac6bdd25d2b638d42421b0392881 Reviewed-on: https://chromium-review.googlesource.com/594690 Reviewed-by: Charlie Reis <creis@chromium.org> Commit-Queue: Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#490822} [modify] https://crrev.com/aee10624b70963310816351b6f7fd356877bb9e5/content/browser/top_document_isolation_browsertest.cc
,
Aug 1 2017
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by bugdroid1@chromium.org
, Jul 19 2017