New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 746048 link

Starred by 1 user
Status: Verified
Owner:
newcomer@chromium.org
Closed: Jul 2017
Cc:
█ maajid@chromium.org
█ vadimt@chromium.org
shibasheikh@chromium.org
mkarkada@chromium.org
dhadd...@chromium.org
sgabr...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

From PEEKING, searching just spaces puts the launcher into HALF without search suggestions

Project Member Reported by maajid@chromium.org, Jul 18 2017 
What steps will reproduce the problem?
(1) Open the launcher in peeking mode.
(2) Press the spacebar.

What is the expected result?
Unclear for V1; regular Google search will show the zero query suggestions. It presumably should either stay in peeking mode with no suggestion, or go to half screen with a suggestion. This should also be consistent with fullscreen (fullscreen currently just activates the searchbox and doesn't show any suggested results)

What happens instead?
See attached screenshot. It goes to half screen with an activated search box, with no suggested search dropdown.
spacessearch.png
288 KB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 20 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/29666b56da43d3819ceeab32cd889c228c6b4126

commit 29666b56da43d3819ceeab32cd889c228c6b4126
Author: Alex Newcomer <newcomer@chromium.org>
Date: Thu Jul 20 23:13:05 2017

cros launcher: Check for whitespace query.

Instead of transitioning to HALF or FULLSCREEN_SEARCH whenever the
search query is not empty, transition only when the query is not empty
and contains some non-whitespace characters.

This will be changed when Zero Query State is introduced, at a later
date.

for-Commit-Position: refs/heads/master@{#487254}
Bug:  746048 
Change-Id: I78a2eb73589d3a13c2213d9f4f1d26f2c6162dc8
Reviewed-on: https://chromium-review.googlesource.com/578470
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Yury Khmel <khmel@chromium.org>
Commit-Queue: Alex Newcomer <newcomer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488474}
[modify] https://crrev.com/29666b56da43d3819ceeab32cd889c228c6b4126/ash/app_list/app_list_presenter_delegate_unittest.cc
[modify] https://crrev.com/29666b56da43d3819ceeab32cd889c228c6b4126/testing/buildbot/filters/ash_unittests_mash.filter
[modify] https://crrev.com/29666b56da43d3819ceeab32cd889c228c6b4126/ui/app_list/views/app_list_view.cc
[modify] https://crrev.com/29666b56da43d3819ceeab32cd889c228c6b4126/ui/app_list/views/search_box_view.cc
[modify] https://crrev.com/29666b56da43d3819ceeab32cd889c228c6b4126/ui/app_list/views/search_result_list_view.cc

Comment 2 by newcomer@chromium.org, Jul 21 2017

Status: Fixed (was: Assigned)

Comment 3 by newcomer@chromium.org, Jul 21 2017

Cc: maajid@chromium.org

Comment 4 by newcomer@chromium.org, Jul 27 2017

Labels: Merge-Request-61
Project Member

Comment 5 by sheriffbot@chromium.org, Jul 28 2017

Labels: -Merge-Request-61 Hotlist-Merge-Approved Merge-Approved-61
Your change meets the bar and is auto-approved for M61. Please go ahead and merge the CL to branch 3163 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), ketakid @(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 6 by sheriffbot@chromium.org, Aug 1 2017 

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 7 by sheriffbot@chromium.org, Aug 4 2017 

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 8 by mkarkada@chromium.org, Aug 9 2017

Cc: mkarkada@chromium.org dhadd...@chromium.org
Status: Verified (was: Fixed)
Verified on Chrome OS 9824.0.0, 62.0.3176.0 dev build.

Comment 9 by newcomer@chromium.org, Dec 17

Labels: -Merge-Approved-61
►

Sign in to add a comment