New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 746047 link

Starred by 1 user
Status: Archived
Owner: ----
Closed: Mar 2018
Cc:
█ quluman@google.com
ayatane@chromium.org
pprabhu@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

break up chromite/lib/constants.py

Project Member Reported by akes...@chromium.org, Jul 18 2017 
chromite/lib/constants.py is full of module-specific constants all thrown together in one big mess. This causes us to pull in many unnecessary dependencies from modules that could otherwise be isolated, and makes the code generally messier and harder to read.

Comment 1 by akes...@chromium.org, Jul 18 2017

Cc: pprabhu@chromium.org quluman@google.com ayatane@chromium.org
It also might even introduce non-appengine-compatible dependencies where they are unneeded.

Comment 2 by akes...@chromium.org, Jul 18 2017 

In general, constants that are needed by only 1 module should be moved to that module (and made private).

constants that are used by a few closely related modules should be moved to the most sensible common module that they depend on.
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 4 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/593014dca7fff79d0643a733660d84c403e662ea

commit 593014dca7fff79d0643a733660d84c403e662ea
Author: Aviv Keshet <akeshet@chromium.org>
Date: Fri Aug 04 04:51:37 2017

constant: move waterfall constants to own file

BUG= chromium:746047 
TEST=None

Change-Id: I179e54d5fa9dabc7a9137b11db8edc64047d4310
Reviewed-on: https://chromium-review.googlesource.com/577050
Commit-Ready: Aviv Keshet <akeshet@chromium.org>
Tested-by: Aviv Keshet <akeshet@chromium.org>
Reviewed-by: Aviv Keshet <akeshet@chromium.org>

[modify] https://crrev.com/593014dca7fff79d0643a733660d84c403e662ea/lib/clactions_unittest.py
[modify] https://crrev.com/593014dca7fff79d0643a733660d84c403e662ea/cbuildbot/chromeos_config.py
[modify] https://crrev.com/593014dca7fff79d0643a733660d84c403e662ea/cbuildbot/stages/sync_stages_unittest.py
[modify] https://crrev.com/593014dca7fff79d0643a733660d84c403e662ea/cbuildbot/cbuildbot_run_unittest.py
[modify] https://crrev.com/593014dca7fff79d0643a733660d84c403e662ea/cbuildbot/stages/generic_stages_unittest.py
[modify] https://crrev.com/593014dca7fff79d0643a733660d84c403e662ea/lib/config_lib_unittest.py
[add] https://crrev.com/593014dca7fff79d0643a733660d84c403e662ea/lib/const/README
[modify] https://crrev.com/593014dca7fff79d0643a733660d84c403e662ea/lib/cidb_integration_test.py
[modify] https://crrev.com/593014dca7fff79d0643a733660d84c403e662ea/cbuildbot/stages/scheduler_stages_unittest.py
[modify] https://crrev.com/593014dca7fff79d0643a733660d84c403e662ea/cbuildbot/stages/test_stages_unittest.py
[modify] https://crrev.com/593014dca7fff79d0643a733660d84c403e662ea/cbuildbot/cbuildbot_run.py
[add] https://crrev.com/593014dca7fff79d0643a733660d84c403e662ea/lib/const/__init__.py
[modify] https://crrev.com/593014dca7fff79d0643a733660d84c403e662ea/cbuildbot/stages/report_stages.py
[modify] https://crrev.com/593014dca7fff79d0643a733660d84c403e662ea/cbuildbot/stages/build_stages_unittest.py
[add] https://crrev.com/593014dca7fff79d0643a733660d84c403e662ea/lib/const/waterfall.py
[modify] https://crrev.com/593014dca7fff79d0643a733660d84c403e662ea/scripts/summarize_build_stats_unittest.py
[modify] https://crrev.com/593014dca7fff79d0643a733660d84c403e662ea/lib/buildbucket_lib.py
[modify] https://crrev.com/593014dca7fff79d0643a733660d84c403e662ea/lib/hwtest_results_unittest.py
[modify] https://crrev.com/593014dca7fff79d0643a733660d84c403e662ea/cbuildbot/build_status_unittest.py
[modify] https://crrev.com/593014dca7fff79d0643a733660d84c403e662ea/scripts/cros_best_revision_unittest.py
[modify] https://crrev.com/593014dca7fff79d0643a733660d84c403e662ea/scripts/cbuildbot.py
[modify] https://crrev.com/593014dca7fff79d0643a733660d84c403e662ea/cbuildbot/stages/report_stages_unittest.py
[modify] https://crrev.com/593014dca7fff79d0643a733660d84c403e662ea/cbuildbot/binhost_test.py
[modify] https://crrev.com/593014dca7fff79d0643a733660d84c403e662ea/cbuildbot/validation_pool_unittest.py
[modify] https://crrev.com/593014dca7fff79d0643a733660d84c403e662ea/cbuildbot/manifest_version_unittest.py
[modify] https://crrev.com/593014dca7fff79d0643a733660d84c403e662ea/lib/config_lib.py
[modify] https://crrev.com/593014dca7fff79d0643a733660d84c403e662ea/cbuildbot/chromeos_config_unittest.py
[modify] https://crrev.com/593014dca7fff79d0643a733660d84c403e662ea/cbuildbot/stages/completion_stages_unittest.py
[modify] https://crrev.com/593014dca7fff79d0643a733660d84c403e662ea/lib/builder_status_lib_unittest.py
[modify] https://crrev.com/593014dca7fff79d0643a733660d84c403e662ea/lib/constants.py
[modify] https://crrev.com/593014dca7fff79d0643a733660d84c403e662ea/scripts/som_alerts_dispatcher.py

Comment 4 by ayatane@chromium.org, Mar 14 2018

Status: Archived (was: Untriaged)
This bug is very old, is Untriaged, and has no owner.  If it is still relevant, reopen as Untriaged or open a new bug
►

Sign in to add a comment