[rebaseline-cl] Support rebaselining a subset of platforms without filling in results |
||||
Issue descriptionCurrently, if results are only available for a subset of the supported platforms, and webkit-patch rebaseline-cl is run, it will prompt: Would you like to try to fill in missing results with available results? This assumes that layout test results for the platforms with missing results are the same as results on other platforms. Y/n However, suppose one knows that a change should only affect particular platforms and they only trigger try jobs on that platform. It should still be possible to rebaseline and in this case, we don't want to try to "fill in" any platforms. In this case, the tool could prompt the user like this: Would you like to: 1. Try to fill in results for missing builders? 2. Continue, ignoring missing builders? 3. Abort for now. > 2 Downloading baselines...
,
Jul 24 2017
Originally I was thinking of using a list import with three items: 1. continue, filling in results 2. continue, only updating results for ports with results 3. abort But I found that host.user.prompt_with_list doesn't work quite the way I'd like for that purpose (accepting only one option) -- instead it also accepts ranges and the word "all". I made a CL to make it prompt as before, but if the user answers "no" to filling in results, the script goes ahead with rebaselining for only some ports (https://chromium-review.googlesource.com/582272). With this behavior, if you want to abort then you'd Ctrl+C instead of answer "y" or "n". Another possible way that it could behave is it could first ask "do you want to continue?" and then ask "do you want to fill in results for absent builders, i.e. are the new results expected to be cross-platform?" Does anyone have any thoughts about what's better?
,
Jul 24 2017
I don't have a strong opinion. Our scripts do not always exit gracefully when ctrl+c'ing so it might be best to go with an explicit approach rather than relying on ctrl+c.
,
Jul 25 2017
,
Jul 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c4dd365c1e19b80c5e4ec45a636e9601364848a2 commit c4dd365c1e19b80c5e4ec45a636e9601364848a2 Author: Quinten Yearsley <qyearsley@google.com> Date: Fri Jul 28 00:18:54 2017 Allow rebaselining with missing builds without filling in Bug: 746029 Change-Id: I1d1afbc6e7c730589952b413aaefa3e94b44fd96 Reviewed-on: https://chromium-review.googlesource.com/582272 Commit-Queue: Quinten Yearsley <qyearsley@chromium.org> Reviewed-by: Walter Korman <wkorman@chromium.org> Cr-Commit-Position: refs/heads/master@{#490155} [modify] https://crrev.com/c4dd365c1e19b80c5e4ec45a636e9601364848a2/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl.py [modify] https://crrev.com/c4dd365c1e19b80c5e4ec45a636e9601364848a2/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl_unittest.py
,
Jul 28 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 by sheriffbot@chromium.org
, Jul 19 2017