Add CQ coverage for VariationsService code |
||||
Issue descriptionSee http://go/chromepostmortem470 for provenance. https://crbug.com/742707 , a consistent startup crash on Windows and Mac, was caught in canary. It's surprising that CQ didn't catch this. We should add coverage for such crashes.
,
Jul 18 2017
It's not enabled for official builds because Chromium builds shouldn't talk to Google for experiments. I agree it's not optimal in terms of testing. We could still have the object but just not do the fetching.
,
Jul 18 2017
"We could still have the object but just not do the fetching." One of my later CLs moves most of SetupFieldTrials() into VariationsFieldTrialCreator. That could be a good time to rework this.
,
Jul 20 2017
,
Jul 26 2017
Changing title since this is tracking specifically having VariationsService be tested by Chromium builds. Kyle has a CL in the works along these lines, so changing owner to him.
,
Jul 26 2017
,
Jul 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a913c84885430612de2a5984c7d6cb21d485cb63 commit a913c84885430612de2a5984c7d6cb21d485cb63 Author: Kyle Milka <kmilka@google.com> Date: Thu Jul 27 08:35:56 2017 Prevent non-official builds from fetching from the variations server. This CL restricts variations seed fetching to only official Chrome builds. This will allow the CQ to catch bugs related to the VariationsService object for all Chromium builds, but prevent Chromium from fetching from the variations server. Bug: 746019 Change-Id: I897844b4ca2cf54c212142c68ac29652df70ee84 Reviewed-on: https://chromium-review.googlesource.com/583716 Commit-Queue: Kyle Milka <kmilka@google.com> Reviewed-by: Alexei Svitkine (OOO July28-Aug6) <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#489884} [modify] https://crrev.com/a913c84885430612de2a5984c7d6cb21d485cb63/components/variations/service/variations_service.cc [modify] https://crrev.com/a913c84885430612de2a5984c7d6cb21d485cb63/components/variations/service/variations_service_unittest.cc |
||||
►
Sign in to add a comment |
||||
Comment 1 by paulmiller@chromium.org
, Jul 18 2017