New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 746019 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
Email to this user bounced
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Add CQ coverage for VariationsService code

Project Member Reported by paulmiller@chromium.org, Jul 18 2017

Issue description

See http://go/chromepostmortem470 for provenance.

 https://crbug.com/742707 , a consistent startup crash on Windows and Mac, was caught in canary. It's surprising that CQ didn't catch this. We should add coverage for such crashes.
 
Owner: asvitk...@chromium.org
The VariationsService is only created in official builds:

https://cs.chromium.org/chromium/src/components/variations/service/variations_service.cc?rcl=f7a44e1558455d493b4d519eee318f51e5fe262a&l=532

If there is no VariationsService, then CreateTrialsFromSeed is not called:

https://cs.chromium.org/chromium/src/chrome/browser/chrome_browser_main.cc?rcl=f58f2b25669173bf3032225603725a2469e01ff1&l=740

Alexei, why is this tied to official builds? To improve test coverage in unofficial builds, could we create the VariationsService, but treat all experiments as disabled?
It's not enabled for official builds because Chromium builds shouldn't talk to Google for experiments. I agree it's not optimal in terms of testing. We could still have the object but just not do the fetching.

Comment 3 by kmilka@google.com, Jul 18 2017

"We could still have the object but just not do the fetching."

One of my later CLs moves most of SetupFieldTrials() into VariationsFieldTrialCreator. That could be a good time to rework this.
Components: -Infra>CQ Infra>Client>Chrome
Cc: -kmilka@google.com
Owner: kmilka@google.com
Summary: Add CQ coverage for VariationsService code (was: Add CQ coverage for startup crashes)
Changing title since this is tracking specifically having VariationsService be tested by Chromium builds. Kyle has a CL in the works along these lines, so changing owner to him.

Comment 6 by kmilka@google.com, Jul 26 2017

Status: Fixed (was: Available)
Project Member

Comment 7 by bugdroid1@chromium.org, Jul 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a913c84885430612de2a5984c7d6cb21d485cb63

commit a913c84885430612de2a5984c7d6cb21d485cb63
Author: Kyle Milka <kmilka@google.com>
Date: Thu Jul 27 08:35:56 2017

Prevent non-official builds from fetching from the variations server.

This CL restricts variations seed fetching to only official Chrome
builds. This will allow the CQ to catch bugs related to the
VariationsService object for all Chromium builds, but prevent Chromium
from fetching from the variations server.

Bug:  746019 
Change-Id: I897844b4ca2cf54c212142c68ac29652df70ee84
Reviewed-on: https://chromium-review.googlesource.com/583716
Commit-Queue: Kyle Milka <kmilka@google.com>
Reviewed-by: Alexei Svitkine (OOO July28-Aug6) <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#489884}
[modify] https://crrev.com/a913c84885430612de2a5984c7d6cb21d485cb63/components/variations/service/variations_service.cc
[modify] https://crrev.com/a913c84885430612de2a5984c7d6cb21d485cb63/components/variations/service/variations_service_unittest.cc

Sign in to add a comment