New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 745970 link

Starred by 1 user
Status: Started
Owner:
donnd@chromium.org
Cc:
█ zkoch@chromium.org
twelling...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Feature

Blocked on:
issue 746493
issue 746097


Sign in to add a comment

[TTS] Add support for a v2 tap suppression experiment

Project Member Reported by donnd@chromium.org, Jul 18 2017 
We'd like to do another tap suppression experiment, and maybe also set some default tap suppression behavior (via variations params).

Background: In part, this is motivated by the Machine Learning Tap Suppression taking a long time, and in part because we've been gathering data on features to use for the ML suppression and can have some confidence in applying them for suppression now.  Several signals seem directly usable for suppression: if the tap duration is short, if the tapped word is short in length, if the tap happened around the same time as a scroll gesture, etc.  We're close to having the infrastructure to simply build an experiment using existing flag settings, but some small adjustments seem desirable.

Details: 
A) The short-word suppression should check that the language of the text is not ideographic (CJKV) before suppressing.
B) The recent-scroll suppression doesn't have an experiment flag to adjust the duration.
C) We should check that we're logging how often we're suppressing.
D) It would be nice if the second-tap logic logged a counterfactual (even though we don't have the infrastructure to use a second tap as a reduction in tap-suppression).
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 18 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/23aada6c8f027de1327c7707a8091bf32248b37b

commit 23aada6c8f027de1327c7707a8091bf32248b37b
Author: Donn Denman <donnd@google.com>
Date: Tue Jul 18 20:58:16 2017

[TTS] Add experiment control for tap-after-scroll.

Adds a variations param to allow experimentation on tap
suppression after a recent scroll.  This suppression
is on by default, but we may want to increase the value
in a general tap-suppression experiment. This param
existed in a previous version so we're using the same
param name as before to avoid confusion.

Bug: 745970
Change-Id: Ie73f354f5ed799c00034e1d206fffa9e0746c25c
Reviewed-on: https://chromium-review.googlesource.com/576347
Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Donn Denman <donnd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487599}
[modify] https://crrev.com/23aada6c8f027de1327c7707a8091bf32248b37b/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchFieldTrial.java
[modify] https://crrev.com/23aada6c8f027de1327c7707a8091bf32248b37b/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/RecentScrollTapSuppression.java

Comment 2 by donnd@chromium.org, Jul 19 2017

Blockedon: 746097
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 19 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f59c3a2376e6f75fff13560c2c94853efe3cb38d

commit f59c3a2376e6f75fff13560c2c94853efe3cb38d
Author: Donn Denman <donnd@google.com>
Date: Wed Jul 19 17:21:03 2017

[TTS] Fix word parsing in East Asian alphabets.

Updates Contextual Search to correctly handle words in alphabets
with unreliable word-break characters. The Android method
Character.isIdeographic does not do what I thought it did!
Instead we now use a regular expression to scan a string
for non latin_basic characters.

Also updates the short/long word suppression to be less
confusing when applied to non-latin languages. Since these
characters in CJKV alphabets are data-dense the shortness rule
should not apply.

BUG=745970,  746097 

Change-Id: I65527c614a2ae3a1e74df90a01f00f5e60fea197
Reviewed-on: https://chromium-review.googlesource.com/576909
Commit-Queue: Donn Denman <donnd@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487898}
[modify] https://crrev.com/f59c3a2376e6f75fff13560c2c94853efe3cb38d/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchContext.java
[modify] https://crrev.com/f59c3a2376e6f75fff13560c2c94853efe3cb38d/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchEntityHeuristic.java
[modify] https://crrev.com/f59c3a2376e6f75fff13560c2c94853efe3cb38d/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/TapWordLengthSuppression.java
[modify] https://crrev.com/f59c3a2376e6f75fff13560c2c94853efe3cb38d/chrome/android/junit/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchContextForTest.java
[modify] https://crrev.com/f59c3a2376e6f75fff13560c2c94853efe3cb38d/chrome/android/junit/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchContextTest.java

Comment 4 by donnd@chromium.org, Jul 19 2017

Blockedon: 746493
►

Sign in to add a comment