Need better integration tests for UKM use cases. |
|||
Issue descriptionWe need some integration tests covering important UKM functionality. * UKM is disabled when new non-sync profiles get opened * UKM is disabled & purged when sync is disabled * UKM is disabled & purged when UMA is disabled. The unit test for these do not currently cover all of the code.
,
Jul 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ed06a0caf649c5b79d79d4b7cf59aa76c73b3551 commit ed06a0caf649c5b79d79d4b7cf59aa76c73b3551 Author: Steven Holte <holte@google.com> Date: Wed Jul 19 23:54:30 2017 Add UKM Browser Test for metrics consent handling. Bug: 745939 Change-Id: Iba676c4a1dec33473f067a0bdf4074dc6b15c435 Reviewed-on: https://chromium-review.googlesource.com/577011 Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by: Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#488050} [modify] https://crrev.com/ed06a0caf649c5b79d79d4b7cf59aa76c73b3551/chrome/browser/metrics/ukm_browsertest.cc
,
Jul 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a19ed1b1c33432b34c3788f53335fae8bdad2649 commit a19ed1b1c33432b34c3788f53335fae8bdad2649 Author: Steven Holte <holte@google.com> Date: Thu Jul 20 18:58:53 2017 Add UKM Browser Test for sync disable handling. Bug: 745939 Change-Id: I30d487641e5cb3130961c46305e4999e2e7ef63d Reviewed-on: https://chromium-review.googlesource.com/577062 Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by: Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#488335} [modify] https://crrev.com/a19ed1b1c33432b34c3788f53335fae8bdad2649/chrome/browser/metrics/ukm_browsertest.cc
,
Aug 22 2017
Further tests we should add: * Guest profile * Disable handling w/ Multi-profile * Sync passphrase handling (secondary encryption)
,
Sep 1 2017
,
Jan 18 2018
I'll create a test for the Guest profile being open.
,
Jan 24 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8ab4a8055d12f558e16e97aa703565a734c122f6 commit 8ab4a8055d12f558e16e97aa703565a734c122f6 Author: Brian White <bcwhite@chromium.org> Date: Wed Jan 24 19:03:00 2018 Test UKM disable for guest profile. Bug: 745939 Change-Id: I721c13ffffa6a32e5fa64a6f9993688df82760a9 Reviewed-on: https://chromium-review.googlesource.com/875911 Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Steven Holte <holte@chromium.org> Reviewed-by: Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#531630} [modify] https://crrev.com/8ab4a8055d12f558e16e97aa703565a734c122f6/chrome/browser/metrics/ukm_browsertest.cc [modify] https://crrev.com/8ab4a8055d12f558e16e97aa703565a734c122f6/chrome/test/base/in_process_browser_test.cc [modify] https://crrev.com/8ab4a8055d12f558e16e97aa703565a734c122f6/chrome/test/base/in_process_browser_test.h [modify] https://crrev.com/8ab4a8055d12f558e16e97aa703565a734c122f6/chrome/test/base/in_process_browser_test_mac.cc
,
Apr 2 2018
The cases mentioned here are all covered. The last remaining case integration test case that needs coverage is described by: https://bugs.chromium.org/p/chromium/issues/detail?id=804439 |
|||
►
Sign in to add a comment |
|||
Comment 1 by bugdroid1@chromium.org
, Jul 19 2017