New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 745894 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

cleanup code after ChromeOS bug autofiler

Project Member Reported by akes...@chromium.org, Jul 18 2017

Issue description

Tracking bug for all the code that will be deleted to turn off ChromeOS bug autofiler.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/18282082489dce1d6f3be24373827638dafb0c4f

commit 18282082489dce1d6f3be24373827638dafb0c4f
Author: Aviv Keshet <akeshet@chromium.org>
Date: Wed Jul 19 02:39:06 2017

autotest: delete crbug_crawler, crbug_shell

BUG=chromium:745894
TEST=None

Change-Id: I734de41614f9cdf756514db251a79ab97878193e
Reviewed-on: https://chromium-review.googlesource.com/576376
Commit-Ready: Aviv Keshet <akeshet@chromium.org>
Tested-by: Aviv Keshet <akeshet@chromium.org>
Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org>

[delete] https://crrev.com/0964b5ceef37f73ebdf27f32f42d38316a032424/contrib/crbug_crawler.py
[delete] https://crrev.com/0964b5ceef37f73ebdf27f32f42d38316a032424/contrib/crbug_shell.py

Project Member

Comment 2 by bugdroid1@chromium.org, Jul 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/b5843689572959e3cc96955028211e09a276ccd5

commit b5843689572959e3cc96955028211e09a276ccd5
Author: Aviv Keshet <akeshet@chromium.org>
Date: Wed Jul 19 19:34:34 2017

autotest: remove frontend/health

None of this code has been touched in 4 years, it looks dead, and it
depends on code that is being deleted.

BUG=chromium:745894
TEST=None

Change-Id: I0cd065bd242d014b283d850b4295ff57f0f5ed3c
Reviewed-on: https://chromium-review.googlesource.com/576377
Commit-Ready: Aviv Keshet <akeshet@chromium.org>
Tested-by: Aviv Keshet <akeshet@chromium.org>
Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org>

[delete] https://crrev.com/b05c00b56871604e1958042a13c8efc0aef23b64/frontend/health/check_test_health.py
[delete] https://crrev.com/b05c00b56871604e1958042a13c8efc0aef23b64/frontend/health/complete_failures.py
[delete] https://crrev.com/b05c00b56871604e1958042a13c8efc0aef23b64/frontend/health/utils.py
[delete] https://crrev.com/b05c00b56871604e1958042a13c8efc0aef23b64/frontend/health/manual_check_passing_experimental.py
[delete] https://crrev.com/b05c00b56871604e1958042a13c8efc0aef23b64/frontend/health/check_test_health_unittest.py
[delete] https://crrev.com/b05c00b56871604e1958042a13c8efc0aef23b64/frontend/health/passing_experimental_unittest.py
[delete] https://crrev.com/b05c00b56871604e1958042a13c8efc0aef23b64/frontend/health/utils_unittest.py
[delete] https://crrev.com/b05c00b56871604e1958042a13c8efc0aef23b64/frontend/health/passing_experimental.py
[delete] https://crrev.com/b05c00b56871604e1958042a13c8efc0aef23b64/frontend/health/common.py
[delete] https://crrev.com/b05c00b56871604e1958042a13c8efc0aef23b64/frontend/health/passing_experimental_functional_test.py
[delete] https://crrev.com/b05c00b56871604e1958042a13c8efc0aef23b64/frontend/health/complete_failures_functional_test.py
[delete] https://crrev.com/b05c00b56871604e1958042a13c8efc0aef23b64/frontend/health/__init__.py
[delete] https://crrev.com/b05c00b56871604e1958042a13c8efc0aef23b64/frontend/health/complete_failures_unittest.py

Project Member

Comment 3 by bugdroid1@chromium.org, Jul 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/b2be1819c47b29abc0d5cc1383428e26646f40af

commit b2be1819c47b29abc0d5cc1383428e26646f40af
Author: Aviv Keshet <akeshet@chromium.org>
Date: Fri Jul 28 22:04:28 2017

autotest: reporting(_utils): delete buildbot link generation

Delete dependencies on cros_build_lib related to buildbot link
generated, used for bug filing. Delete all callers
(link_buildbot_stages, _get_metadata_dict) and their callers.

BUG=chromium:745894
TEST=None

Change-Id: Ie20b87b1593810bbc289fa7b8d0c3b2cb66b6eed
Reviewed-on: https://chromium-review.googlesource.com/590567
Commit-Ready: Aviv Keshet <akeshet@chromium.org>
Tested-by: Aviv Keshet <akeshet@chromium.org>
Reviewed-by: Dan Shi <dshi@google.com>

[modify] https://crrev.com/b2be1819c47b29abc0d5cc1383428e26646f40af/server/cros/dynamic_suite/reporting.py
[modify] https://crrev.com/b2be1819c47b29abc0d5cc1383428e26646f40af/server/cros/dynamic_suite/reporting_utils.py

Project Member

Comment 4 by bugdroid1@chromium.org, Jul 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/ff7bd29c13d62c2becf00c2b76408faf5d7ae277

commit ff7bd29c13d62c2becf00c2b76408faf5d7ae277
Author: Aviv Keshet <akeshet@chromium.org>
Date: Sat Jul 29 05:07:55 2017

autotest: reporting: delete reporting.Reporter and all callers

Note: this disables all bug filing from the lab.

BUG=chromium:745894
TEST=None

Change-Id: I1932b969cd70b2b89946b718bcc7d3d7409b080f
Reviewed-on: https://chromium-review.googlesource.com/590568
Commit-Ready: Aviv Keshet <akeshet@chromium.org>
Tested-by: Aviv Keshet <akeshet@chromium.org>
Reviewed-by: Aviv Keshet <akeshet@chromium.org>

[modify] https://crrev.com/ff7bd29c13d62c2becf00c2b76408faf5d7ae277/server/cros/dynamic_suite/suite.py
[modify] https://crrev.com/ff7bd29c13d62c2becf00c2b76408faf5d7ae277/site_utils/suite_scheduler/deduping_scheduler.py
[modify] https://crrev.com/ff7bd29c13d62c2becf00c2b76408faf5d7ae277/server/cros/dynamic_suite/reporting.py
[modify] https://crrev.com/ff7bd29c13d62c2becf00c2b76408faf5d7ae277/site_utils/run_suite.py
[modify] https://crrev.com/ff7bd29c13d62c2becf00c2b76408faf5d7ae277/site_utils/diagnosis_utils_unittest.py
[modify] https://crrev.com/ff7bd29c13d62c2becf00c2b76408faf5d7ae277/site_utils/suite_scheduler/deduping_scheduler_unittest.py
[modify] https://crrev.com/ff7bd29c13d62c2becf00c2b76408faf5d7ae277/server/cros/dynamic_suite/reporting_unittest.py
[modify] https://crrev.com/ff7bd29c13d62c2becf00c2b76408faf5d7ae277/site_utils/test_push_unittest.py

Project Member

Comment 5 by bugdroid1@chromium.org, Jul 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/99001d9952eef31ee73bc1e21658ee406f694276

commit 99001d9952eef31ee73bc1e21658ee406f694276
Author: Aviv Keshet <akeshet@chromium.org>
Date: Sat Jul 29 05:07:55 2017

autotest: delete phapi_lib, gdata external package

BUG=chromium:745894
TEST=None

Change-Id: Iac8c855f93ca9e9e3e458b6073cabe2e11f698c8
Reviewed-on: https://chromium-review.googlesource.com/590570
Commit-Ready: Aviv Keshet <akeshet@chromium.org>
Tested-by: Aviv Keshet <akeshet@chromium.org>
Reviewed-by: Dan Shi <dshi@google.com>

[delete] https://crrev.com/ff7bd29c13d62c2becf00c2b76408faf5d7ae277/site_utils/phapi_lib.py
[modify] https://crrev.com/99001d9952eef31ee73bc1e21658ee406f694276/utils/external_packages.py

Project Member

Comment 7 by bugdroid1@chromium.org, Aug 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/6b53c38429c8039437f8d613b8f467383d077625

commit 6b53c38429c8039437f8d613b8f467383d077625
Author: Aviv Keshet <akeshet@chromium.org>
Date: Fri Aug 04 00:11:02 2017

autotest: temporarily short-cut some broken reporter logic

BUG=chromium:751762, chromium:751428, chromium:745894
TEST=None

Change-Id: Ibf5ee378599d814f4979d416189cd6dc5d9aa5eb
Reviewed-on: https://chromium-review.googlesource.com/598667
Commit-Ready: Aviv Keshet <akeshet@chromium.org>
Tested-by: Aviv Keshet <akeshet@chromium.org>
Reviewed-by: Aviv Keshet <akeshet@chromium.org>

[modify] https://crrev.com/6b53c38429c8039437f8d613b8f467383d077625/server/cros/dynamic_suite/suite.py
[modify] https://crrev.com/6b53c38429c8039437f8d613b8f467383d077625/server/cros/dynamic_suite/suite_unittest.py

Labels: Hotlist-Fixit
Summary: cleanup code after ChromeOS bug autofiler (was: disable ChromeOS bug autofiler)
Note: fallout of this was that failure emails stopped working. That is being addressed in Issue 751428.

Items remaining:

 - There are a bunch of references to |file_bugs|, plumbed through dynamic_suite and suite. This attribute is now either deprecated or misnamed (it does currently control whether failure emails will be sent, I think).
 - Most or nearly all of reporting.py and reporting_util.py is now obsolete, we just need to comb through it.
Labels: -Pri-2 Pri-3
Project Member

Comment 10 by bugdroid1@chromium.org, Aug 15 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/manifest-internal/+/e78d361b29b6133f0f91b8c1869fb3242fbfd69e

commit e78d361b29b6133f0f91b8c1869fb3242fbfd69e
Author: Aviv Keshet <akeshet@chromium.org>
Date: Tue Aug 15 21:54:10 2017

Project Member

Comment 11 by bugdroid1@chromium.org, Aug 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/manifest/+/8a28da319ead333e8c7ef6d353c02b9467e93abe

commit 8a28da319ead333e8c7ef6d353c02b9467e93abe
Author: Aviv Keshet <akeshet@chromium.org>
Date: Tue Aug 15 21:54:10 2017

drop gdata checkout

CQ-DEPEND=CL:*419991, CL:590692
BUG=chromium:745894
TEST=None

Change-Id: I461a9b077b84747479cc3c2c84c59009b406aa51
Reviewed-on: https://chromium-review.googlesource.com/590583
Commit-Ready: Aviv Keshet <akeshet@chromium.org>
Tested-by: Aviv Keshet <akeshet@chromium.org>
Reviewed-by: Bernie Thompson <bhthompson@chromium.org>

[modify] https://crrev.com/8a28da319ead333e8c7ef6d353c02b9467e93abe/full.xml

Project Member

Comment 12 by bugdroid1@chromium.org, Sep 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/013afa56a76153c864a710abaaaafb5204e1a04a

commit 013afa56a76153c864a710abaaaafb5204e1a04a
Author: Prathmesh Prabhu <pprabhu@chromium.org>
Date: Fri Sep 08 04:21:21 2017

[autotest] Re-enable result reporting logic.

This is a long-winded revert of CL:598667

After that CL landed, CL:602868 privatized an object was earlier passed
into Suite.wait
While the intention was good (not needing to pass in a reporter whenever
one wants to call Suite.wait), the approach made it impossible to
unittest that results were actually reported (and so the revert, which
would have added a check back no longer worked).
This CL achieves the same effect by dependency injection -- Suite
creates and used the default _ResultReporter but allows unittests to
pass in a fake.

TEST=unittests pass.

BUG=chromium:751762
BUG=chromium:751428
BUG=chromium:745894

Change-Id: Id5b03209162201c7be1a7bffca7d164dd487fbfa
Reviewed-on: https://chromium-review.googlesource.com/655623
Commit-Ready: Prathmesh Prabhu <pprabhu@chromium.org>
Tested-by: Prathmesh Prabhu <pprabhu@chromium.org>
Reviewed-by: Xixuan Wu <xixuan@chromium.org>

[modify] https://crrev.com/013afa56a76153c864a710abaaaafb5204e1a04a/server/cros/dynamic_suite/suite.py
[modify] https://crrev.com/013afa56a76153c864a710abaaaafb5204e1a04a/server/cros/dynamic_suite/suite_unittest.py

Cc: akes...@chromium.org
Owner: ----
Status: Available (was: Started)
Hi, this bug has not been updated recently. Please acknowledge the bug and provide status within two weeks (6/22/2018), or the bug will be archived. Thank you.

Sign in to add a comment