Add a flag to disable touch interaction mode of the Files app. |
||||||
Issue descriptionThe UI changes to improve touch UI interaction should be behind an about:flags flag. https://bugs.chromium.org/p/chromium/issues/detail?id=730232 Add a flag (which is OFF by default) to enable the relevant UI changes, and have it available in about://flags.
,
Jul 18 2017
,
Jul 19 2017
Changed the summary as the feature will be ON by default. We'll add a flag to disable the feature just in case.
,
Jul 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/281eabf35ec7be9feb28e955da36b6dbc13e7649 commit 281eabf35ec7be9feb28e955da36b6dbc13e7649 Author: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Date: Wed Jul 19 21:55:52 2017 Add flag to disable touch-specific interactions of the Files app. This change also includes a change to hide the context menu button added by https://chromium-review.googlesource.com/c/566768/ when the flag is set. Bug: 745879 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I1f1a75f55eab76e9ec3300a73820937357a37679 Reviewed-on: https://chromium-review.googlesource.com/574902 Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Reviewed-by: Naoki Fukino <fukino@chromium.org> Cr-Commit-Position: refs/heads/master@{#488004} [modify] https://crrev.com/281eabf35ec7be9feb28e955da36b6dbc13e7649/chrome/browser/about_flags.cc [modify] https://crrev.com/281eabf35ec7be9feb28e955da36b6dbc13e7649/chrome/browser/flag_descriptions.cc [modify] https://crrev.com/281eabf35ec7be9feb28e955da36b6dbc13e7649/chrome/browser/flag_descriptions.h [modify] https://crrev.com/281eabf35ec7be9feb28e955da36b6dbc13e7649/chromeos/chromeos_switches.cc [modify] https://crrev.com/281eabf35ec7be9feb28e955da36b6dbc13e7649/chromeos/chromeos_switches.h [modify] https://crrev.com/281eabf35ec7be9feb28e955da36b6dbc13e7649/tools/metrics/histograms/enums.xml [modify] https://crrev.com/281eabf35ec7be9feb28e955da36b6dbc13e7649/ui/file_manager/file_manager/foreground/js/file_manager.js [modify] https://crrev.com/281eabf35ec7be9feb28e955da36b6dbc13e7649/ui/file_manager/file_manager/main.html
,
Jul 20 2017
,
Jul 26 2017
Although this flag is added in ://flags, change to hide the context menu item is not reflecting when this flag is set to disabled. Checked on M62( Chrome OS 9778.0.0/62.0.3165.0 dev build)
,
Jul 26 2017
The feature to be disabled by the flag is this one. https://bugs.chromium.org/p/chromium/issues/detail?id=740842 - When check-select a file, the three-dots button in the white toolbar stays there. So when the flag is set to disabled, the three-dots button will not be shown while in the check-select mode. (which is same behavior as M60). Issues 742784 and 742779 are also relevant features to be disabled by the flag, but haven't been implemented at the moment.
,
Jul 28 2017
Verified on M61 dev build 9765.9.0, 61.0.3163.16. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by yamaguchi@chromium.org
, Jul 18 2017