New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 745867 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Use other robhogan account instead.
Closed: Sep 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug



Sign in to add a comment

Name hidden in whatsapp web in group chat

Project Member Reported by robho...@gmail.com, Jul 18 2017

Issue description

Reduction to follow.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/49ca53470be380333903aae3b3e1100015d2050c

commit 49ca53470be380333903aae3b3e1100015d2050c
Author: Robert Hogan <robhogan@gmail.com>
Date: Fri Jul 28 09:54:45 2017

Don't truncate inline atomic elements before an ellipsis

A follow-up to https://chromium-review.googlesource.com/c/539460/, we
need to remember the linebox we added the ellipsis to and only hide
atomic inline elements associated with lineboxes that occur after it.

Bug:  745867 
Change-Id: Iab6d82b7bdf67c05262f6b0b8eb30415f1cab338
Reviewed-on: https://chromium-review.googlesource.com/579973
Commit-Queue: Robert Hogan <robhogan@gmail.com>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490341}
[modify] https://crrev.com/49ca53470be380333903aae3b3e1100015d2050c/third_party/WebKit/LayoutTests/TestExpectations
[add] https://crrev.com/49ca53470be380333903aae3b3e1100015d2050c/third_party/WebKit/LayoutTests/fast/text/atomic-inline-before-ellipsis.html
[add] https://crrev.com/49ca53470be380333903aae3b3e1100015d2050c/third_party/WebKit/LayoutTests/platform/linux/fast/text/atomic-inline-before-ellipsis-expected.png
[add] https://crrev.com/49ca53470be380333903aae3b3e1100015d2050c/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/text/atomic-inline-before-ellipsis-expected.png
[add] https://crrev.com/49ca53470be380333903aae3b3e1100015d2050c/third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/text/atomic-inline-before-ellipsis-expected.png
[add] https://crrev.com/49ca53470be380333903aae3b3e1100015d2050c/third_party/WebKit/LayoutTests/platform/mac/fast/text/atomic-inline-before-ellipsis-expected.png
[add] https://crrev.com/49ca53470be380333903aae3b3e1100015d2050c/third_party/WebKit/LayoutTests/platform/win/fast/text/atomic-inline-before-ellipsis-expected.png
[add] https://crrev.com/49ca53470be380333903aae3b3e1100015d2050c/third_party/WebKit/LayoutTests/platform/win7/fast/text/atomic-inline-before-ellipsis-expected.png
[modify] https://crrev.com/49ca53470be380333903aae3b3e1100015d2050c/third_party/WebKit/Source/core/layout/LayoutBlockFlow.h
[modify] https://crrev.com/49ca53470be380333903aae3b3e1100015d2050c/third_party/WebKit/Source/core/layout/LayoutBlockFlowLine.cpp
[modify] https://crrev.com/49ca53470be380333903aae3b3e1100015d2050c/third_party/WebKit/Source/core/layout/LayoutDeprecatedFlexibleBox.cpp
[modify] https://crrev.com/49ca53470be380333903aae3b3e1100015d2050c/third_party/WebKit/Source/core/layout/line/InlineBox.cpp
[modify] https://crrev.com/49ca53470be380333903aae3b3e1100015d2050c/third_party/WebKit/Source/core/layout/line/InlineBox.h
[modify] https://crrev.com/49ca53470be380333903aae3b3e1100015d2050c/third_party/WebKit/Source/core/layout/line/InlineFlowBox.cpp
[modify] https://crrev.com/49ca53470be380333903aae3b3e1100015d2050c/third_party/WebKit/Source/core/layout/line/InlineFlowBox.h
[modify] https://crrev.com/49ca53470be380333903aae3b3e1100015d2050c/third_party/WebKit/Source/core/layout/line/InlineTextBox.cpp
[modify] https://crrev.com/49ca53470be380333903aae3b3e1100015d2050c/third_party/WebKit/Source/core/layout/line/InlineTextBox.h
[modify] https://crrev.com/49ca53470be380333903aae3b3e1100015d2050c/third_party/WebKit/Source/core/layout/line/RootInlineBox.cpp
[modify] https://crrev.com/49ca53470be380333903aae3b3e1100015d2050c/third_party/WebKit/Source/core/layout/line/RootInlineBox.h

Project Member

Comment 2 by bugdroid1@chromium.org, Jul 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/be5bfe1766359702932614d572d0190528d77240

commit be5bfe1766359702932614d572d0190528d77240
Author: Robert Hogan <robhogan@gmail.com>
Date: Fri Jul 28 15:24:28 2017

Revert "Don't truncate inline atomic elements before an ellipsis"

This reverts commit 49ca53470be380333903aae3b3e1100015d2050c.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> Don't truncate inline atomic elements before an ellipsis
> 
> A follow-up to https://chromium-review.googlesource.com/c/539460/, we
> need to remember the linebox we added the ellipsis to and only hide
> atomic inline elements associated with lineboxes that occur after it.
> 
> Bug:  745867 
> Change-Id: Iab6d82b7bdf67c05262f6b0b8eb30415f1cab338
> Reviewed-on: https://chromium-review.googlesource.com/579973
> Commit-Queue: Robert Hogan <robhogan@gmail.com>
> Reviewed-by: Emil A Eklund <eae@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#490341}

TBR=robhogan@gmail.com,eae@chromium.org

Change-Id: I5a17b9ec73e227a2b54b46eb71e3bd4e0b6f299d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  745867 
Reviewed-on: https://chromium-review.googlesource.com/591887
Reviewed-by: Robert Hogan <robhogan@gmail.com>
Commit-Queue: Robert Hogan <robhogan@gmail.com>
Cr-Commit-Position: refs/heads/master@{#490399}
[modify] https://crrev.com/be5bfe1766359702932614d572d0190528d77240/third_party/WebKit/LayoutTests/TestExpectations
[delete] https://crrev.com/2d47d48ec9b029b9526b93becef714d552e4726b/third_party/WebKit/LayoutTests/fast/text/atomic-inline-before-ellipsis.html
[delete] https://crrev.com/2d47d48ec9b029b9526b93becef714d552e4726b/third_party/WebKit/LayoutTests/platform/linux/fast/text/atomic-inline-before-ellipsis-expected.png
[delete] https://crrev.com/2d47d48ec9b029b9526b93becef714d552e4726b/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/text/atomic-inline-before-ellipsis-expected.png
[delete] https://crrev.com/2d47d48ec9b029b9526b93becef714d552e4726b/third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/text/atomic-inline-before-ellipsis-expected.png
[delete] https://crrev.com/2d47d48ec9b029b9526b93becef714d552e4726b/third_party/WebKit/LayoutTests/platform/mac/fast/text/atomic-inline-before-ellipsis-expected.png
[delete] https://crrev.com/2d47d48ec9b029b9526b93becef714d552e4726b/third_party/WebKit/LayoutTests/platform/win/fast/text/atomic-inline-before-ellipsis-expected.png
[delete] https://crrev.com/2d47d48ec9b029b9526b93becef714d552e4726b/third_party/WebKit/LayoutTests/platform/win7/fast/text/atomic-inline-before-ellipsis-expected.png
[modify] https://crrev.com/be5bfe1766359702932614d572d0190528d77240/third_party/WebKit/Source/core/layout/LayoutBlockFlow.h
[modify] https://crrev.com/be5bfe1766359702932614d572d0190528d77240/third_party/WebKit/Source/core/layout/LayoutBlockFlowLine.cpp
[modify] https://crrev.com/be5bfe1766359702932614d572d0190528d77240/third_party/WebKit/Source/core/layout/LayoutDeprecatedFlexibleBox.cpp
[modify] https://crrev.com/be5bfe1766359702932614d572d0190528d77240/third_party/WebKit/Source/core/layout/line/InlineBox.cpp
[modify] https://crrev.com/be5bfe1766359702932614d572d0190528d77240/third_party/WebKit/Source/core/layout/line/InlineBox.h
[modify] https://crrev.com/be5bfe1766359702932614d572d0190528d77240/third_party/WebKit/Source/core/layout/line/InlineFlowBox.cpp
[modify] https://crrev.com/be5bfe1766359702932614d572d0190528d77240/third_party/WebKit/Source/core/layout/line/InlineFlowBox.h
[modify] https://crrev.com/be5bfe1766359702932614d572d0190528d77240/third_party/WebKit/Source/core/layout/line/InlineTextBox.cpp
[modify] https://crrev.com/be5bfe1766359702932614d572d0190528d77240/third_party/WebKit/Source/core/layout/line/InlineTextBox.h
[modify] https://crrev.com/be5bfe1766359702932614d572d0190528d77240/third_party/WebKit/Source/core/layout/line/RootInlineBox.cpp
[modify] https://crrev.com/be5bfe1766359702932614d572d0190528d77240/third_party/WebKit/Source/core/layout/line/RootInlineBox.h

Project Member

Comment 3 by bugdroid1@chromium.org, Jul 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2cacb3e68525e05acc94af794998c87a85b645df

commit 2cacb3e68525e05acc94af794998c87a85b645df
Author: Nate Chapin <japhet@chromium.org>
Date: Fri Jul 28 17:59:57 2017

Remove deleted test from enable-blink-features=LayoutNG

BUG= 745867 
TBR=petermayo,robhogan@gmail.com

Change-Id: I21d7682a56f76b4ef9deaea12429bd888180d916
Reviewed-on: https://chromium-review.googlesource.com/591948
Reviewed-by: Nate Chapin <japhet@chromium.org>
Reviewed-by: Peter Mayo <petermayo@chromium.org>
Commit-Queue: Nate Chapin <japhet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490458}

Project Member

Comment 4 by bugdroid1@chromium.org, Jul 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/133f781660563dac94b5cce3f17bf61b45c82526

commit 133f781660563dac94b5cce3f17bf61b45c82526
Author: Takeshi Yoshino <tyoshino@chromium.org>
Date: Fri Jul 28 18:05:07 2017

Remove a non-existent layout test from FlagExpectations/enable-blink-features=LayoutNG

fast/text/atomic-inline-before-ellipsis.html was added in
https://chromium.googlesource.com/chromium/src/+/7f8fd3222bac91dcca7bb73a6779ff95a71298fc%5E%21/
but it doesn't exist.

I just got a presubmit error for this (not sure why as I didn't
touch anything around this).

It was added by https://chromium-review.googlesource.com/c/579973/
but the patch has been reverted.

Bug: 591099,  745867 
Change-Id: Idc4eb3530d49cac399bcbac8457f3bab58d59840

TBR=kojii@chromium.org

Change-Id: Idc4eb3530d49cac399bcbac8457f3bab58d59840
Reviewed-on: https://chromium-review.googlesource.com/592087
Reviewed-by: Takeshi Yoshino <tyoshino@chromium.org>
Commit-Queue: Takeshi Yoshino <tyoshino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490461}

Project Member

Comment 5 by bugdroid1@chromium.org, Jul 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1cb584a78df79b205fa7de04beb28c6f848bde33

commit 1cb584a78df79b205fa7de04beb28c6f848bde33
Author: Robert Hogan <robhogan@gmail.com>
Date: Sat Jul 29 14:13:21 2017

Reland "Don't truncate inline atomic elements before an ellipsis"

This is a reland of 49ca53470be380333903aae3b3e1100015d2050c
Original change's description:
> Don't truncate inline atomic elements before an ellipsis
> 
> A follow-up to https://chromium-review.googlesource.com/c/539460/, we
> need to remember the linebox we added the ellipsis to and only hide
> atomic inline elements associated with lineboxes that occur after it.
> 
> Bug:  745867 
> Change-Id: Iab6d82b7bdf67c05262f6b0b8eb30415f1cab338
> Reviewed-on: https://chromium-review.googlesource.com/579973
> Commit-Queue: Robert Hogan <robhogan@gmail.com>
> Reviewed-by: Emil A Eklund <eae@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#490341}

Bug:  745867 
Change-Id: Iaae3f85525588d97a76946005138f8b85253a713
Reviewed-on: https://chromium-review.googlesource.com/592967
Commit-Queue: Robert Hogan <robhogan@gmail.com>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490648}
[add] https://crrev.com/1cb584a78df79b205fa7de04beb28c6f848bde33/third_party/WebKit/LayoutTests/fast/text/atomic-inline-before-ellipsis.html
[add] https://crrev.com/1cb584a78df79b205fa7de04beb28c6f848bde33/third_party/WebKit/LayoutTests/platform/linux/fast/text/atomic-inline-before-ellipsis-expected.png
[add] https://crrev.com/1cb584a78df79b205fa7de04beb28c6f848bde33/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/text/atomic-inline-before-ellipsis-expected.png
[add] https://crrev.com/1cb584a78df79b205fa7de04beb28c6f848bde33/third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/text/atomic-inline-before-ellipsis-expected.png
[add] https://crrev.com/1cb584a78df79b205fa7de04beb28c6f848bde33/third_party/WebKit/LayoutTests/platform/mac/fast/text/atomic-inline-before-ellipsis-expected.png
[add] https://crrev.com/1cb584a78df79b205fa7de04beb28c6f848bde33/third_party/WebKit/LayoutTests/platform/win/fast/text/atomic-inline-before-ellipsis-expected.png
[add] https://crrev.com/1cb584a78df79b205fa7de04beb28c6f848bde33/third_party/WebKit/LayoutTests/platform/win7/fast/text/atomic-inline-before-ellipsis-expected.png
[modify] https://crrev.com/1cb584a78df79b205fa7de04beb28c6f848bde33/third_party/WebKit/Source/core/layout/LayoutBlockFlow.h
[modify] https://crrev.com/1cb584a78df79b205fa7de04beb28c6f848bde33/third_party/WebKit/Source/core/layout/LayoutBlockFlowLine.cpp
[modify] https://crrev.com/1cb584a78df79b205fa7de04beb28c6f848bde33/third_party/WebKit/Source/core/layout/LayoutDeprecatedFlexibleBox.cpp
[modify] https://crrev.com/1cb584a78df79b205fa7de04beb28c6f848bde33/third_party/WebKit/Source/core/layout/line/InlineBox.cpp
[modify] https://crrev.com/1cb584a78df79b205fa7de04beb28c6f848bde33/third_party/WebKit/Source/core/layout/line/InlineBox.h
[modify] https://crrev.com/1cb584a78df79b205fa7de04beb28c6f848bde33/third_party/WebKit/Source/core/layout/line/InlineFlowBox.cpp
[modify] https://crrev.com/1cb584a78df79b205fa7de04beb28c6f848bde33/third_party/WebKit/Source/core/layout/line/InlineFlowBox.h
[modify] https://crrev.com/1cb584a78df79b205fa7de04beb28c6f848bde33/third_party/WebKit/Source/core/layout/line/InlineTextBox.cpp
[modify] https://crrev.com/1cb584a78df79b205fa7de04beb28c6f848bde33/third_party/WebKit/Source/core/layout/line/InlineTextBox.h
[modify] https://crrev.com/1cb584a78df79b205fa7de04beb28c6f848bde33/third_party/WebKit/Source/core/layout/line/RootInlineBox.cpp
[modify] https://crrev.com/1cb584a78df79b205fa7de04beb28c6f848bde33/third_party/WebKit/Source/core/layout/line/RootInlineBox.h

Comment 6 by robho...@gmail.com, Jul 30 2017

Labels: Merge-Request-61
Project Member

Comment 7 by sheriffbot@chromium.org, Jul 30 2017

Labels: -Merge-Request-61 Merge-Review-61 Hotlist-Merge-Review
This bug requires manual review: Reverts referenced in bugdroid comments after merge request.
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), ketakid @(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 8 by gov...@chromium.org, Jul 31 2017

Pls apply appropriate OSs label. Thank you.

Comment 9 by robho...@gmail.com, Jul 31 2017

Labels: OS-All

Comment 10 by robho...@gmail.com, Jul 31 2017

Labels: -Pri-3 Pri-1
Before we approve merge to M61, could you please answer followings?
* Is this M61 regression? 
* Is this critical to have it in M61 or can wait until M62? Please note M61 is already branched on July 20th and we're only taking critical merges in.
* There are multiple large cls are listed here, all need to be merged to M61? If yes, all changes are well baked/verified in Canary, having enough automation tests coverage and safe to merge?

Comment 12 by robho...@gmail.com, Jul 31 2017

Cc: e...@chromium.org
* Is this M61 regression? 
- Yes.

* Is this critical to have it in M61 or can wait until M62? Please note M61 is already branched on July 20th and we're only taking critical merges in.
- It affects web.whatsapp.com in a very obvious way so I think its bad enough to fix asap.

* There are multiple large cls are listed here, all need to be merged to M61? If yes, all changes are well baked/verified in Canary, having enough automation tests coverage and safe to merge?
 - Only one CL needs to be landed - the other two are a revert and a reland. The revert was due to an unintentional change to TestExpectations. Since no-one is banging down the door to get it fixed we could let it bake until someone does!




Labels: -Merge-Review-61 Merge-Approved-61
Thank you  robhogan@.

Approving merge to M61 branch 3163 based on comment #12 and after discussing with eae@ (Per eae@, Should be safe and we need it).
Project Member

Comment 14 by bugdroid1@chromium.org, Jul 31 2017

Labels: -merge-approved-61 merge-merged-3163
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/57339921ef3a738e4858f8ca5c55a448fa913dd2

commit 57339921ef3a738e4858f8ca5c55a448fa913dd2
Author: Robert Hogan <robhogan@gmail.com>
Date: Mon Jul 31 20:37:40 2017

Reland "Don't truncate inline atomic elements before an ellipsis"

This is a reland of 49ca53470be380333903aae3b3e1100015d2050c
Original change's description:
> Don't truncate inline atomic elements before an ellipsis
>
> A follow-up to https://chromium-review.googlesource.com/c/539460/, we
> need to remember the linebox we added the ellipsis to and only hide
> atomic inline elements associated with lineboxes that occur after it.
>
> Bug:  745867 
> Change-Id: Iab6d82b7bdf67c05262f6b0b8eb30415f1cab338
> Reviewed-on: https://chromium-review.googlesource.com/579973
> Commit-Queue: Robert Hogan <robhogan@gmail.com>
> Reviewed-by: Emil A Eklund <eae@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#490341}

TBR=robhogan@gmail.com

(cherry picked from commit 1cb584a78df79b205fa7de04beb28c6f848bde33)

Bug:  745867 
Change-Id: Iaae3f85525588d97a76946005138f8b85253a713
Reviewed-on: https://chromium-review.googlesource.com/592967
Commit-Queue: Robert Hogan <robhogan@gmail.com>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#490648}
Reviewed-on: https://chromium-review.googlesource.com/594988
Reviewed-by: Robert Hogan <robhogan@gmail.com>
Cr-Commit-Position: refs/branch-heads/3163@{#177}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[add] https://crrev.com/57339921ef3a738e4858f8ca5c55a448fa913dd2/third_party/WebKit/LayoutTests/fast/text/atomic-inline-before-ellipsis.html
[add] https://crrev.com/57339921ef3a738e4858f8ca5c55a448fa913dd2/third_party/WebKit/LayoutTests/platform/linux/fast/text/atomic-inline-before-ellipsis-expected.png
[add] https://crrev.com/57339921ef3a738e4858f8ca5c55a448fa913dd2/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/text/atomic-inline-before-ellipsis-expected.png
[add] https://crrev.com/57339921ef3a738e4858f8ca5c55a448fa913dd2/third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/text/atomic-inline-before-ellipsis-expected.png
[add] https://crrev.com/57339921ef3a738e4858f8ca5c55a448fa913dd2/third_party/WebKit/LayoutTests/platform/mac/fast/text/atomic-inline-before-ellipsis-expected.png
[add] https://crrev.com/57339921ef3a738e4858f8ca5c55a448fa913dd2/third_party/WebKit/LayoutTests/platform/win/fast/text/atomic-inline-before-ellipsis-expected.png
[add] https://crrev.com/57339921ef3a738e4858f8ca5c55a448fa913dd2/third_party/WebKit/LayoutTests/platform/win7/fast/text/atomic-inline-before-ellipsis-expected.png
[modify] https://crrev.com/57339921ef3a738e4858f8ca5c55a448fa913dd2/third_party/WebKit/Source/core/layout/LayoutBlockFlow.h
[modify] https://crrev.com/57339921ef3a738e4858f8ca5c55a448fa913dd2/third_party/WebKit/Source/core/layout/LayoutBlockFlowLine.cpp
[modify] https://crrev.com/57339921ef3a738e4858f8ca5c55a448fa913dd2/third_party/WebKit/Source/core/layout/LayoutDeprecatedFlexibleBox.cpp
[modify] https://crrev.com/57339921ef3a738e4858f8ca5c55a448fa913dd2/third_party/WebKit/Source/core/layout/line/InlineBox.cpp
[modify] https://crrev.com/57339921ef3a738e4858f8ca5c55a448fa913dd2/third_party/WebKit/Source/core/layout/line/InlineBox.h
[modify] https://crrev.com/57339921ef3a738e4858f8ca5c55a448fa913dd2/third_party/WebKit/Source/core/layout/line/InlineFlowBox.cpp
[modify] https://crrev.com/57339921ef3a738e4858f8ca5c55a448fa913dd2/third_party/WebKit/Source/core/layout/line/InlineFlowBox.h
[modify] https://crrev.com/57339921ef3a738e4858f8ca5c55a448fa913dd2/third_party/WebKit/Source/core/layout/line/InlineTextBox.cpp
[modify] https://crrev.com/57339921ef3a738e4858f8ca5c55a448fa913dd2/third_party/WebKit/Source/core/layout/line/InlineTextBox.h
[modify] https://crrev.com/57339921ef3a738e4858f8ca5c55a448fa913dd2/third_party/WebKit/Source/core/layout/line/RootInlineBox.cpp
[modify] https://crrev.com/57339921ef3a738e4858f8ca5c55a448fa913dd2/third_party/WebKit/Source/core/layout/line/RootInlineBox.h

Status: Fixed (was: Assigned)

Sign in to add a comment