New issue
Advanced search Search tips

Issue 745866 link

Starred by 2 users
Status: Fixed
Owner:
mthiesse@chromium.org
Closed: Jul 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug-Regression
Proj-VR
Proj-XR
Proj-XR-VR



Sign in to add a comment

VR browser frame rate regressed from 60 fps to 30

Project Member Reported by cjgrant@chromium.org, Jul 18 2017 
ToT as of July 18 sees the browser render at 30 fps (both release and debug builds).

Through selective reverting, the offending commit is:

VR: Fix VSync drift.
db92e6b421f4d3e40a01a00a0fc77b9ad2fe13af

Without those changes, the reticle is butter smooth and adb logging shows 60 frames generated per second.
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 18 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a782190edd2b96c2d1bd496faa41d07775e20803

commit a782190edd2b96c2d1bd496faa41d07775e20803
Author: Michael Thiessen <mthiesse@chromium.org>
Date: Tue Jul 18 23:06:52 2017

VR: Fix rounding error in VSync computation.

Also fixes the timebase being off by a factor of 1000, though this
didn't actually cause issues...

Bug:  745866 
Change-Id: Ia29646ce935bf66b45a5f6aee10bf7715a3fea17
Reviewed-on: https://chromium-review.googlesource.com/575700
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Christopher Grant <cjgrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487648}
[modify] https://crrev.com/a782190edd2b96c2d1bd496faa41d07775e20803/chrome/browser/android/vr_shell/vr_shell_delegate.cc
[modify] https://crrev.com/a782190edd2b96c2d1bd496faa41d07775e20803/chrome/browser/android/vr_shell/vr_shell_gl.cc

Comment 2 by mthiesse@chromium.org, Jul 19 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment