New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 745798 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: ----
Type: ----



Sign in to add a comment

ios_chrome_ui_egtests failing on iPAd

Project Member Reported by sdefresne@chromium.org, Jul 18 2017

Issue description

Labels: OS-iOS
Cc: jif@chromium.org edchin@chromium.org
Owner: jlebel@chromium.org
Status: Assigned (was: Available)
The test that timeout are SigninInteractionControllerTestCase. One example test failing is SigninInteractionControllerTestCase.testSignInOneUser that fails deterministically (fail even if this is the only test run).

Failure is when happens on the following line:

    TapButtonWithLabelId(IDS_IOS_ACCOUNT_CONSISTENCY_CONFIRMATION_OK_BUTTON);

Error is:

Exception Name: TimeoutException
Exception Reason: Timed out while waiting to perform action.
Exception with Action: {
  "Action Name" : "Tap",
  "Element Matcher" : "(((respondsToSelector(isAccessibilityElement) && isAccessibilityElement) && accessibilityLabel('Ok, Got it')) && ((respondsToSelector(isAccessibilityElement) && isAccessibilityElement) && accessibilityTraits: UIAccessibilityTraitButton))"
}

Exception Details: Error Trace: [
  {
    "Description" : "Failed to execute block because idling resources below are busy.",
    "Description Glossary" :     {
      "GREYAppStateTracker" : "Waiting for CAAnimations to finish. Continuous animations may never finish and must be stopped explicitly. Animations attached to hidden view may still be running in the background.
Waiting for UIView's draw/layout pass to complete. A draw/layout pass normally completes in the next runloop drain.

Assigning to jlebel@ as owner of signin, will disable the tests on iPad.
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1cb215be3baa5952f9538d032d79bda580c7b10a

commit 1cb215be3baa5952f9538d032d79bda580c7b10a
Author: Sylvain Defresne <sdefresne@chromium.org>
Date: Tue Jul 18 17:09:29 2017

Disable SigninInteractionControllerTestCase EG tests.

Those tests are consistently timing out on iPad, disabling them
on iPad until the root cause is fixed to turn the bots green.

Bug:  745798 
Change-Id: I5f0dab981cae4fbef9f81d144ffa0492a16cfa12
Reviewed-on: https://chromium-review.googlesource.com/576171
Reviewed-by: Jérôme Lebel <jlebel@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487506}
[modify] https://crrev.com/1cb215be3baa5952f9538d032d79bda580c7b10a/ios/chrome/browser/ui/authentication/signin_interaction_controller_egtest.mm

Labels: ReleaseBlock-Stable M-61
Cc: olivierrobin@chromium.org
It looks like the failures are caused by https://chromium-review.googlesource.com/c/569538/.

Comment 6 by jif@chromium.org, Jul 19 2017

Owner: martiw@chromium.org

Comment 7 by jif@chromium.org, Jul 21 2017

Components: Test>iOS
Status: Fixed (was: Assigned)
The tests have been re-enabled.
Project Member

Comment 9 by bugdroid1@chromium.org, Jul 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/68abc07bf96bcc39581d30741952c9d4b032a4a1

commit 68abc07bf96bcc39581d30741952c9d4b032a4a1
Author: Olivier Robin <olivierrobin@chromium.org>
Date: Fri Jul 21 12:06:17 2017

Revert "Disable SigninInteractionControllerTestCase EG tests."

This reverts commit 1cb215be3baa5952f9538d032d79bda580c7b10a.

Reason for revert: Problem should be fixed. Reenable tests.

Original change's description:
> Disable SigninInteractionControllerTestCase EG tests.
> 
> Those tests are consistently timing out on iPad, disabling them
> on iPad until the root cause is fixed to turn the bots green.
> 
> Bug:  745798 
> Change-Id: I5f0dab981cae4fbef9f81d144ffa0492a16cfa12
> Reviewed-on: https://chromium-review.googlesource.com/576171
> Reviewed-by: Jérôme Lebel <jlebel@chromium.org>
> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#487506}

TBR=sdefresne@chromium.org,jlebel@chromium.org

Change-Id: I5ea0342aa4b6d0c2b1227e52c4f0c0f272695d63
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  745798 
Reviewed-on: https://chromium-review.googlesource.com/577542
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Reviewed-by: Jérôme Lebel <jlebel@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#488635}
[modify] https://crrev.com/68abc07bf96bcc39581d30741952c9d4b032a4a1/ios/chrome/browser/ui/authentication/signin_interaction_controller_egtest.mm

Labels: Merge-TBD
[Auto-generated comment by a script] We noticed that this issue is targeted for M-61; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-61 label, otherwise remove Merge-TBD label. Thanks.
Labels: Merge-Request-61
Project Member

Comment 12 by sheriffbot@chromium.org, Jul 21 2017

Labels: -Merge-Request-61 Merge-Review-61 Hotlist-Merge-Review
This bug requires manual review: Reverts referenced in bugdroid comments after merge request.
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), ketakid @(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
This does not seem to fail on beta bots so not worth merging into M61. Let me know if I am missing something.

Comment 14 Deleted

Cc: rohitrao@chromium.org
martiw@ could you give more details why this should be in M61. cc'ing Rohit since Sylvain is out
Labels: -Merge-Rejected-61 Merge-Request-61
These tests were disabled on trunk because a different CL broke them.  That CL was reverted before the branch was cut, and then the tests were reenabled on trunk after the branch was cut.

On M61, the code is working (because M61 includes the revert), but the tests are still disabled.  It seems like a good idea to re-enable these tests on the branch.

M61 bots will not show any failures because these tests are currently disabled on the branch.
Project Member

Comment 17 by sheriffbot@chromium.org, Jul 25 2017

Labels: -Merge-Request-61 Merge-Review-61 Hotlist-Merge-Review
This bug requires manual review: Reverts referenced in bugdroid comments after merge request.
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), ketakid @(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Hotlist-Merge-Review -Merge-Review-61 Merge-Approved-61
Project Member

Comment 19 by sheriffbot@chromium.org, Jul 31 2017

Cc: cma...@chromium.org
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 20 by sheriffbot@chromium.org, Aug 4 2017

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 21 by sheriffbot@chromium.org, Sep 18 2017

Labels: -Merge-TBD

Sign in to add a comment