New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 745776 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: 1
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Changes to Skia GPU dither require rebaseline of 3 layout tests

Project Member Reported by bsalo...@google.com, Jul 18 2017

Issue description

The images for these tests change very slightly:

virtual/gpu/fast/canvas/canvas-text-alignment.html
virtual/gpu/fast/canvas/fillrect_gradient.html
virtual/gpu/fast/canvas/gradient-add-second-start-end-stop.html	
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dac2a303c878550ecb912cc442d6424ad02fdf76

commit dac2a303c878550ecb912cc442d6424ad02fdf76
Author: Brian Salomon <bsalomon@google.com>
Date: Tue Jul 18 16:58:53 2017

Mark layout tests that need rebaseline after Skia GPU dither change

Bug:  745776 
Change-Id: I95868b7bead32c96c5fb4ccf084d887e8f28eb19
Reviewed-on: https://chromium-review.googlesource.com/576211
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Brian Salomon <bsalomon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487504}
[modify] https://crrev.com/dac2a303c878550ecb912cc442d6424ad02fdf76/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 2 by sheriffbot@chromium.org, Jul 19 2017

Labels: Hotlist-Google
Cc: bsalomon@chromium.org
Components: Blink>Paint
Labels: BugSource-Chromium Test-Layout PaintTeamTriaged-20170802
Owner: schenney@chromium.org
I'll do the update.
Labels: -Hotlist-Google
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9abaa192189aaa220127106043e2c88dd07febc7

commit 9abaa192189aaa220127106043e2c88dd07febc7
Author: Stephen Chenney <schenney@chromium.org>
Date: Fri Aug 04 19:32:26 2017

Rebaseline gradient tests after Skia GPU change

TBR=fmalita@chromium.org
BUG= 745776 

Change-Id: Ia86ee3eeb47469ae077c9bcd658a2e43b11da485
Reviewed-on: https://chromium-review.googlesource.com/598541
Commit-Queue: Stephen Chenney <schenney@chromium.org>
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Reviewed-by: Florin Malita <fmalita@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492101}
[modify] https://crrev.com/9abaa192189aaa220127106043e2c88dd07febc7/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/9abaa192189aaa220127106043e2c88dd07febc7/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu/fast/canvas/canvas-text-alignment-expected.png
[modify] https://crrev.com/9abaa192189aaa220127106043e2c88dd07febc7/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu/fast/canvas/fillrect_gradient-expected.png
[delete] https://crrev.com/0ffb61b2499a9f65399042eddbf25f4e4926f847/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu/fast/canvas/gradient-add-second-start-end-stop-expected.png
[modify] https://crrev.com/9abaa192189aaa220127106043e2c88dd07febc7/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu/fast/canvas/canvas-text-alignment-expected.png
[modify] https://crrev.com/9abaa192189aaa220127106043e2c88dd07febc7/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu/fast/canvas/fillrect_gradient-expected.png
[delete] https://crrev.com/0ffb61b2499a9f65399042eddbf25f4e4926f847/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu/fast/canvas/gradient-add-second-start-end-stop-expected.png
[modify] https://crrev.com/9abaa192189aaa220127106043e2c88dd07febc7/third_party/WebKit/LayoutTests/platform/win/virtual/gpu/fast/canvas/canvas-text-alignment-expected.png
[delete] https://crrev.com/0ffb61b2499a9f65399042eddbf25f4e4926f847/third_party/WebKit/LayoutTests/platform/win/virtual/gpu/fast/canvas/gradient-add-second-start-end-stop-expected.png
[add] https://crrev.com/9abaa192189aaa220127106043e2c88dd07febc7/third_party/WebKit/LayoutTests/platform/win7/virtual/gpu/fast/canvas/fillrect_gradient-expected.png
[add] https://crrev.com/9abaa192189aaa220127106043e2c88dd07febc7/third_party/WebKit/LayoutTests/virtual/gpu/fast/canvas/gradient-add-second-start-end-stop-expected.png

Project Member

Comment 6 by bugdroid1@chromium.org, Aug 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4478c8403c652f8ff7669209a0234f21cdc97cfb

commit 4478c8403c652f8ff7669209a0234f21cdc97cfb
Author: Joe Downing <joedow@chromium.org>
Date: Fri Aug 04 21:45:03 2017

Revert "Rebaseline gradient tests after Skia GPU change"

This reverts commit 9abaa192189aaa220127106043e2c88dd07febc7.

Reason for revert: Causing webkit failure on Win10:
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win10/builds/24216

Original change's description:
> Rebaseline gradient tests after Skia GPU change
> 
> TBR=fmalita@chromium.org
> BUG= 745776 
> 
> Change-Id: Ia86ee3eeb47469ae077c9bcd658a2e43b11da485
> Reviewed-on: https://chromium-review.googlesource.com/598541
> Commit-Queue: Stephen Chenney <schenney@chromium.org>
> Reviewed-by: Stephen Chenney <schenney@chromium.org>
> Reviewed-by: Florin Malita <fmalita@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#492101}

TBR=fmalita@chromium.org,schenney@chromium.org

Change-Id: I7c65bd094abd55bb44defa6d2f3d6a564add47a6
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  745776 
Reviewed-on: https://chromium-review.googlesource.com/602873
Reviewed-by: Joe Downing <joedow@chromium.org>
Commit-Queue: Joe Downing <joedow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492131}
[modify] https://crrev.com/4478c8403c652f8ff7669209a0234f21cdc97cfb/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/4478c8403c652f8ff7669209a0234f21cdc97cfb/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu/fast/canvas/canvas-text-alignment-expected.png
[modify] https://crrev.com/4478c8403c652f8ff7669209a0234f21cdc97cfb/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu/fast/canvas/fillrect_gradient-expected.png
[add] https://crrev.com/4478c8403c652f8ff7669209a0234f21cdc97cfb/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu/fast/canvas/gradient-add-second-start-end-stop-expected.png
[modify] https://crrev.com/4478c8403c652f8ff7669209a0234f21cdc97cfb/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu/fast/canvas/canvas-text-alignment-expected.png
[modify] https://crrev.com/4478c8403c652f8ff7669209a0234f21cdc97cfb/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu/fast/canvas/fillrect_gradient-expected.png
[add] https://crrev.com/4478c8403c652f8ff7669209a0234f21cdc97cfb/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu/fast/canvas/gradient-add-second-start-end-stop-expected.png
[modify] https://crrev.com/4478c8403c652f8ff7669209a0234f21cdc97cfb/third_party/WebKit/LayoutTests/platform/win/virtual/gpu/fast/canvas/canvas-text-alignment-expected.png
[add] https://crrev.com/4478c8403c652f8ff7669209a0234f21cdc97cfb/third_party/WebKit/LayoutTests/platform/win/virtual/gpu/fast/canvas/gradient-add-second-start-end-stop-expected.png
[delete] https://crrev.com/6de7a9c9891246e21f57e58e2a4426f1c250baf7/third_party/WebKit/LayoutTests/platform/win7/virtual/gpu/fast/canvas/fillrect_gradient-expected.png
[delete] https://crrev.com/6de7a9c9891246e21f57e58e2a4426f1c250baf7/third_party/WebKit/LayoutTests/virtual/gpu/fast/canvas/gradient-add-second-start-end-stop-expected.png

Project Member

Comment 7 by bugdroid1@chromium.org, Aug 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9bbc6b9614008bc227791968fdb56b36b3e04e34

commit 9bbc6b9614008bc227791968fdb56b36b3e04e34
Author: Stephen Chenney <schenney@chromium.org>
Date: Mon Aug 07 21:57:55 2017

Rebaseline gradient tests after Skia GPU change

Reland to try to figure out why Win 10 failed. Apparently the
new baseline was missed.

TBR=fmalita@chromium.org
BUG= 745776 

Change-Id: I84bfeb44624dd6be9622dc8c87847943bd747b65
Reviewed-on: https://chromium-review.googlesource.com/603949
Commit-Queue: Stephen Chenney <schenney@chromium.org>
Reviewed-by: Florin Malita <fmalita@chromium.org>
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492426}
[modify] https://crrev.com/9bbc6b9614008bc227791968fdb56b36b3e04e34/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/9bbc6b9614008bc227791968fdb56b36b3e04e34/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu/fast/canvas/canvas-text-alignment-expected.png
[modify] https://crrev.com/9bbc6b9614008bc227791968fdb56b36b3e04e34/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu/fast/canvas/fillrect_gradient-expected.png
[delete] https://crrev.com/f104a448b7086b96aff933a6aa16a50bd85d5ba4/third_party/WebKit/LayoutTests/platform/linux/virtual/gpu/fast/canvas/gradient-add-second-start-end-stop-expected.png
[modify] https://crrev.com/9bbc6b9614008bc227791968fdb56b36b3e04e34/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu/fast/canvas/canvas-text-alignment-expected.png
[modify] https://crrev.com/9bbc6b9614008bc227791968fdb56b36b3e04e34/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu/fast/canvas/fillrect_gradient-expected.png
[delete] https://crrev.com/f104a448b7086b96aff933a6aa16a50bd85d5ba4/third_party/WebKit/LayoutTests/platform/mac/virtual/gpu/fast/canvas/gradient-add-second-start-end-stop-expected.png
[modify] https://crrev.com/9bbc6b9614008bc227791968fdb56b36b3e04e34/third_party/WebKit/LayoutTests/platform/win/virtual/gpu/fast/canvas/canvas-text-alignment-expected.png
[modify] https://crrev.com/9bbc6b9614008bc227791968fdb56b36b3e04e34/third_party/WebKit/LayoutTests/platform/win/virtual/gpu/fast/canvas/fillrect_gradient-expected.png
[delete] https://crrev.com/f104a448b7086b96aff933a6aa16a50bd85d5ba4/third_party/WebKit/LayoutTests/platform/win/virtual/gpu/fast/canvas/gradient-add-second-start-end-stop-expected.png
[add] https://crrev.com/9bbc6b9614008bc227791968fdb56b36b3e04e34/third_party/WebKit/LayoutTests/virtual/gpu/fast/canvas/gradient-add-second-start-end-stop-expected.png

Status: Fixed (was: Assigned)

Sign in to add a comment